Bug 148310

Summary: [PATCH] devel/scons doesn't respect NO_INSTALL_MANPAGES
Product: Ports & Packages Reporter: Ashish SHUKLA <ashish>
Component: Individual Port(s)Assignee: Ashish SHUKLA <ashish>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Ashish SHUKLA freebsd_committer freebsd_triage 2010-07-02 10:50:02 UTC 
When tried to install devel/scons with NOPORTDOCS and
NO_INSTALL_MANPAGES defined, I noticed it has installed man pages and
haven't recorded them in the pkg-plist.

--------8<------------8<-----------------
Creating bzip'd tar ball in '/tmp/packages/All/scons-1.3.0.tbz'
Deleting scons-1.3.0
pkg_delete: file '/usr/local/lib/scons-1.3.0/scons-1.3.0-py2.6.egg-info' doesn't exist
pkg_delete: couldn't entirely delete package (perhaps the packing list is
incorrectly specified?)
================================================================

=== Checking filesystem state
list of extra files and directories in / (not present before this port was installed but present after it was deinstalled)
429333        1 -rw-r--r--    1 root             wheel               24768 Mar 24 02:14 usr/local/man/man1/scons-time.1
429331        1 -rw-r--r--    1 root             wheel              395900 Mar 24 02:14 usr/local/man/man1/scons.1
429332        1 -rw-r--r--    1 root             wheel                4711 Mar 24 02:14 usr/local/man/man1/sconsign.1
Deleting python26-2.6.5
--------8<------------8<-----------------

The complete build log is available from the URL:
http://people.freebsd.org/~ashish/logs/scons-1.3.0.log

The attached diff fixes this issue and also removes an entry for the
'egg-info' file from the pkg-plist since its being implicitly recorded
already.

How-To-Repeat: 
% mkdir /var/tmp/$(make -C /usr/ports/devel/scons -V PORTNAME)
% sudo mtree -U -f $(make -C /usr/ports/devel/scons -V MTREE_FILE) -d -e -p /var/tmp/$(make -C /usr/ports/devel/scons -V PORTNAME)
% sudo make -C /usr/ports/devel/scons -DNOPORTDOCS -DNO_INSTALL_MANPAGES install PREFIX=/var/tmp/$(make -C /usr/ports/devel/scons -V PORTNAME)
% sudo make -C /usr/ports/devel/scons -DNOPORTDOCS -DNO_INSTALL_MANPAGES deinstall PREFIX=/var/tmp/$(make -C /usr/ports/devel/scons -V PORTNAME)
% find /var/tmp/$(make -C /usr/ports/devel/scons -V PORTNAME) -type f
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-07-02 10:50:12 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->ashish

Submitter has GNATS access (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2010-07-02 10:50:14 UTC 
Maintainer of devel/scons,

Please note that PR ports/148310 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/148310

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2010-07-02 10:50:15 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 gavin 2010-08-04 07:24:08 UTC 
Hi,

I'm looking into this currently. The patch isn't what I'd have expected it
to look like
so will test it out.

Gav...
Comment 5 gavin 2010-09-05 09:10:41 UTC 
Hi,

Seems ok to do it this way, there are alternatives but in the interests of
moving on, carry on with this method.

Thanks

Gav...
Comment 6 Ashish SHUKLA freebsd_committer freebsd_triage 2010-09-05 09:33:21 UTC 
=2D----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Gav  writes:
> Hi,

> Seems ok to do it this way, there are alternatives but in the interests of
> moving on, carry on with this method.

Thanks for the reply. I'll get it committed in a day or two.

> Thanks

> Gav...



=2D --=20
Ashish SHUKLA      | GPG: F682 CDCC 39DC 0FEA E116  20B6 C746 CFA9 E74F A4B0
freebsd.org!ashish | http://people.freebsd.org/~ashish/

Avoid Success At All Costs !!
=2D----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)

iQIcBAEBCgAGBQJMg1XVAAoJEMdGz6nnT6SwczgP/1+X7ZwklWBPqW3WWA9saGYu
P0xi0y/xSOfEm1EVGeCAqQESBeZ6gKrXZFlOZqTZ4QkFImlzas0iVh2Q+ps1K1Il
3WV2f/+kE7OMATSuL9BNS2eGTxwBIL26Usj7o6TkQ/sWqXWGb8EZbMPfpOgO6jSD
60jEIrcJDHeP8BxXvrmQSWtmTCyosVZn7PJTTZ7Ud8gCVvvxOTLfpGsBYAaUAxAp
uJkUYc1uXtf+IijWWZJEGruFStNgs4qNM8JcY8Waz+IGMtUYjTNEf8Li1Gd7x0st
uXUnBaPLouKfjS4kqJjLgnVzstaSuF0R6RXIrwXz2EB/S7tK1pAxPtMqrXArRk+e
Q4W6wb3bvTdRTkOaHUMFUmTdq9PqZjCr5ex6WawXAwkyFC5QJTIs3MsvCvVcshbx
GoavxrdcJCPffKTdWlwIt/mEwGZO0FDLDevc6P32nrFoQS7EUrVgK4TOI6vT95Ba
VR9s+GBfBd0m8X6zAAp4rP10w0Tn1PLUxxZWjIrwPQCFJSzlFXerWE/wKyRSUA/0
Qy/XOCSGQF5ThqKED+cNvVHgi6Zhdu40/Q8gUjpyS/UdPuQzckUECBROWk8ZzetC
O5r9jC7dr0gtb4E+urx2u8xGn0E0H2X099T9IDZ6GO4cVfZpUxV9KdQ/hg96qx8s
LAuq/TVdBMCBWnAP+AkN
=3Dp8Rp
=2D----END PGP SIGNATURE-----
Comment 7 dfilter service freebsd_committer freebsd_triage 2010-09-11 18:36:13 UTC 
ashish      2010-09-11 17:36:08 UTC

  FreeBSD ports repository

  Modified files:
    devel/scons          Makefile pkg-plist 
  Log:
  - Fix the port to avoid installing manpages when NO_INSTALL_MANPAGES is defined.
  - Remove the egg-info from the pkg-plist, as it's recorded implicitly.
  
  PR:             ports/148310
  Submitted by:   ashish
  Approved by:    pgj (mentor), gavin at 16degrees.com.au (maintainer)
  
  Revision  Changes    Path
  1.43      +7 -1      ports/devel/scons/Makefile
  1.25      +0 -1      ports/devel/scons/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 8 Ashish SHUKLA freebsd_committer freebsd_triage 2010-09-11 18:36:48 UTC 
State Changed
From-To: feedback->closed

Committed. Thanks!