Bug 14836

Summary:

sys/dev/isp/isp.c compile error

Product:

Base System

Reporter:

kondo <kondo>

Component:

kern

Assignee:

freebsd-bugs (Nobody) <bugs>

Status:

Closed FIXED

Severity:

Affects Only Me

Priority:

Normal

Version:

Unspecified

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
file.diff	none

Description kondo 1999-11-12 02:00:01 UTC

cc -c -O -Wreturn-type -Wcomment -Wredundant-decls -Wimplicit  -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes  -Wpointer-arith  -nostdinc -I- -I. -I../.. -I../../../include -DAPM_BROKEN_STATCLOCK -DFAILSAFE -DCOMPAT_43 -DMSDOSFS -DNFS -DFFS -DINET -DKERNEL  ../../dev/isp/isp.c
../../dev/isp/isp.c: In function `ispscsicmd':
../../dev/isp/isp.c:1944: invalid operands to binary ==
*** Error code 1

Fix: # cvs diff -r RELENG_2_2 isp.c
How-To-Repeat: cd /usr/src/release
make release.3

Comment 1 mjacob 1999-11-12 05:53:36 UTC

Ah! Thanks and sorry!


On Thu, 11 Nov 1999 kondo@ysyslab.co.jp wrote:

> 
> >Number:         14836
> >Category:       kern
> >Synopsis:       sys/dev/isp/isp.c compile error
> >Confidential:   no
> >Severity:       non-critical
> >Priority:       low
> >Responsible:    freebsd-bugs
> >State:          open
> >Quarter:        
> >Keywords:       
> >Date-Required:
> >Class:          sw-bug
> >Submitter-Id:   current-users
> >Arrival-Date:   Thu Nov 11 18:00:01 PST 1999
> >Closed-Date:
> >Last-Modified:
> >Originator:     kondo hiroshi
> >Release:        RELENG_2_2
> >Organization:
> Yokohama System Laboratory Corp.
> >Environment:
> # uname -a
> FreeBSD shiro.ysyslab.co.jp 2.2-STABLE FreeBSD 2.2-STABLE #0: Thu Nov 11 13:50:09 JST 1999     root@shiro.ysyslab.co.jp:/usr/src/sys/compile/GENSB16  i386
> 
> >Description:
> cc -c -O -Wreturn-type -Wcomment -Wredundant-decls -Wimplicit  -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes  -Wpointer-arith  -nostdinc -I- -I. -I../.. -I../../../include -DAPM_BROKEN_STATCLOCK -DFAILSAFE -DCOMPAT_43 -DMSDOSFS -DNFS -DFFS -DINET -DKERNEL  ../../dev/isp/isp.c
> ../../dev/isp/isp.c: In function `ispscsicmd':
> ../../dev/isp/isp.c:1944: invalid operands to binary ==
> *** Error code 1
> 
> >How-To-Repeat:
> cd /usr/src/release
> make release.3
> 
> >Fix:
> # cvs diff -r RELENG_2_2 isp.c
> Index: isp.c
> ===================================================================
> RCS file: /usr/CVS-Repository/src/sys/dev/isp/isp.c,v
> retrieving revision 1.21.2.7
> diff -u -r1.21.2.7 isp.c
> --- isp.c       1999/10/28 02:51:34     1.21.2.7
> +++ isp.c       1999/11/12 01:18:00
> @@ -1941,7 +1941,7 @@
>                 if (XS_CANTAG(xs)) {
>                         t2reqp->req_flags = XS_KINDOF_TAG(xs);
>                 } else {
> -                       if (XS_CDBP(xs)[0] == 0x3)      /* REQUEST SENSE */
> +                       if (XS_CDBP(xs)->opcode == 0x3) /* REQUEST SENSE */
>                                 t2reqp->req_flags = REQFLAG_HTAG;
>                         else
>                                 t2reqp->req_flags = REQFLAG_OTAG;
> 
> 
> >Release-Note:
> >Audit-Trail:
> >Unformatted:
> 
> 
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-bugs" in the body of the message
>

Comment 2 Matt Jacob freebsd_committer

1999-11-12 05:56:57 UTC

State Changed
From-To: open->closed

Supplied patch applied. Thanks!