Bug 149320

Comment 1 Dmitry Marakasov 2010-08-18 16:03:20 UTC

Responsible Changed
From-To: freebsd-ports-bugs->amdmi3

I'll take it.

* Konstantin Lepa (konstantin.lepa@gmail.com) wrote:

> >Synopsis:       New port: textproc/simplexml is C++ XML parser and validator

I propose the following nits:

- Pet portlint
  - CVS Id
  - DISTNAME instead of DISTFILES
  - Canonical statement order (LIB_DEPENDS)
  - USE_LDCONFIG as it installs shared libs
- Don't use cmake's build type - WITH_DEBUG already sets proper
  CFLAGS/CXXFLAGS for building debug versions of software, which,
  unlike unes set by cmake when build type is set, may be changed
  by user as he pleases.

Also, there's checksum mismatch. The downloaded file
has MD5 of dd0ea9272e091ffe23245f26c05e4bec and size of 18170

--- simplexml.patch begins here ---
diff -ruN simplexml/Makefile simplexml_/Makefile
--- simplexml/Makefile	2010-08-18 19:02:41.000000000 +0400
+++ simplexml_/Makefile	2010-08-18 19:01:21.000000000 +0400
@@ -2,32 +2,30 @@
 # Date created:				May 18 2010
 # Whom:					Konstantin Lepa <konstantin.lepa@gmail.com>
 #
+# $FreeBSD$
+#
 
 PORTNAME=	simplexml
 PORTVERSION=	1.0.0
-PORTREVISION=	1
 CATEGORIES=	textproc
 MASTER_SITES=	http://bitbucket.org/badgopher/simplexml/get/
-DISTFILES=	${PORTVERSION}${EXTRACT_SUFX}
+DISTNAME=	${PORTVERSION}
 DIST_SUBDIR=	${PORTNAME}
 
 MAINTAINER=	konstantin.lepa@gmail.com
 COMMENT=	XML parser library
 
+LIB_DEPENDS=	expat.6:${PORTSDIR}/textproc/expat2
+
 USE_GZIP=	yes
 USE_CMAKE=	yes
 USE_ICONV=	yes
+USE_LDCONFIG=	yes
 
-WRKSRC=	${WRKDIR}/${PORTNAME}
+WRKSRC=		${WRKDIR}/${PORTNAME}
 
 .if defined(WITH_DEBUG)
-CMAKE_BUILD_TYPE=	DebugFull
 CMAKE_ARGS+=	DEBUG_MODE:BOOL=ON
 .endif
 
-LIB_DEPENDS+=	expat.6:${PORTSDIR}/textproc/expat2 \
-		iconv.3:${PORTSDIR}/converters/iconv
-
 .include <bsd.port.mk>
-
-# vim: ts=8 sw=8
--- simplexml.patch ends here ---

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru

Comment 3 Dmitry Marakasov 2010-08-18 16:12:57 UTC

State Changed
From-To: open->feedback

Ask for submitter fix.

  Done.

  I changed the location of archive.

Comment 6 dfilter service 2010-08-31 03:05:07 UTC

amdmi3      2010-08-31 02:04:59 UTC

  FreeBSD ports repository

  Modified files:
    textproc             Makefile 
  Added files:
    textproc/simplexml   Makefile distinfo pkg-descr pkg-plist 
  Log:
  A C++ XML parser library.
  
  WWW:    http://bitbucket.org/klepa/simplexml
  
  PR:             149320
  Submitted by:   Konstantin Lepa <konstantin.lepa@gmail.com>
  
  Revision  Changes    Path
  1.1482    +1 -0      ports/textproc/Makefile
  1.1       +36 -0     ports/textproc/simplexml/Makefile (new)
  1.1       +3 -0      ports/textproc/simplexml/distinfo (new)
  1.1       +3 -0      ports/textproc/simplexml/pkg-descr (new)
  1.1       +15 -0     ports/textproc/simplexml/pkg-plist (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"

Comment 7 Dmitry Marakasov 2010-08-31 03:05:23 UTC

State Changed
From-To: feedback->closed

New port added, with minor changes (respect system CFLAGS and 
LOCALBASE). Thanks!

   Bitbucket service has problems with download. I updated MASTER_SITES 
and some details.