Bug 149864

Comment 1 Dmitry Marakasov 2010-08-23 21:32:00 UTC

Responsible Changed
From-To: freebsd-ports-bugs->amdmi3

I'll take it.

* Jesse (jessefrgsmith@yahoo.ca) wrote:

> Imagination is a slideshow maker, which can output slideshows in a variety of formats, including DVD, ogg and Flash video.

Does not build - missing USE_GETTEXT and posssibly more dependencies:

http://people.freebsd.org/~amdmi3/imagination-default-2.1.log

Also, please run ports-mgmt/portlint on the port and try to fix all
errors it reports. Some of these are explained below:

> X# Whom: Jesse

We usually use "Full name <e@mail>" form here.

> XPORTNAME=	imagination
> XPORTVERSION=	2.1
> XCATEGORIES=	multimedia
> XMASTER_SITES=	http://voxel.dl.sourceforge.net/project/${PORTNAME}/${PORTNAME}/${PORTVERSION}/

You can just use SF here - it'll automatically use all SF mirrors.

Also blank line missing here.

> XMAINTAINER=	jessefrgsmith@yahoo.ca
> XCOMMENT=	A DVD slideshow maker.

Period is unneeded.

> XThis is a port of the Imagination DVD slideshow creator. It creates videos from pictures and audio in a number of video formats.

Should be split to shorter lines to fit 80 chars width. Can just run it
through |fmt.

> Xlib/locale/cs/LC_MESSAGES/imagination.mo
> Xlib/locale/de/LC_MESSAGES/imagination.mo
> Xlib/locale/fr/LC_MESSAGES/imagination.mo
> Xlib/locale/en_GB/LC_MESSAGES/imagination.mo
> Xlib/locale/es/LC_MESSAGES/imagination.mo
> Xlib/locale/it/LC_MESSAGES/imagination.mo
> Xlib/locale/ja/LC_MESSAGES/imagination.mo
> Xlib/locale/pt_BR/LC_MESSAGES/imagination.mo
> Xlib/locale/ru/LC_MESSAGES/imagination.mo
> Xlib/locale/sl_SI/LC_MESSAGES/imagination.mo
> Xlib/locale/sv/LC_MESSAGES/imagination.mo

On FreeBSD, NLS files should be installed into share/locale.
You can try USE_GNOME=gnomehack which will patch configure and makefiles
and probably fix this. If it doesn't, you'll have to patch makefiles by
yourself.

> Xshare/doc/imagination/html/en/images/imagination_window.png
> Xshare/doc/imagination/html/en/images/side_panel_video.png
> Xshare/doc/imagination/html/en/images/side_panel_audio.png
> Xshare/doc/imagination/html/en/images/new_dialog.png
> Xshare/doc/imagination/html/en/images/empty_slide_dialog.png
> Xshare/doc/imagination/html/en/images/slide_report_dialog.png
> Xshare/doc/imagination/html/en/index.html
> Xshare/doc/imagination/html/imagination.css

It's a good thing to install documentation optionally (e.g. not install
it when NOPORTDOCS is set). Usually autotools-based apps don't support
this out-of-box, so you will have to use something like

post-patch:
.if defined(NOPORTDOCS)
	@${REINPLACE_CMD} -e '/^SUBDIRS/ s|doc||' ${WRKSRC}/Makefile.in
.endif

thus it won't build/install docs if NOPORTDOCS is set. Plist should be
modified as follows:

share/doc/imagination/foo
changes to
%%PORTDOCS%%%%DOCSDIR%%/html/en/images/imagination_window.png

-or-

you can define PORTDOCS=* in the Makefile and remove all portdocs lines
from the plist - this way it will handle documentation for you.

> Xshare/icons/hicolor/16x16/apps/imagination.png
> Xshare/icons/hicolor/24x24/apps/imagination.png
> Xshare/icons/hicolor/48x48/apps/imagination.png
> Xshare/icons/hicolor/scalable/apps/imagination.svg

You'll have to add @dirrmtry directives for whole share/icons subtree,
e.g.

@dirrmtry share/icons/hicolor/48x48/apps
@dirrmtry share/icons/hicolor/48x48
@dirrmtry share/icons/hicolor/24x24/apps
@dirrmtry share/icons/hicolor/24x24
@dirrmtry share/icons/hicolor/16x16/apps
@dirrmtry share/icons/hicolor/16x16
@dirrmtry share/icons/hicolor
@dirrmtry share/icons

> Xshare/icons/hicolor/icon-theme.cache

Afair, this shouldn't be in pkg-plist, you should use INSTALLS_ICONS=yes
in the Makefile - this will deal with icon cache for you.

> Xshare/imagination/pixmaps/imagination-1.png

share/imagination should be replaced with %%DATADIR%% in all lines.

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru

Comment 3 Dmitry Marakasov 2010-08-24 12:15:51 UTC

State Changed
From-To: open->feedback

Ask for submitter fix.

Comment 4 Martin Wilke 2011-02-13 07:17:14 UTC

State Changed
From-To: feedback->closed

close submitter timeout over months.