Bug 149978

Summary:

[PATCH] Address missing EINVAL requirement for cpu_setaffinity(2)

Product:

Documentation

Reporter:

Enji Cooper <ngie>

Component:

Books & Articles

Assignee:

Glen Barber <gjb>

Status:

Closed FIXED

Severity:

Affects Only Me

Priority:

Normal

Version:

Latest

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
file.diff	none

Description Enji Cooper freebsd_committer

2010-08-26 06:10:05 UTC

The manpage as it stands doesn't note that the syscall can return EINVAL if the mask argument is invalid.

Fix: Patch attached with submission follows:

Comment 1 Glen Barber freebsd_committer

2010-09-06 22:49:40 UTC

Responsible Changed
From-To: freebsd-doc->gjb

I'll take this.

Comment 2 dfilter service freebsd_committer

2010-09-11 00:15:10 UTC

Author: gjb (doc committer)
Date: Fri Sep 10 23:15:05 2010
New Revision: 212438
URL: http://svn.freebsd.org/changeset/base/212438

Log:
  Add EINVAL to list of possible return values for cpuset_getaffinity(2).
  
  PR:		149978
  Submitted by:	gcooper
  Patch by:	gcooper
  Approved by:	keramida (mentor)
  MFC after:	1 week

Modified:
  head/lib/libc/sys/cpuset_getaffinity.2

Modified: head/lib/libc/sys/cpuset_getaffinity.2
==============================================================================
--- head/lib/libc/sys/cpuset_getaffinity.2	Fri Sep 10 21:53:47 2010	(r212437)
+++ head/lib/libc/sys/cpuset_getaffinity.2	Fri Sep 10 23:15:05 2010	(r212438)
@@ -121,6 +121,12 @@ The
 or
 .Fa which
 argument was not a valid value.
+.It Bq Er EINVAL
+The
+.Fa mask
+argument specified when calling
+.Fn cpuset_setaffinity
+was not a valid value.
 .It Bq Er EDEADLK
 The
 .Fn cpuset_setaffinity
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"

Comment 3 Glen Barber freebsd_committer

2010-09-11 00:25:14 UTC

State Changed
From-To: open->patched

Patched in HEAD.  MFC in 1 week.

Comment 4 dfilter service freebsd_committer

2011-02-15 01:34:09 UTC

Author: gjb (doc committer)
Date: Tue Feb 15 01:33:59 2011
New Revision: 218692
URL: http://svn.freebsd.org/changeset/base/218692

Log:
  MFC 212438:
  Add EINVAL to list of possible return values for cpuset_getaffinity(2).
  
  PR:		149978
  Approved by:	keramida (mentor)

Modified:
  stable/8/lib/libc/sys/cpuset_getaffinity.2
Directory Properties:
  stable/8/lib/libc/   (props changed)
  stable/8/lib/libc/stdtime/   (props changed)

Modified: stable/8/lib/libc/sys/cpuset_getaffinity.2
==============================================================================
--- stable/8/lib/libc/sys/cpuset_getaffinity.2	Mon Feb 14 21:50:51 2011	(r218691)
+++ stable/8/lib/libc/sys/cpuset_getaffinity.2	Tue Feb 15 01:33:59 2011	(r218692)
@@ -121,6 +121,12 @@ The
 or
 .Fa which
 argument was not a valid value.
+.It Bq Er EINVAL
+The
+.Fa mask
+argument specified when calling
+.Fn cpuset_setaffinity
+was not a valid value.
 .It Bq Er EDEADLK
 The
 .Fn cpuset_setaffinity
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"

Comment 5 dfilter service freebsd_committer

2011-02-15 01:34:52 UTC

Author: gjb (doc committer)
Date: Tue Feb 15 01:34:46 2011
New Revision: 218693
URL: http://svn.freebsd.org/changeset/base/218693

Log:
  MFC 212438:
  Add EINVAL to list of possible return values for cpuset_getaffinity(2).
  
  PR:		149978
  Approved by:	keramida (mentor)

Modified:
  stable/7/lib/libc/sys/cpuset_getaffinity.2
Directory Properties:
  stable/7/lib/libc/   (props changed)
  stable/7/lib/libc/stdtime/   (props changed)

Modified: stable/7/lib/libc/sys/cpuset_getaffinity.2
==============================================================================
--- stable/7/lib/libc/sys/cpuset_getaffinity.2	Tue Feb 15 01:33:59 2011	(r218692)
+++ stable/7/lib/libc/sys/cpuset_getaffinity.2	Tue Feb 15 01:34:46 2011	(r218693)
@@ -121,6 +121,12 @@ The
 or
 .Fa which
 argument was not a valid value.
+.It Bq Er EINVAL
+The
+.Fa mask
+argument specified when calling
+.Fn cpuset_setaffinity
+was not a valid value.
 .It Bq Er EDEADLK
 The
 .Fn cpuset_setaffinity
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"

Comment 6 Glen Barber freebsd_committer

2011-02-15 01:35:12 UTC

State Changed
From-To: patched->closed

MFC'd to stable/8 and stable/7.  Thanks!