Bug 150309
| Summary: | [PATCH] print/cups-base: cups ports have duplicated UNIQUENAME | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | mwisnicki+freebsd | ||||
| Component: | Individual Port(s) | Assignee: | Dirk Meyer <dinoex> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | dinoex | ||||
| Priority: | Normal | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
|
Description
mwisnicki+freebsd
2010-09-06 00:30:07 UTC
Responsible Changed From-To: freebsd-ports-bugs->dinoex Over to maintainer (via the GNATS Auto Assign Tool) dinoex 2010-09-07 19:35:15 UTC
FreeBSD ports repository
Modified files:
print/cups-base Makefile
Log:
- fix options by forcing UNIQUENAME
PR: 150309
Submitted by: Marcin Wisnicki
Revision Changes Path
1.144 +2 -1 ports/print/cups-base/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed committedw ith modifications, thanks. This breaks OPTIONS in print/cups-client on my box, unselecting GNUTLS no longer works. I think it affects other slave ports as well. $ cd print/cups-client $ make config (unselect GNUTLS) $ make -V WITHOUT_GNUTLS $ make -V WITH_GNUTLS true $ make package-depends gnutls-2.8.6_2:security/gnutls libgcrypt-1.4.6:security/libgcrypt libgpg-error-1.8:security/libgpg-error lzo2-2.03_2:archivers/lzo2 libiconv-1.13.1_1:converters/libiconv pkg-config-0.25_1:devel/pkg-config dinoex 2010-09-25 15:08:26 UTC
FreeBSD ports repository
Modified files:
print/cups-base Makefile
Log:
- revert patch
PR: 150309
Revision Changes Path
1.145 +0 -1 ports/print/cups-base/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Please:
1. Always reopen bug when reverting patch and notify submitter.
2. Always test it locally.
[yesterday's ports, before patch was reverted]:
$ cd /usr/ports/print/cups-client/
$ make rmconfig
$ make config # unselect GNUTLS
$ make showconfig
===> The following configuration options are available for cups-client-1.4.4:
GNUTLS=off "Build with GNUTLS library"
===> Use 'make config' to modify these settings
$ make -V WITHOUT_GNUTLS
true
$ make -V WITH_GNUTLS
$
Thanks.
State Changed From-To: closed->analyzed - no solution found Marcin Wisnicki schrieb:, > Please: > 1. Always reopen bug when reverting patch and notify submitter. This is not possible without ssh accesss. So the reopen had to be delayed. > 2. Always test it locally. > > [yesterday's ports, before patch was reverted]: > > $ cd /usr/ports/print/cups-client/ > $ make rmconfig > $ make config # unselect GNUTLS > $ make showconfig > ===> The following configuration options are available for cups-client-1.4.4: > GNUTLS=off "Build with GNUTLS library" > ===> Use 'make config' to modify these settings > $ make -V WITHOUT_GNUTLS > true > > $ make -V WITH_GNUTLS > > $ Options did us the wrong file, I could reproduce the problem with a clean /var/db/ports before reverting. kind regards Dirk - Dirk Meyer, Im Grund 4, 34317 Habichtswald, Germany - [dirk.meyer@dinoex.sub.org],[dirk.meyer@guug.de],[dinoex@FreeBSD.org] I cannot reproduce your problem with my patch: $ cd /usr/ports $ rm -rf print/cups* $ make update $ make __MAKE_CONF=/dev/null PORT_DBDIR=/var/empty -C print/cups-base -V OPTIONSFILE /var/empty/cups/options $ make __MAKE_CONF=/dev/null PORT_DBDIR=/var/empty -C print/cups-client -V OPTIONSFILE /var/empty/cups/options $ fetch -o- "http://www.freebsd.org/cgi/query-pr.cgi?prp=150309-1-txt&n=/cups-base-1.4.4.patch" | patch -p3 $ make __MAKE_CONF=/dev/null PORT_DBDIR=/var/empty -C print/cups-base -V OPTIONSFILE /var/empty/cups-base/options $ make __MAKE_CONF=/dev/null PORT_DBDIR=/var/empty -C print/cups-client -V OPTIONSFILE /var/empty/cups-client/options Expected OPTIONSFILE location in both cases. Also it works (config/showconfig/all): $ make __MAKE_CONF=/dev/null PORT_DBDIR=/tmp/portsdb -C print/cups-client showconfig ===> The following configuration options are available for cups-client-1.4.4: GNUTLS=on (default) "Build with GNUTLS library" ===> Use 'make config' to modify these settings $ make __MAKE_CONF=/dev/null PORT_DBDIR=/tmp/portsdb -C print/cups-client config # deselect GNUTLS $ make __MAKE_CONF=/dev/null PORT_DBDIR=/tmp/portsdb -C print/cups-client showconfig ===> The following configuration options are available for cups-client-1.4.4: GNUTLS=off "Build with GNUTLS library" ===> Use 'make config' to modify these settings $ cat /tmp/portsdb/cups-client/options # This file is auto-generated by 'make config'. # No user-servicable parts inside! # Options for cups-client-1.4.4 _OPTIONS_READ=cups-client-1.4.4 WITHOUT_GNUTLS=true Again, everything is as expected. dinoex 2010-11-15 06:30:40 UTC
FreeBSD ports repository
Modified files:
print/cups-base Makefile
Log:
- fix options by forcing UNIQUENAME
PR: 150309
Submitted by: Marcin Wisnicki
Revision Changes Path
1.146 +10 -3 ports/print/cups-base/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: analyzed->patched Please test again. I think I have resolved all issues with the Options. On Mon, Nov 15, 2010 at 09:27, <dinoex@freebsd.org> wrote: > Synopsis: [PATCH] print/cups-base: cups ports have duplicated UNIQUENAME > > State-Changed-From-To: analyzed->patched > State-Changed-By: dinoex > State-Changed-When: Mon Nov 15 09:26:48 CET 2010 > State-Changed-Why: > > Please test again. > I think I have resolved all issues with the Options. > Seems to be working. Thanks! > > http://www.freebsd.org/cgi/query-pr.cgi?pr=150309 > State Changed From-To: patched->closed Thanks |
