Bug 150327

Summary: [PATCH] www/xpi-adblock: do not install XPI metadata
Product: Ports & Packages Reporter: Lapo Luchini <lapo>
Component: Individual Port(s)Assignee: Philip M. Gollucci <pgollucci>
Status: Closed FIXED    
Severity: Affects Only Me CC: lapo
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
xpi-adblock-0.5.3.043.patch none

Description Lapo Luchini 2010-09-06 14:40:07 UTC 
Avoid installing an XPI's META-INF directory, as it contain meta-data and not actual data needed by the extension.

All of the XPIs I've seen having this directory use it to store digital signature data, which is checked on install (and thus has no need to be there for a system package); I don't know about any other data that is expected to fit in that directory, but by the very nature of it, it should all be meta-data relative to the XPI itself, not about the actual extension to be installed.

Some ports that are (IMvHO unnecessarily) installing that directory include:
www/xpi-adblock_plus
www/xpi-flashgot
www/xpi-joga
www/xpi-noscript
www/xpi-pdf_download
(all maintained by either ale@ or miwi@).

I propose to avoid installing that directory directly from Makefile.xpi, using the following patch or something similar.

Port maintainer (miwi@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-09-06 14:40:23 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->miwi

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Philip M. Gollucci freebsd_committer freebsd_triage 2010-09-07 18:38:31 UTC 
Responsible Changed
From-To: miwi->pgollucci

I will take it
Comment 3 dfilter service freebsd_committer freebsd_triage 2010-09-08 01:44:57 UTC 
pgollucci    2010-09-08 00:44:49 UTC

  FreeBSD ports repository

  Modified files:
    www/xpi-adblock      Makefile.xpi 
  Log:
  - Fix XPI_ID generation when the tag might spam multiple lines [1]
  - Do not install meta data (META-INF) since its not needed
    allow for xpi-post-extract to still work in xpi-* ports [2]
  
  PR:             ports/126876 [1], ports/150327 [2]
  Submitted by:   Lapo Luchini <lapo@lapo.it> [1], [2] tweaked by me
  Approved by:    maintainer timeout (miwi; ~1 yr) [1] [2]
  Tested by:      P6 TB Run, RideCharge TB Run
  
  Revision  Changes    Path
  1.24      +11 -3     ports/www/xpi-adblock/Makefile.xpi
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Philip M. Gollucci freebsd_committer freebsd_triage 2010-09-08 01:45:03 UTC 
State Changed
From-To: open->closed

Committed, Thanks!
Comment 5 dfilter service freebsd_committer freebsd_triage 2010-09-08 01:55:24 UTC 
pgollucci    2010-09-08 00:55:10 UTC

  FreeBSD ports repository

  Modified files:
    www/xpi-adblock_plus Makefile 
    www/xpi-downthemall  Makefile 
    www/xpi-flashgot     Makefile 
    www/xpi-foxmarks     Makefile pkg-plist 
    www/xpi-foxyproxy    Makefile 
    www/xpi-google-notebook Makefile pkg-plist 
    www/xpi-gwt-dev-plugin Makefile 
    www/xpi-joga         Makefile 
    www/xpi-jsview       Makefile 
    www/xpi-mousegestures Makefile 
    www/xpi-noscript     Makefile 
    www/xpi-pdf_download Makefile 
    www/xpi-statusbarclock Makefile 
    www/xpi-togglewordwrap Makefile pkg-plist 
    www/xpi-unplug       Makefile 
  Log:
  - Account for ports/150327
    Do not install meta data (META-INF) since its not needed
    allow for xpi-post-extract to still work in xpi-* ports
  
     o fix pkg-plist
     o fix XPI_DIRS, XPI_FILES
     o Bump PORTREVISION
     o s/post-extract/xpi-post-extract/
  
  PR:             ports/150327
  Submitted by:   Lapo Luchini <lapo@lapo.it>, tweaked by myself
  Approved by:    maintainer timeout (miwi)
  Tested by:      P6 TB Run, RideCharge Inc. / Taximagic TB Run
  
  Revision  Changes    Path
  1.18      +3 -3      ports/www/xpi-adblock_plus/Makefile
  1.27      +1 -1      ports/www/xpi-downthemall/Makefile
  1.31      +3 -3      ports/www/xpi-flashgot/Makefile
  1.17      +1 -0      ports/www/xpi-foxmarks/Makefile
  1.12      +0 -4      ports/www/xpi-foxmarks/pkg-plist
  1.15      +1 -1      ports/www/xpi-foxyproxy/Makefile
  1.8       +1 -0      ports/www/xpi-google-notebook/Makefile
  1.2       +0 -4      ports/www/xpi-google-notebook/pkg-plist
  1.6       +1 -1      ports/www/xpi-gwt-dev-plugin/Makefile
  1.12      +3 -3      ports/www/xpi-joga/Makefile
  1.13      +1 -1      ports/www/xpi-jsview/Makefile
  1.6       +1 -1      ports/www/xpi-mousegestures/Makefile
  1.57      +3 -2      ports/www/xpi-noscript/Makefile
  1.25      +3 -3      ports/www/xpi-pdf_download/Makefile
  1.4       +1 -1      ports/www/xpi-statusbarclock/Makefile
  1.10      +1 -0      ports/www/xpi-togglewordwrap/Makefile
  1.3       +0 -4      ports/www/xpi-togglewordwrap/pkg-plist
  1.19      +2 -2      ports/www/xpi-unplug/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"