Summary: | Ports games/openastromenace won't compile on 64 bit | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | rnejdl | ||||
Component: | Individual Port(s) | Assignee: | Stephen Montgomery-Smith <stephen> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | ||||||
Priority: | Normal | ||||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
rnejdl
2010-09-23 14:50:01 UTC
Maintainer of games/openastromenace, Please note that PR ports/150883 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/150883 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool) Hello Rusty, I can not reproduce your problem. Also portsmon does not list the port with build-failure. Possible reasons for the failures: - Are your installed ports updated to the latest version? - Did you deinstall the old version before installing the new version? regards arved This one is consistently bombing out with OPENGL errors: /usr/ports/games/openastromenace/work/OpenAstroMenaceSVN/AstroMenaceSource/Core/RendererInterface/OGL_Main.cpp:66: error: 'PFNGLCLIENTACTIVETEXTUREPROC' does not name a type /usr/ports/games/openastromenace/work/OpenAstroMenaceSVN/AstroMenaceSource/Core/RendererInterface/OGL_Main.cpp: In function 'int vw_InitRenderer(char*, int, int, int*, bool, int*)': /usr/ports/games/openastromenace/work/OpenAstroMenaceSVN/AstroMenaceSource/Core/RendererInterface/OGL_Main.cpp:359: error: 'glClientActiveTexture13' was not declared in this scope /usr/ports/games/openastromenace/work/OpenAstroMenaceSVN/AstroMenaceSource/Core/RendererInterface/OGL_Main.cpp:359: error: 'PFNGLCLIENTACTIVETEXTUREPROC' was not declared in this scope /usr/ports/games/openastromenace/work/OpenAstroMenaceSVN/AstroMenaceSource/Core/RendererInterface/OGL_Main.cpp:359: error: expected `;' before 'SDL_GL_GetProcAddress' I have the NVIDIA driver installed and wonder if that is why this fails for me but not in the test harness. Rusty Nejdl State Changed From-To: feedback->open Maintainer feedback timeout. This seems to be caused by the nvidia-driver Can you try below diff? It should also fix build with gcc45. --- a.diff begins here --- Index: games/openastromenace/Makefile =================================================================== RCS file: /a/.cvsup/ports/games/openastromenace/Makefile,v retrieving revision 1.10 diff -u -p -r1.10 Makefile --- games/openastromenace/Makefile 6 Jun 2010 20:43:48 -0000 1.10 +++ games/openastromenace/Makefile 19 Jan 2011 21:24:51 -0000 @@ -7,7 +7,7 @@ PORTNAME= openastromenace PORTVERSION= 1.2.0 -PORTREVISION= 9 +PORTREVISION= 10 CATEGORIES= games MASTER_SITES= SF DISTFILES= openamenace-src-${PORTVERSION}${EXTRACT_SUFX} \ @@ -44,6 +44,10 @@ LANGPACK= ru IGNORE= cannot be build without/with multiple language packs. Please rerun 'make config' and select single language pack .endif +.if !defined(WITHOUT_NOUVEAU) +CFLAGS+= -DOLD_MESA +.endif + post-patch: ${REINPLACE_CMD} -e 's|/usr/local/share/openastromenace|${DATADIR}|' \ ${WRKSRC}/AstroMenaceSource/Main.cpp Index: games/openastromenace/files/patch-AstroMenaceSource-Core-Base.h =================================================================== RCS file: games/openastromenace/files/patch-AstroMenaceSource-Core-Base.h diff -N games/openastromenace/files/patch-AstroMenaceSource-Core-Base.h --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ games/openastromenace/files/patch-AstroMenaceSource-Core-Base.h 19 Jan 2011 21:19:09 -0000 @@ -0,0 +1,17 @@ +--- AstroMenaceSource/Core/Base.h~ ++++ AstroMenaceSource/Core/Base.h +@@ -46,10 +46,14 @@ + #include <OpenGL/gl.h> // Header File For The OpenGL32 Library + #include <OpenGL/glu.h> // Header File For The GLu32 Library + #else ++ #ifdef OLD_MESA + #define __glext_h_ // Don't let gl.h include glext.h ++ #endif + #include <GL/gl.h> // Header File For The OpenGL32 Library + #include <GL/glu.h> // Header File For The GLu32 Library ++ #ifdef OLD_MESA + #undef __glext_h_ ++ #endif + #endif + + #include <stdlib.h> // rand, ... Index: games/openastromenace/files/patch-AstroMenaceSource-Core-VirtualFileSystem-VFS.h =================================================================== RCS file: games/openastromenace/files/patch-AstroMenaceSource-Core-VirtualFileSystem-VFS.h diff -N games/openastromenace/files/patch-AstroMenaceSource-Core-VirtualFileSystem-VFS.h --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ games/openastromenace/files/patch-AstroMenaceSource-Core-VirtualFileSystem-VFS.h 19 Jan 2011 21:23:21 -0000 @@ -0,0 +1,10 @@ +--- AstroMenaceSource/Core/VirtualFileSystem/VFS.h~ ++++ AstroMenaceSource/Core/VirtualFileSystem/VFS.h +@@ -34,6 +34,7 @@ + #define VFS_H + + ++#include <cstdio> + #include "../Base.h" + + --- a.diff ends here --- [tethys]:/usr/ports/games/openastromenace>[tethys]:/usr/ports> sudo patch -p0 < ~/astromenace.diff Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |Index: games/openastromenace/Makefile |=================================================================== |RCS file: /a/.cvsup/ports/games/openastromenace/Makefile,v |retrieving revision 1.10 |diff -u -p -r1.10 Makefile |--- games/openastromenace/Makefile 6 Jun 2010 20:43:48 -0000 1.10 |+++ games/openastromenace/Makefile 19 Jan 2011 21:24:51 -0000 -------------------------- Patching file games/openastromenace/Makefile using Plan A... Hunk #1 succeeded at 7. Hunk #2 succeeded at 44. Hmm... The next patch looks like a unified diff to me...The text leading up to this was: -------------------------- |Index: games/openastromenace/files/patch-AstroMenaceSource-Core-Base.h |=================================================================== |RCS file: games/openastromenace/files/patch-AstroMenaceSource-Core-Base.h |diff -N games/openastromenace/files/patch-AstroMenaceSource-Core-Base.h |--- /dev/null 1 Jan 1970 00:00:00 -0000 |+++ games/openastromenace/files/patch-AstroMenaceSource-Core-Base.h 19 Jan 2011 21:19:09 -0000 -------------------------- (Creating file games/openastromenace/files/patch-AstroMenaceSource-Core-Base.h...) Patching file games/openastromenace/files/patch-AstroMenaceSource-Core-Base.h using Plan A... Hunk #1 succeeded at 1. Hmm... The next patch looks like a unified diff to me...The text leading up to this was: -------------------------- |Index: games/openastromenace/files/patch-AstroMenaceSource-Core-VirtualFileSystem-VFS.h |=================================================================== |RCS file: games/openastromenace/files/patch-AstroMenaceSource-Core-VirtualFileSystem-VFS.h |diff -N games/openastromenace/files/patch-AstroMenaceSource-Core-VirtualFileSystem-VFS.h |--- /dev/null 1 Jan 1970 00:00:00 -0000 |+++ games/openastromenace/files/patch-AstroMenaceSource-Core-VirtualFileSystem-VFS.h 19 Jan 2011 21:23:21 -0000 -------------------------- (Creating file games/openastromenace/files/patch-AstroMenaceSource-Core-VirtualFileSystem-VFS.h...) Patching file games/openastromenace/files/patch-AstroMenaceSource-Core-VirtualFileSystem-VFS.h using Plan A... Hunk #1 succeeded at 1.done [tethys]:/usr/ports> sudo make patch ===> Vulnerability check disabled, database not found===> License check disabled, port has not defined LICENSE ===> Found saved configuration for openastromenace-1.2.0_6 ===> Extracting for openastromenace-1.2.0_10 => SHA256 Checksum OK for openamenace-src-1.2.0.tar.bz2. => SHA256 Checksum OK for oamenace-data-1.2.0.tar.bz2. => SHA256 Checksum OK for oamenace-lang-en-1.2.0.tar.bz2. ===> Patching for openastromenace-1.2.0_10 ===> Applying FreeBSD patches for openastromenace-1.2.0_10 1 out of 1 hunks failed--saving rejects to AstroMenaceSource/Core/Base.h.rej=> Patch patch-AstroMenaceSource-Core-Base.h failed to apply cleanly. *** Error code 1 Stop in /usr/ports/games/openastromenace. *** Error code 1 Stop in /usr/ports/games/openastromenace. Exit 1 Rusty Nejdl My MUA removed non-printable characters (^M). Can't you apply it by hand? Good afternoon, Do you know what the status of committing this PR now that the ports freeze has lifted? Rusty Nejdl Links: ------ [1] mailto:rnejdl@ringofsaturn.com Please let me know the status of this PR. The solution is contained in the PR and just needs to be committed I believe. Rusty Nejdl On Wed, Apr 27, 2011 at 05:50:23PM +0000, Rusty Nejdl wrote:
> Please let me know the status of this PR.
I've Cc:ed the maintainer, who has been active in the past month, but at
this point IMHO maintainer-timeout should apply and any committer would
thus be able to commit after testing.
mcl
sorry for timeout. commit it please, if patch does work This patch solves the issue I reported and there have been no changes=20 to the port since this so the patch should apply cleanly. If possible,=20 please commit. I can submit another PR if I find anything else amiss. Rusty Nejdl Responsible Changed From-To: freebsd-ports-bugs->stephen I'll take this. State Changed From-To: open->feedback I cannot reproduce the problem. I want to ask the submitter about this. I am trying to reproduce the problem, but I cannot. Is it possible that something changed in the ports since you filed this PR, so that the problem fixed itself? Email me back - I'm willing to work with you until this gets this resolved. On Fri, 01 Jul 2011 00:39:36 -0500, Stephen Montgomery-Smith wrote: > I am trying to reproduce the problem, but I cannot. Is it possible > that something changed in the ports since you filed this PR, so that > the problem fixed itself? > > Email me back - I'm willing to work with you until this gets this > resolved. I am able to reproduce without issue: [ 16%] Building CXX object CMakeFiles/AstroMenace.dir/AstroMenaceSource/Core/System/System.o [ 17%] Building CXX object CMakeFiles/AstroMenace.dir/AstroMenaceSource/Core/CollisionDetection/CommonMath.o [ 17%] Building CXX object CMakeFiles/AstroMenace.dir/AstroMenaceSource/Core/CollisionDetection/AABB.o [ 18%] Building CXX object CMakeFiles/AstroMenace.dir/AstroMenaceSource/Core/CollisionDetection/OBB.o [ 19%] Building CXX object CMakeFiles/AstroMenace.dir/AstroMenaceSource/Core/CollisionDetection/Sphere.o [ 20%] Building CXX object CMakeFiles/AstroMenace.dir/AstroMenaceSource/Core/RendererInterface/OGL_VBO.o [ 20%] Building CXX object CMakeFiles/AstroMenace.dir/AstroMenaceSource/Core/RendererInterface/OGL_OcclusionQuery.o [ 21%] Building CXX object CMakeFiles/AstroMenace.dir/AstroMenaceSource/Core/RendererInterface/OGL_Texture.o [ 22%] Building CXX object CMakeFiles/AstroMenace.dir/AstroMenaceSource/Core/RendererInterface/OGL_GLSL.o [ 23%] Building CXX object CMakeFiles/AstroMenace.dir/AstroMenaceSource/Core/RendererInterface/OGL_Main.o /usr/ports/games/openastromenace/work/OpenAstroMenaceSVN/AstroMenaceSource/Core/RendererInterface/OGL_Main.cpp:66: error: 'PFNGLCLIENTACTIVETEXTUREPROC' does not name a type /usr/ports/games/openastromenace/work/OpenAstroMenaceSVN/AstroMenaceSource/Core/RendererInterface/OGL_Main.cpp: In function 'int vw_InitRenderer(char*, int, int, int*, bool, int*)': /usr/ports/games/openastromenace/work/OpenAstroMenaceSVN/AstroMenaceSource/Core/RendererInterface/OGL_Main.cpp:359: error: 'glClientActiveTexture13' was not declared in this scope /usr/ports/games/openastromenace/work/OpenAstroMenaceSVN/AstroMenaceSource/Core/RendererInterface/OGL_Main.cpp:359: error: 'PFNGLCLIENTACTIVETEXTUREPROC' was not declared in this scope /usr/ports/games/openastromenace/work/OpenAstroMenaceSVN/AstroMenaceSource/Core/RendererInterface/OGL_Main.cpp:359: error: expected `;' before 'SDL_GL_GetProcAddress' *** Error code 1 Stop in /usr/ports/games/openastromenace/work/OpenAstroMenaceSVN. *** Error code 1 Stop in /usr/ports/games/openastromenace/work/OpenAstroMenaceSVN. *** Error code 1 Stop in /usr/ports/games/openastromenace/work/OpenAstroMenaceSVN. *** Error code 1 Stop in /usr/ports/games/openastromenace. *** Error code 1 Stop in /usr/ports/games/openastromenace. Exit 1 [tethys]:/usr/ports/games/openastromenace> I believe someone submitted a patch to fix this and it is still pending commit. Rusty Nejdl Can you send me the output of pkg_info so I can try to reproduce the fault? When I can reproduce the fault, I'll commit the PR. For the record: To reproduce this problem, set WITHOUT_NOUVEAU=yes in /etc/make.conf, and then rebuild the graphics/libGL and graphics/libGLU ports. (See graphics/libGL/bsd.mesalib.mk for more information.) State Changed From-To: feedback->closed Committed, thanks! A portrevision bump was not necessary. stephen 2011-07-03 18:40:21 UTC FreeBSD ports repository Modified files: games/openastromenace Makefile Added files: games/openastromenace/files patch-AstroMenaceSource-Core-Base.h patch-AstroMenaceSource-Core-VirtualFileSystem-VFS.h Log: - Fix build errors when MAKE_NOUVEAU set in /etc/make.conf PR: ports/150883 Submitted by: Rusty Nejdl <rnejdl@ringofsaturn.com> and swell.k@gmail.com Approved by: gabor (mentor) and proler@gmail.com (maintainer) Revision Changes Path 1.11 +5 -0 ports/games/openastromenace/Makefile 1.1 +17 -0 ports/games/openastromenace/files/patch-AstroMenaceSource-Core-Base.h (new) 1.1 +10 -0 ports/games/openastromenace/files/patch-AstroMenaceSource-Core-VirtualFileSystem-VFS.h (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org" |