Bug 151270
| Summary: | [PATCH] multimedia/xfce4-parole: explicitly disable browser plugin | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Jilles Tjoelker <jilles> | ||||
| Component: | Individual Port(s) | Assignee: | Martin Wilke <miwi> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | ||||||
| Priority: | Normal | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Responsible Changed From-To: freebsd-ports-bugs->miwi Over to maintainer (via the GNATS Auto Assign Tool) johans 2010-10-24 18:18:51 UTC
FreeBSD ports repository
Modified files:
multimedia/xfce4-parole Makefile
Log:
Explicitly disable browser plugin option.
No functional change, as this option is disabled already. But planned
changes to sh(1) on current might break this implicit behaviour.
PR: ports/151270
Submitted by: jilles
Approved by: maintainer timeout (miwi, >14 days)
Revision Changes Path
1.8 +1 -1 ports/multimedia/xfce4-parole/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed after maintainer timeout. |
The upstream configure script contains broken code in the detection for the browser plugin: BROWSER_PLUGIN_DIR="${BROWSER_PLUGIN_DIR:-"\${libdir}/mozilla/plugins"}" POSIX does not require this to work and many shells such as the current FreeBSD /bin/sh as of the time of writing silently assign an incorrect value. (Some shells such as dash even flag a syntax error.) I plan to change our sh to do what is expected by the author (assign the literal string ${libdir}/mozilla/plugins if BROWSER_PLUGIN_DIR is not set yet). This is both because bash and ksh93 do the same thing and because it is otherwise much harder to make splitting WORD in ${VAR+WORD} work in a consistent manner (the change enforces that each substitution ends with the same double-quote state as it started). This change, however, causes the browser plugin to be built, which subsequently causes a pointyhat failure because the browser plugin's files are not in the plist. To fix this, I suggest explicitly disabling the browser plugin via --disable-browser-plugin. Upstream has removed the browser plugin entirely in their 0.2.2 branch, although there is no release yet with this change. I would like to commit the sh changes before that release. Fix: Apply this patch. How-To-Repeat: Build/install the port with patched sh. The patch (to head r212508) is available at http://www.stack.nl/~jilles/unix/sh-expand-parser-20100919.patch until I commit it to 9-CURRENT.