Bug 151519

Summary: New port: math/libtsnnls Fast Sparse Nonnegative Least Squares Solver
Product: Ports & Packages Reporter: tzhuan
Component: Individual Port(s)Assignee: Wen Heping <wen>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.shar
none
libtsnnls.shar none

Description tzhuan 2010-10-17 20:00:16 UTC 
libtsnnls is a fast solver for least-squares problems in the
form Ax = b under the constraint that all entries in the
solution vector x are non-negative.

Fix: Patch attached with submission follows:
Comment 1 Wen Heping freebsd_committer freebsd_triage 2010-10-18 02:20:14 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->wen

I'll take it.
Comment 2 wenheping 2010-10-19 07:31:28 UTC 
Hi,

   The ports could be built well, but i have some suggestions:
   1) use "portlint -AC" to check your new port after you create it,
try to fix all the warnings and make portlint happy :)

   2) Since your plist files is more than 5 , I suggest you use pkg-plist
instead of PLIST_FILES.

   3)  use TAB after every = .

   4) would you re-write the options with visit:
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-options.html


Regards,
wen
Comment 3 tzhuan 2010-10-19 09:19:52 UTC 
Hi,

On Tue, Oct 19, 2010 at 14:31, wen heping <wenheping@gmail.com> wrote:
> Hi,
>
>   The ports could be built well, but i have some suggestions:
>   1) use "portlint -AC" to check your new port after you create it,
> try to fix all the warnings and make portlint happy :)


Done. There is only one warning (only one MASTER_SITE configured) left.

>   2) Since your plist files is more than 5 , I suggest you use pkg-plist
> instead of PLIST_FILES.


The porter's handbook says

``At the same time, it has the advantage of reducing the number of files in the
ports collection. Please consider using this technique before you
resort to pkg-plist.''

thus I decide to use PLIST_FILES because there is no fancy requirement
for this port.
Anyway, it uses pkg-plist now.

>   3)  use TAB after every = .


Done.

>   4) would you re-write the options with visit:
> http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-options.html


Sorry, I don't get your point.

Thanks,
Tz-Huan
Comment 4 dfilter service freebsd_committer freebsd_triage 2010-10-19 12:01:01 UTC 
wen         2010-10-19 11:00:55 UTC

  FreeBSD ports repository

  Modified files:
    math                 Makefile 
  Added files:
    math/libtsnnls       Makefile distinfo pkg-descr pkg-plist 
  Log:
  libtsnnls is a fast solver for least-squares problems in the
  form Ax = b under the constraint that all entries in the
  solution vector x are non-negative.
  
  WWW: http://www.jasoncantarella.com/webpage/index.php?title=Tsnnls
  
  PR:             ports/151519
  Submitted by:   Tz-Huan Huang <tzhuan@gmail.com>
  
  Revision  Changes    Path
  1.675     +1 -0      ports/math/Makefile
  1.1       +57 -0     ports/math/libtsnnls/Makefile (new)
  1.1       +3 -0      ports/math/libtsnnls/distinfo (new)
  1.1       +5 -0      ports/math/libtsnnls/pkg-descr (new)
  1.1       +14 -0     ports/math/libtsnnls/pkg-plist (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Wen Heping freebsd_committer freebsd_triage 2010-10-19 13:05:20 UTC 
State Changed
From-To: open->closed

New port added. Thanks!