Bug 152272

Summary: textproc/clucene-contrib fails to patch
Product: Ports & Packages Reporter: Paul Mather <paul>
Component: Individual Port(s)Assignee: Josh Paetzel <jpaetzel>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Paul Mather 2010-11-15 20:50:10 UTC 
Port textproc/clucene-contrib fails to build at the patch stage because of an absolute pathname in the patch-src_CLucene_analysis_cjk_CJKAnalyzer.cpp patch file:

developer# make
===>  License check disabled, port has not defined LICENSE
===>  Extracting for clucene-contrib-0.9.16a
=> SHA256 Checksum OK for clucene-contrib-0.9.16a.tar.bz2.
===>  Patching for clucene-contrib-0.9.16a
===>   Converting DOS text files to UNIX text files
===>  Applying FreeBSD patches for clucene-contrib-0.9.16a
File to patch: 
No file found--skip this patch? [n] y
2 out of 2 hunks ignored--saving rejects to /work/a/ports/textproc/clucene-contrib/work/clucene-contrib-0.9.16a/src/CLucene/analysis/cjk/CJKAnalyzer.cpp.rej
Can't create /work/a/ports/textproc/clucene-contrib/work/clucene-contrib-0.9.16a/src/CLucene/analysis/cjk/CJKAnalyzer.cpp.rej, output is in /tmp//patchr6TIXJM: No such file or directory
=> Patch patch-src_CLucene_analysis_cjk_CJKAnalyzer.cpp failed to apply cleanly.
=> Patch(es) patch-Makefile.in patch-src_CLucene_analysis_Makefile.am applied cleanly.
*** Error code 1

Stop in /usr/ports/textproc/clucene-contrib.
developer#

Fix: The problem is that the patch-src_CLucene_analysis_cjk_CJKAnalyzer.cpp patch is badly formed.  Here is a diff to correct the patch:

How-To-Repeat: cd /usr/ports/textproc/clucene-contrib
make
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-11-15 20:50:31 UTC 
Maintainer of textproc/clucene-contrib,

Please note that PR ports/152272 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/152272

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2010-11-15 20:50:34 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Tom Judge 2010-11-15 21:25:25 UTC 
Hi Paul,

This seems like the correct fix.

I seem to have re-generated this patch file while in tinderbox using
full paths when I converted the patches from Dos line endings to Unix ones.

Test run with your patch:
http://tinderbox.tomjudge.com/tb/logs/8.1-amd64/clucene-contrib-0.9.16a.log

Thanks for the report.

Tom

-- 
TJU13-ARIN
Comment 4 Josh Paetzel freebsd_committer freebsd_triage 2010-11-15 23:42:28 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->jpaetzel

I'll take it
Comment 5 dfilter service freebsd_committer freebsd_triage 2010-11-15 23:52:21 UTC 
jpaetzel    2010-11-15 23:52:16 UTC

  FreeBSD ports repository

  Modified files:
    textproc/clucene-contrib/files 
                                   patch-src_CLucene_analysis_cjk_CJKAnalyzer.cpp 
  Log:
  Fix issue with patch not applying
  
  PR:     ports/152272
  Submitted by:   Paul Mather <paul@gromit.dlib.vt.edu>
  Approved by:    Tom Judge <tom@tomjudge.com> (maintainer)
  
  Revision  Changes    Path
  1.2       +2 -2      ports/textproc/clucene-contrib/files/patch-src_CLucene_analysis_cjk_CJKAnalyzer.cpp
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Josh Paetzel freebsd_committer freebsd_triage 2010-11-15 23:52:34 UTC 
State Changed
From-To: feedback->closed

Committed, thanks!