Bug 152387

Summary: shells/bash-completion: portinstall with bash completion throws errors
Product: Ports & Packages Reporter: Martin Glaß <glaszig>
Component: Individual Port(s)Assignee: Adam Weinberger <adamw>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Martin Glaß 2010-11-18 22:10:08 UTC 
i have installed the bash-completion port.
it ships support for port name completion when using portinstall/portupgrade.
when using portinstall, bash complains:

-bash: portsdir: command not found
-bash: /INDEX-.: No such file or directory
-bash: /INDEX-.: No such file or directory

so i dug into /usr/local/etc/bash_completion.d/portupgrade
and found some typo on line 26 of that file (wrong variable and string offset).

Fix: i have attached a patch.

Patch attached with submission follows:
How-To-Repeat: install bash-completion_1.2_1,1
source the bash_completion script
try using portinstall
Comment 1 Steve Price freebsd_committer freebsd_triage 2011-01-03 17:26:32 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->ruby

Over to maintainer(s).
Comment 2 Tilman Keskinoz freebsd_committer freebsd_triage 2011-07-25 11:21:12 UTC 
Responsible Changed
From-To: ruby->adamw

this PR is actually about bash-completion. 

Over to adamw as maintainer of bash-completion
Comment 3 dfilter service freebsd_committer freebsd_triage 2011-08-01 23:03:49 UTC 
adamw       2011-08-01 22:03:35 UTC

  FreeBSD ports repository

  Modified files:
    shells/bash-completion Makefile 
    shells/bash-completion/files patch-contrib_portupgrade 
  Log:
  Fix completions for portinstall, an indexing error.
  
  PR:             ports/152387
  Submitted by:   Martin GlaC <glaszig@gmail.com>
  
  Revision  Changes    Path
  1.25      +1 -0      ports/shells/bash-completion/Makefile
  1.3       +1 -1      ports/shells/bash-completion/files/patch-contrib_portupgrade
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Adam Weinberger freebsd_committer freebsd_triage 2011-08-01 23:03:51 UTC 
State Changed
From-To: open->closed

Aack! I don't know how I missed this PR for so long... 

I've committed this patch. May your future port installations 
be merry and tab-completable.