Bug 152412

Summary: [patch] compiling multimedia/vlc-1.1.5,3 fails on FreeBSD 7.3
Product: Ports & Packages Reporter: Martin Birgmeier <Martin.Birgmeier>
Component: Individual Port(s)Assignee: Joseph S. Atkinson <jsa>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
extra-patch-modules__misc__inhibit__xscreensaver.c none

Description Martin Birgmeier 2010-11-19 20:40:07 UTC 
Compiling the latest version of vlc (vlc-1.1.5,3) on FreeBSD 7.3 fails with the following error messages:

..
  CC     libinhibit_plugin_la-inhibit.lo
  CC     libxdg_screensaver_plugin_la-xdg.lo
inhibit/xdg.c: In function 'Thread':
inhibit/xdg.c:119: warning: unused variable 'argv'
  CC     libxscreensaver_plugin_la-xscreensaver.lo
inhibit/xscreensaver.c:55: error: expected specifier-qualifier-list before 'posix_spawn_file_actions_t'
inhibit/xscreensaver.c: In function 'Activate':
inhibit/xscreensaver.c:91: error: implicit declaration of function 'posix_spawn_file_actions_init'
inhibit/xscreensaver.c:91: error: 'vlc_inhibit_sys_t' has no member named 'actions'
inhibit/xscreensaver.c:94: error: implicit declaration of function 'posix_spawn_file_actions_adddup2'
inhibit/xscreensaver.c:94: error: 'vlc_inhibit_sys_t' has no member named 'actions'
inhibit/xscreensaver.c:95: error: 'vlc_inhibit_sys_t' has no member named 'actions'
inhibit/xscreensaver.c:96: error: implicit declaration of function 'posix_spawn_file_actions_addclose'
inhibit/xscreensaver.c:96: error: 'vlc_inhibit_sys_t' has no member named 'actions'
inhibit/xscreensaver.c:98: error: 'vlc_inhibit_sys_t' has no member named 'nullfd'
inhibit/xscreensaver.c:101: error: implicit declaration of function 'posix_spawnattr_init'
inhibit/xscreensaver.c:101: error: 'vlc_inhibit_sys_t' has no member named 'attr'
inhibit/xscreensaver.c:103: error: implicit declaration of function 'posix_spawnattr_setsigmask'
inhibit/xscreensaver.c:103: error: 'vlc_inhibit_sys_t' has no member named 'attr'
inhibit/xscreensaver.c: In function 'Deactivate':
inhibit/xscreensaver.c:117: error: 'vlc_inhibit_sys_t' has no member named 'nullfd'
inhibit/xscreensaver.c:118: error: 'vlc_inhibit_sys_t' has no member named 'nullfd'
inhibit/xscreensaver.c:119: error: implicit declaration of function 'posix_spawnattr_destroy'
inhibit/xscreensaver.c:119: error: 'vlc_inhibit_sys_t' has no member named 'attr'
inhibit/xscreensaver.c:120: error: implicit declaration of function 'posix_spawn_file_actions_destroy'
inhibit/xscreensaver.c:120: error: 'vlc_inhibit_sys_t' has no member named 'actions'
inhibit/xscreensaver.c: In function 'Execute':
inhibit/xscreensaver.c:133: warning: unused parameter 'p_ih'
inhibit/xscreensaver.c:133: warning: unused parameter 'argv'
gmake[5]: *** [libxscreensaver_plugin_la-xscreensaver.lo] Error 1
gmake[5]: *** Waiting for unfinished jobs....
gmake[5]: Leaving directory `/usr/tmp/z/SRC/FreeBSD/HEAD/ports/multimedia/vlc/work/vlc-1.1.5/modules/misc'
gmake[4]: *** [all-recursive] Error 1
gmake[4]: Leaving directory `/usr/tmp/z/SRC/FreeBSD/HEAD/ports/multimedia/vlc/work/vlc-1.1.5/modules/misc'
gmake[3]: *** [all] Error 2
gmake[3]: Leaving directory `/usr/tmp/z/SRC/FreeBSD/HEAD/ports/multimedia/vlc/work/vlc-1.1.5/modules/misc'
gmake[2]: *** [all-recursive] Error 1
gmake[2]: Leaving directory `/usr/tmp/z/SRC/FreeBSD/HEAD/ports/multimedia/vlc/work/vlc-1.1.5/modules'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/usr/tmp/z/SRC/FreeBSD/HEAD/ports/multimedia/vlc/work/vlc-1.1.5'
gmake: *** [all] Error 2
*** Error code 1

Stop in /.../hal/z/SRC/FreeBSD/HEAD/ports/multimedia/vlc.
*** Error code 1

Stop in /.../hal/z/SRC/FreeBSD/HEAD/ports/multimedia/vlc.
make  422.42s user 51.24s system 148% cpu 5:19.72 total

How-To-Repeat: Try compiling vlc on FreeBSD 7.3
Comment 1 Martin Birgmeier 2010-11-20 10:13:33 UTC 
Here is a patch which seems to work, derived from running "git diff 
2a817cdbc2cd282b353cace71a8cd603d8151893 
860a707fa6b05eb59ee15da833af7d655176ff65" on the vlc git repository. It 
extends and replaces the patch already present in multimedia/vlc/files.

Regards,

Martin
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2010-11-20 14:04:30 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->jsa

Over to maintainer.
Comment 3 dfilter service freebsd_committer freebsd_triage 2010-11-23 17:26:07 UTC 
jsa         2010-11-23 17:25:58 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/vlc/files 
                         extra-patch-modules__misc__inhibit__xscreensaver.c 
  Log:
  Update xscreensaver.c patch to fix build on 7.x.
  
  PR:             ports/152412
  Submitted by:   Martin Birgmeier <martin.birgmeier@aon.at>
  Approved by:    kwm (mentor)
  
  Revision  Changes    Path
  1.2       +98 -25    ports/multimedia/vlc/files/extra-patch-modules__misc__inhibit__xscreensaver.c
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Joseph S. Atkinson freebsd_committer freebsd_triage 2010-11-23 17:26:43 UTC 
State Changed
From-To: open->closed

Committed. Thanks!