Bug 152947

Summary: Add ZFS ARC statistics into net-mgmt/collectd port
Product: Ports & Packages Reporter: Ivan Brawley <ivan>
Component: Individual Port(s)Assignee: Martin Wilke <miwi>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Ivan Brawley 2010-12-09 00:40:09 UTC 
The net-mgmt/collectd port has code for Solaris to gather ZFS ARC statistics.

However, it uses Solaris' get_kstat_value(3) library call to gather the stats and the configure run only tests for Solaris to gather ZFS ARC stats.

Included is a patch to the port tree net-mgmt/collectd to make the zfs_arc module for FreeBSD. It tests to make sure that at least version 8.0 of FreeBSD is used.

Because changes are needed to the included configure script, I've added the patches to the autoconf files so that a proper configure script can be generated.

I've given a copy of the patches to the zfs_arc.c source and to the autoconf file to the author of the zfs_arc module to work through getting that submitted as part of collectd's code.

Couple of months ago, I did send a copy of this to the port's maintainer and he suggested that I make a PR for it, so here it is (updated to work on port as of 3-Dec-2010).

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-12-09 00:40:14 UTC 
Maintainer of net-mgmt/collectd,

Please note that PR ports/152947 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/152947

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2010-12-09 00:40:16 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Krzysztof 2010-12-09 08:34:48 UTC 
Hello,

I approve this patch.

Greetings,
-- 
Krzysztof Stryjek
UNIX administrator/Juniper Networks Specialist
email: wtp (at) bsdserwis (dot) com
http://www.linkedin.com/in/KrzysztofStryjek
GPG fingerprint: 8BD7 40CE 8994 0BBE CE6C  91CD 1292 8959 DC61 0E76

In theory, there is no difference between theory and practice.
In practice, there is.
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2010-12-09 14:46:13 UTC 
State Changed
From-To: feedback->open

Maintainer approved.
Comment 5 Martin Wilke freebsd_committer freebsd_triage 2011-01-31 12:02:18 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->miwi

take
Comment 6 Martin Wilke freebsd_committer freebsd_triage 2011-01-31 12:02:30 UTC 
State Changed
From-To: open->feedback

-- net-mgmt/collectd/Makefile.orig      2010-12-07 10:02:42.958651026 
+1030 |+++ net-mgmt/collectd/Makefile 2010-12-09 10:40:18.041439748 
+1030 -------------------------- Patching file Makefile using Plan A... 
Hunk #1 failed at 13.  Hunk #2 succeeded at 37.  Hunk #3 succeeded at 
52.  Hunk #4 succeeded at 131.  Hunk #5 succeeded at 314.  1 out of 5 
hunks failed--saving rejects to Makefile.rej Hmm...  The next patch 
looks like a unified diff to me...  The text leading up to this was: 
-------------------------- 


patch reject can u please rework and resend to me as attachent. thx.
Comment 7 Martin Wilke freebsd_committer freebsd_triage 2011-03-04 09:41:21 UTC 
State Changed
From-To: feedback->closed

submmiter timeout