Bug 154538

Summary: [ patch ] MySQL 55 client/server compiled with diferent behavior than MySQL 51 client/server
Product: Ports & Packages Reporter: Dan Lukes <dan>
Component: Individual Port(s)Assignee: Alex Dupre <ale>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Dan Lukes 2011-02-05 22:40:08 UTC 
A)
Both MySQL 51 and MySQL 55 client can be compiled either with internal libedit (source's default) or system's libedit
The 51 client force unconditionally compilation with system libedit
The 55 client force unconditionally compilation with embedded libedit

Unfortunatelly, those libedits have diferent behavior so user interface changed. UI become diferent not only to previous
MySQL behavior, but it also diverge from UI of other system utilities that use system libedit
It cause unnecesarry discomfort to user as embedded libedit doesn't offer new or better function to user.
Even worse, both libedits have different format of history file, but store the data into same filename - so after
upgrade all users have they histories destroyed with no warning

B)
Both MySQL 51 and MySQL 55 server can be compiled either without (source's default) or with LIBWRAP
The 51 server force unconditionally compilation with libwrap
The 55 server force unconditionally compilation without libwrap

It cause diferent server behavior.

Fix: It would be nice to either
1) restore same "port defaults" as has been forced in 51 - e.g. system libedit and use of libwrap
or
2) create WITH_* knobs that allow system administrator to request "51" compatible behavior

The attached patch implement 1) variant 
(e.g. non-configurable return to 51 behavior = unconditional compilation with system's libedit and libwrap)
Comment 1 Tilman Keskinoz freebsd_committer freebsd_triage 2011-02-06 10:34:27 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->ale

Over to maintainer
Comment 2 dfilter service freebsd_committer freebsd_triage 2011-02-08 16:37:47 UTC 
ale         2011-02-08 16:37:40 UTC

  FreeBSD ports repository

  Modified files:
    databases/mysql55-client Makefile pkg-plist 
    databases/mysql55-client/files patch-include_CMakeLists.txt 
                                   patch-support-files_CMakeLists.txt 
    databases/mysql55-server Makefile distinfo 
    databases/mysql55-server/files patch-include_CMakeLists.txt 
  Removed files:
    databases/mysql55-client/files patch-scripts_mysql_config.sh 
  Log:
  Update to 5.5.9 release [1]
  Use system readline instead of bundled libedit [2]
  Enable tcp wrappers [2]
  
  PR:             ports/154579 [1], ports/154538 [2]
  Submitted by:   mm [1], Dan Lukes <dan@obluda.cz> [2]
  Feature safe:   yes
  
  Revision  Changes    Path
  1.108     +0 -1      ports/databases/mysql55-client/Makefile
  1.2       +2 -10     ports/databases/mysql55-client/files/patch-include_CMakeLists.txt
  1.2       +0 -15     ports/databases/mysql55-client/files/patch-scripts_mysql_config.sh (dead)
  1.2       +6 -10     ports/databases/mysql55-client/files/patch-support-files_CMakeLists.txt
  1.3       +0 -1      ports/databases/mysql55-client/pkg-plist
  1.273     +5 -3      ports/databases/mysql55-server/Makefile
  1.127     +2 -2      ports/databases/mysql55-server/distinfo
  1.2       +4 -6      ports/databases/mysql55-server/files/patch-include_CMakeLists.txt
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Alex Dupre freebsd_committer freebsd_triage 2011-02-08 16:37:57 UTC 
State Changed
From-To: open->closed

Committed, thanks.