Bug 155655

Summary: [patch] science/meep Add Option to support MPI build
Product: Ports & Packages Reporter: Klaus Aehlig <aehlig>
Component: Individual Port(s)Assignee: Stephen Montgomery-Smith <stephen>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
meep.diff
none
meep_stast.txt
none
libctl.txt none

Description Klaus Aehlig 2011-03-18 09:20:09 UTC 
	meep supports building for MPI, but the current state of the port does not support
	this configure option. MPI support, however, is very usefull for larger simulations
	on multi-processor machines.

	I therefore suggest to add an Option (default: Off) to build the MPI version of meep.

Fix: Apply the following patch.

	Note:
	- the patch also contains the missing (semantical) gsed-dependency noted in ports/155469; I 
	  nevertheless decided to send a new report rather than a follow-up, as this is a new issue 
	  with a much larger change-request
	- while there, the patch also removes MD5 checksum
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-03-18 09:20:22 UTC 
Maintainer of science/meep,

Please note that PR ports/155655 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/155655

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-03-18 09:20:24 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 devel 2011-04-20 10:51:21 UTC 
  Thanks for PRs.
Both ports/155655 and ports/155469 are good additions to science/meep port. 
MPI knob should be turned on by deafult, because SMP hosts are cheap enough at 
2011 ;-)

Here is cumulative patch for them (meep_stast.txt) and patch for 
science/libctl 
(workaround for building libctl with libtool via copy-pasting from 
http://www.freebsd.org/cgi/query-pr.cgi?pr=155105&cat=ports).
Comment 4 Stephen Montgomery-Smith freebsd_committer freebsd_triage 2011-06-17 22:39:11 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->stephen

I'll take this.
Comment 5 Stephen Montgomery-Smith 2011-06-17 22:56:48 UTC 
Stas,

1.  Can you email me again the patch you submitted?  It got mangled by 
GNATS.

2.  I appreciate your confidence in copying my proposed solution 
ports/155105.  But I suspect that I'll have to discuss it with the 
community at large to see if this is acceptable.

Thanks, Stephen
Comment 6 dfilter service freebsd_committer freebsd_triage 2011-06-21 03:19:16 UTC 
stephen     2011-06-21 02:19:07 UTC

  FreeBSD ports repository

  Modified files:
    science/meep         Makefile distinfo pkg-plist 
    science/meep/files   patch-configure 
  Added files:
    science/meep/files   patch-Makefile.in 
  Log:
  - Add optional dependency net/openmpi
  - Add lib_depends textproc/gsed
  - Make datadir safe
  - Move pkgconfig from lib to libdata
  - Make patches to configure prefix friendly
  
  PR:             ports/155655
  Submitted by:   Klaus Aehlig <aehlig@linta.de>
  Approved by:    maho (mentor) and
                          Stas Timokhin <devel@stasyan.com> (maintainer)
  
  Revision  Changes    Path
  1.5       +31 -11    ports/science/meep/Makefile
  1.2       +0 -1      ports/science/meep/distinfo
  1.1       +19 -0     ports/science/meep/files/patch-Makefile.in (new)
  1.2       +26 -16    ports/science/meep/files/patch-configure
  1.2       +12 -8     ports/science/meep/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Stephen Montgomery-Smith freebsd_committer freebsd_triage 2011-06-21 03:24:57 UTC 
State Changed
From-To: feedback->closed

Committed changes to meep, with several portlint corrections. 

Fixing libtool issue is ongoing issue, and so the science/libctl changes 
are not committed, except that Stas Timokhin is now the maintainer.
Comment 8 Stephen Montgomery-Smith 2011-06-21 03:34:37 UTC 
Dear Stas,

I haven't committed your suggested changes to science/libctl.  The 
libtools issue is ongoing.

But I have honored your implicit request to become maintainer of 
science/libctl.

Best regards, Stephen