Bug 156269

Summary: Fix port: devel/allegro for gmake-3.82
Product: Ports & Packages Reporter: Chris Rees <utisoft>
Component: Individual Port(s)Assignee: Ade Lovett <ade>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
allegro-gmake-fix.diff none

Description Chris Rees 2011-04-08 07:10:12 UTC 
	gmake 3.82 whines when building allegro with:

		recipe commences before first target.  Stop.

	This is because the authors put 'define' blocks inside targets, which is no longer valid for gmake (and also not mentioned in the gmake changelog ... )

Fix: Move define blocks out of targets, and remove clean targets (they're irrelevant for FreeBSD and have loads of fiddly defines inside them).

	This can be committed anyway; it's safe for both versions of gmake and only fixes syntax that was bad anyway-- you just can't get away with it in the new gmake.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-04-08 07:10:26 UTC 
Maintainer of devel/allegro,

Please note that PR ports/156269 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/156269

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-04-08 07:10:28 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Naram Qashat 2011-04-08 13:31:46 UTC 
I approve this patch.

On 04/08/11 02:10, Edwin Groothuis wrote:
> Maintainer of devel/allegro,
>
> Please note that PR ports/156269 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>      http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/156269
>
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2011-04-09 21:19:18 UTC 
State Changed
From-To: feedback->open

Maintainer approved.
Comment 5 Ade Lovett freebsd_committer freebsd_triage 2011-04-11 20:59:38 UTC 
State Changed
From-To: open->closed

Did something very similar as part of the gmake-3.82 update patchset.
Comment 6 Ade Lovett freebsd_committer freebsd_triage 2011-04-11 20:59:38 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->ade

Did something very similar as part of the gmake-3.82 update patchset.