Bug 156975
| Summary: | devel/qct plist is wrong | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Lapo Luchini <lapo> | ||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | lapo | ||||
| Priority: | Normal | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
|
Description
Lapo Luchini
2011-05-12 10:50:08 UTC
Responsible Changed From-To: freebsd-ports-bugs->bsam Over to maintainer (via the GNATS Auto Assign Tool) bsam 2011-05-12 16:42:27 UTC
FreeBSD ports repository
Modified files:
devel/qct Makefile pkg-plist
Log:
. fix plist [1];
. use easy_install;
. use py-qt4-gui to build the port.
PR: 156975 [1]
Pointed out by: Lapo Luchini <lapo@lapo.it> [1]
Revision Changes Path
1.15 +4 -3 ports/devel/qct/Makefile
1.5 +66 -56 ports/devel/qct/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->feedback Should be fixed now. Please, test and provide a feedback. bsam@FreeBSD.org wrote: > Synopsis: devel/qct plist is wrong > > State-Changed-From-To: open->feedback > State-Changed-By: bsam > State-Changed-When: Thu May 12 16:44:06 UTC 2011 > State-Changed-Why: > Should be fixed now. Please, test and provide a feedback. porttools stills complais about this: ===> Extra files and directories check lib/python2.6/site-packages/site.pyo lib/python2.6/site-packages/site.pyc lib/python2.6/site-packages/site.py lib/python2.6/site-packages/easy-install.pth ...but I don't know easy-install (nor python), so maybe that's normal since it's a common file in all the easy-install packages and only the last one should delete it? (or something) Also, the attached patch silences portlint warnings. cheers, State Changed From-To: feedback->open Feedback is received. On Fri, 13 May 2011 09:10:56 +0200 Lapo Luchini wrote: > porttools stills complais about this: > ===> Extra files and directories check > lib/python2.6/site-packages/site.pyo > lib/python2.6/site-packages/site.pyc > lib/python2.6/site-packages/site.py > lib/python2.6/site-packages/easy-install.pth It's OK at my tinderbox. Can you get a clue how to reproduce it? > ...but I don't know easy-install (nor python), so maybe that's normal > since it's a common file in all the easy-install packages and only the > last one should delete it? (or something) > Also, the attached patch silences portlint warnings. Hm, I don't have warnings: ----- % portlint -aC % looks fine. % pkg_info -Ix portlint portlint-2.13.5 A verifier for FreeBSD port directory ----- -- WBR, bsam Boris Samorodov wrote: > It's OK at my tinderbox. Can you get a clue how to reproduce it? It's probably a side-effect of the fact that porttools build in /tmp/XXX instead of the usual directory, maybe (but I thought that tinderbox did similar similar trick too, or isn't that so?). > Hm, I don't have warnings: > ----- > % portlint -aC Err, what's happening? Same portlint, different results. % portlint -aC WARN: Makefile: "BUILD_DEPENDS" has to appear earlier. WARN: Makefile: "RUN_DEPENDS" has to appear earlier. FATAL: /home/lapo/ports/qct/distinfo: [1]: unsupported checksum algorithm found: MD5. WARN: no CVS directories. Use -N to check a new port. 1 fatal error and 3 warnings found. % pkg_info -Ix portlint portlint-2.13.5 A verifier for FreeBSD port directory % uname -a FreeBSD lapo.andxor.it 8.2-RELEASE FreeBSD 8.2-RELEASE #0: [...] amd64 Another important thing: latest port always fails with: % qct Traceback (most recent call last): File "/usr/local/bin/qct", line 5, in <module> pkg_resources.run_script('qct==1.7', 'qct') File "build/bdist.freebsd-8.2-RELEASE-amd64/egg/pkg_resources.py", line 489, in run_script File "build/bdist.freebsd-8.2-RELEASE-amd64/egg/pkg_resources.py", line 1207, in run_script File "/usr/local/lib/python2.6/site-packages/qct-1.7-py2.6.egg/EGG-INFO/scripts/qct", line 13, in <module> from qctlib.gui_logic import CommitTool File "/usr/local/lib/python2.6/site-packages/qct-1.7-py2.6.egg/qctlib/gui_logic.py", line 9, in <module> from qctlib.ui_dialog import Ui_commitToolDialog ImportError: No module named ui_dialog I was meaning to check that better before reporting (and maybe have a patch ready), but as far as I understand of Python (i.e. very little!) it's searching for a ui_dialog.py file which is missing in the package, but also in the very same source tarball (!!!) that was working in the 1.7_4 version of the package. I don't know if that problem is mine or what, but I wrote it just in case; if you don't get that, just ignore this part of the message, I'll check better in the next days (and erport back if needed). Previously the port did use "distutils" and (watherver that is) it called "gmake", which was properly generating the missing files: % gmake pyuic4 qctlib/dialog.ui > qctlib/ui_dialog.py pyuic4 qctlib/preferences.ui > qctlib/ui_preferences.py pyuic4 qctlib/select.ui > qctlib/ui_select.py It seems that changing to use easyinstall in 1.15 avoid that and, thus, the three (necessary) files don't get built and installed. Responsible Changed From-To: bsam->freebsd-ports-bugs Return to the pool. rm 2012-01-18 15:26:36 UTC
FreeBSD ports repository
Modified files:
devel/qct Makefile pkg-descr pkg-plist
Added files:
devel/qct/files patch-setup.py
Log:
Switch back to using distutils to fix runtime. Also fix logic bug in
setup.py that had mixing use of setuptools with distutils.
With using setuptools some ui-related files are not generating
and not installing so gui becomes broken. As for original submitter's
plist problem, i believe it was also because it needs py-qt4-gui on build stage
too, not only on runtime (see QctBuild.compile_ui() in setup.py for details).
This port revision works fine for me both on live system and in tinderbox.
Please also note that this port doesn't work with modern mercurial versions,
but works fine with cvs/svn. hg support should be trivial to fix, but i have
no time/desire resources for this.
PR: 156975
Submitted by: Lapo Luchini <lapo at lapo dot it>
Revision Changes Path
1.18 +3 -3 ports/devel/qct/Makefile
1.1 +25 -0 ports/devel/qct/files/patch-setup.py (new)
1.3 +0 -2 ports/devel/qct/pkg-descr
1.6 +56 -66 ports/devel/qct/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed, thank you! |
