Bug 157158

Comment 1 Edwin Groothuis 2011-05-18 20:50:30 UTC

Responsible Changed
From-To: freebsd-ports-bugs->ume

Over to maintainer (via the GNATS Auto Assign Tool)

Sorry, forgot to include a commit message:

- Rename CONF_FILES to avoid conflict with incoming feature

PR: ports/15716
Submitted by: Chris Rees (utisoft@gmail.com)

This time with correct PR number:

- Rename CONF_FILES to avoid conflict with incoming feature

PR: ports/157158
Submitted by: Chris Rees (utisoft@gmail.com)

On 2 June 2011 16:50, Hajimu UMEMOTO <ume@mahoroba.org> wrote:
> Hi,
>
>> On Thu, 2 Jun 2011 14:16:33 +0100
>> Chris Rees <utisoft@gmail.com> said:
>
> utisoft> I'm sorry to have dropped this in your lap [1] -- it's just
> utisoft> a little patch to rename the CONF_FILES variables in the
> utisoft> mpd-l2tp-ipv6pd-client port.
>
> utisoft> Please would you let me know if you'll have time to deal with them? If
> utisoft> not I'll ask someone else to!
>
> utisoft> [1] http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/157158
>
> It seems to me that the patch in the PR is not for
> mpd-l2tp-ipv6pd-client port.
>

Er, you're right... I'm really sorry!

Correct patch is at [1].

Thanks!

Chris

[1] http://www.bayofrum.net/~crees/patches/conf_files/net-mpd-l2tp-ipv6pd-client.patch

Hi,

>>>>> On Thu, 2 Jun 2011 16:20:11 GMT
>>>>> Chris Rees <utisoft@gmail.com> said:

utisoft>  Er, you're right... I'm really sorry!

No problem.

utisoft>  Correct patch is at [1].
utisoft>  [1] http://www.bayofrum.net/~crees/patches/conf_files/net-mpd-l2tp-ipv6pd-client.patch

Thank you for the patch.
The Description of the PR mentions about CONF_DIRS as well.  However,
your patch care only CONF_FILES.  mpd-l2tp-ipv6pd-client port uses
CONF_DIRS as well.  Is it okay to leave it as is?

Sincerely,

--
Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan
ume@mahoroba.org  ume@{,jp.}FreeBSD.org
http://www.imasy.org/~ume/

On 3 June 2011 07:48, Hajimu UMEMOTO <ume@mahoroba.org> wrote:
> Hi,
>
>>>>>> On Thu, 2 Jun 2011 16:20:11 GMT
>>>>>> Chris Rees <utisoft@gmail.com> said:
>
> utisoft> =A0Er, you're right... I'm really sorry!
>
> No problem.
>
> utisoft> =A0Correct patch is at [1].
> utisoft> =A0[1] http://www.bayofrum.net/~crees/patches/conf_files/net-mpd=
-l2tp-ipv6pd-client.patch
>
> Thank you for the patch.
> The Description of the PR mentions about CONF_DIRS as well. =A0However,
> your patch care only CONF_FILES. =A0mpd-l2tp-ipv6pd-client port uses
> CONF_DIRS as well. =A0Is it okay to leave it as is?
>

Aha, the variable in the port is CONF_DIR (no S), therefore it's fine.

Chris

Comment 7 dfilter service 2011-06-03 18:32:10 UTC

ume         2011-06-03 17:31:55 UTC

  FreeBSD ports repository

  Modified files:
    net/mpd-l2tp-ipv6pd-client Makefile 
  Log:
  New variables CONF_FILES and CONF_DIRS are to be introduced
  to bsd.port.mk.
  
  PR:             ports/157158
  Submitted by:   Chris Rees <utisoft__at__gmail.com>
  
  Revision  Changes    Path
  1.6       +2 -2      ports/net/mpd-l2tp-ipv6pd-client/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"

Hi,

>>>>> On Fri, 3 Jun 2011 08:33:42 +0100
>>>>> Chris Rees <utisoft@gmail.com> said:

utisoft> Aha, the variable in the port is CONF_DIR (no S), therefore it's fine.

Thank you for clarification.
I've just committed it.

Sincerely,

--
Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan
ume@mahoroba.org  ume@{,jp.}FreeBSD.org
http://www.imasy.org/~ume/

Comment 9 Hajimu UMEMOTO 2011-06-03 18:37:04 UTC

State Changed
From-To: open->closed

Thanks, committed!