Bug 157529
| Summary: | [modules] [patch] r222557 broke buildworld with MODULES_WITH_WORLD=yes | ||
|---|---|---|---|
| Product: | Base System | Reporter: | Eugene Grosbein <ports> |
| Component: | kern | Assignee: | Artem Belevich <art> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | CC: | art |
| Priority: | Normal | ||
| Version: | 8.2-STABLE | ||
| Hardware: | Any | ||
| OS: | Any | ||
Responsible Changed From-To: freebsd-i386->art Refers to MFC in: http://svnweb.freebsd.org/base/stable/8/sys/modules/dtrace/dtraceall/Makefile?view=markup&pathrev=222557 Hi! Do you plan to deal with this problem? If no, please change "Responsible" so this PR may be taken by someone else. Eugene Grosbein Author: art Date: Mon Aug 1 04:29:04 2011 New Revision: 224560 URL: http://svn.freebsd.org/changeset/base/224560 Log: Create dummy opt_compat.h for i386 build to fix buildworld breakage when MODULES_WITH_WORLD is set. PR: 157529 Submitted by: Eugene Grosbein Approved by: avg (mentor) Modified: stable/8/sys/modules/dtrace/dtraceall/Makefile Modified: stable/8/sys/modules/dtrace/dtraceall/Makefile ============================================================================== --- stable/8/sys/modules/dtrace/dtraceall/Makefile Mon Aug 1 02:57:46 2011 (r224559) +++ stable/8/sys/modules/dtrace/dtraceall/Makefile Mon Aug 1 04:29:04 2011 (r224560) @@ -9,6 +9,8 @@ CFLAGS+= -I${.CURDIR}/../../.. opt_compat.h: .if ${MACHINE_ARCH} == "amd64" echo "#define COMPAT_FREEBSD32 1" >> ${.TARGET} +.else + echo -n >> ${.TARGET} .endif .endif _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" State Changed From-To: open->closed Fix has been committed. |
'make MODULES_WITH_WORLD=yes' was fixed in RELENG_8 13 May only with kern/138341 and now it's broken again for i386: mkdep -f .depend -a -nostdinc -D_KERNEL -DKLD_MODULE -I/usr/src/sys/modules/dtrace/dtraceall/../../.. -I. -I@ -I@/contrib/altq /usr/src/sys/modules/dtrace/dtraceall/dtraceall.c /usr/src/sys/modules/dtrace/dtraceall/dtraceall.c:35:24: error: opt_compat.h: No such file or directory Fix: Eugene Grosbein--zqolKNaGgugAAMfsH45YLPvvxgvcozcm6Fi0P4zhZQRVl2fQ Content-Type: text/plain; name="file.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="file.diff" --- sys/modules/dtrace/dtraceall/Makefile.orig 2011-06-02 22:01:42.000000000 +0700 +++ sys/modules/dtrace/dtraceall/Makefile 2011-06-02 22:02:12.000000000 +0700 @@ -9,6 +9,8 @@ opt_compat.h: .if ${MACHINE_ARCH} == "amd64" echo "#define COMPAT_FREEBSD32 1" >> ${.TARGET} +.else + echo -n >> ${.TARGET} .endif .endif How-To-Repeat: Use FreeBSD 8.2-STABLE/i386: cd /usr/src && make MODULES_WITH_WORLD=yes buildworld