Bug 157784

Summary: [PATCH] comms/xmorse broken
Product: Ports & Packages Reporter: Stephen Hurd <shurd>
Component: Individual Port(s)Assignee: Diane Bruce <db>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Stephen Hurd freebsd_committer freebsd_triage 2011-06-12 04:50:06 UTC
The last patch while fixing the build broke the program.  The program is supposed to start playing morse when the text box is clicked... the patch-m.pl prevented this from happening breaking the entire point of the program.

Fix: Instead of commenting out the line, change it to:
  code {Morse->show(argc, argv);

This just requires diddling the patch to:
How-To-Repeat: Install port
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-06-12 04:50:15 UTC
Maintainer of comms/xmorse,

Please note that PR ports/157784 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/157784

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-06-12 04:50:16 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Diane Bruce freebsd_committer freebsd_triage 2011-06-12 17:02:29 UTC
Responsible Changed
From-To: freebsd-ports-bugs->db

I'll take it.
Comment 4 Sunry Chen 2011-07-08 04:17:53 UTC
While I can't reproduce this bug.

FreeBSD freebsd.changsha 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Fri Feb 18
02:24:46 UTC 2011    root@almeida.cse.buffalo.ed:/usr/lbj/sr/src/sys/GENERIC
i386
Comment 5 Sunry Chen 2011-07-21 09:32:23 UTC
There is problem while running the program, no problem compile it.

xmorse should produce morse sound white click in the white space bar.
The problem is that no sound out! With the patch it works.

So I approve the patch.
Comment 6 dfilter service freebsd_committer freebsd_triage 2011-07-21 17:24:41 UTC
db          2011-07-21 16:24:26 UTC

  FreeBSD ports repository

  Modified files:
    comms/xmorse/files   patch-m.fl 
  Log:
  - The last patch while fixing the build broke the program.  The program is
    supposed to start playing morse when the text box is clicked... the
    patch-m.pl prevented this from happening breaking the entire point
    of the program.
  
  PR:             ports/157784
  Submitted by:   Stephen Hurd <shurd@sasktel.net>
  
  Revision  Changes    Path
  1.2       +3 -3      ports/comms/xmorse/files/patch-m.fl
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Diane Bruce freebsd_committer freebsd_triage 2011-07-21 17:25:04 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!