Bug 157982

Summary: Fix port: mail/p5-Mail-SpamAssassin uses absolute path in @dirrmtry
Product: Ports & Packages Reporter: Chris Rees <crees>
Component: Individual Port(s)Assignee: freebsd-perl (Nobody) <perl>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description Chris Rees 2011-06-18 11:50:01 UTC 

Fix: - Use @stopdaemon
	- Correct absolute path in @dirrmtry
	- Silence error if /var/db/spamassassin doesn't exist



-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.--ySEwdwEyVRrVG29WFgiNV74l2tcvqU7v3v95wJ7WfXDHi3GP
Content-Type: text/plain; name="p5-Mail-SpamAssassin-plist.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="p5-Mail-SpamAssassin-plist.diff"

Index: pkg-plist
===================================================================
RCS file: /exports/cvsroot-freebsd/ports/mail/p5-Mail-SpamAssassin/pkg-plist,v
retrieving revision 1.46
diff -u -r1.46 pkg-plist
--- pkg-plist	10 Feb 2010 13:37:11 -0000	1.46
+++ pkg-plist	18 Jun 2011 09:15:13 -0000
@@ -1,5 +1,4 @@
-@unexec %D/etc/rc.d/sa-spamd.sh stop > /dev/null 2>&1 || true
-@unexec %D/etc/rc.d/sa-spamd stop > /dev/null 2>&1 || true
+@stopdaemon sa-spamd
 bin/sa-awl
 bin/sa-check_spamd
 bin/sa-compile
@@ -134,7 +133,7 @@
 @unexec rm -rf /var/lib/spamassassin/2* || true
 @unexec rmdir /var/lib/spamassassin 2>/dev/null  || true
 @unexec rmdir /var/lib 2>/dev/null || true
-@unexec rmdir /var/db/spamassassin || true
+@unexec rmdir /var/db/spamassassin 2>/dev/null || true
 @dirrm %%DATADIR%%
 @dirrm %%SITE_PERL%%/%%PERL_ARCH%%/auto/Mail/SpamAssassin
 @dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/Mail
@@ -151,4 +150,3 @@
 @dirrmtry %%SITE_PERL%%/Mail
 @dirrmtry etc/mail/spamassassin
 @dirrmtry etc/mail
-@dirrmtry /var/run/spamd
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-06-18 11:50:21 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->perl

perl@ wants this port PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-06-18 11:50:25 UTC 
Maintainer of mail/p5-Mail-SpamAssassin,

Please note that PR ports/157982 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/157982

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2011-06-18 11:50:27 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Chris Rees freebsd_committer freebsd_triage 2011-06-18 12:29:39 UTC 
Er... sorry I sent this from the wrong email address.

If you want me to deal with this PR then feel free to make me responsible.

Chris
Comment 5 Michael Scheidell 2011-06-18 12:37:29 UTC 
On 6/18/11 6:50 AM, Edwin Groothuis wrote:
> Maintainer of mail/p5-Mail-SpamAssassin,
>
> Please note that PR ports/157982 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
patch looks fine.. no need to bump portversion, no need to make 
automatic portupgrades rebuild.  if it was running for existing users, 
doesn't require rebuilds.


> The full text of the PR can be found at:
>      http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/157982
>
______________________________________________________________________
This email has been scanned and certified safe by SpammerTrap(r). 
For Information please see http://www.secnap.com/products/spammertrap/
______________________________________________________________________
Comment 6 Michael Scheidell 2011-06-24 12:10:13 UTC 
somehow this one got missed when .  please do NOT apply this patch, I am 
submitting this patch again with the sa 3.3.2 upgrade.
please close this patch as superseded.


-- 
Michael Scheidell, CTO
o: 561-999-5000
d: 561-948-2259
 >*| *SECNAP Network Security Corporation

    * Best Mobile Solutions Product of 2011
    * Best Intrusion Prevention Product
    * Hot Company Finalist 2011
    * Best Email Security Product
    * Certified SNORT Integrator

______________________________________________________________________
This email has been scanned and certified safe by SpammerTrap(r). 
For Information please see http://www.secnap.com/products/spammertrap/
______________________________________________________________________
Comment 7 Wesley Shields freebsd_committer freebsd_triage 2011-06-26 17:32:12 UTC 
State Changed
From-To: feedback->closed

This is incorporated into ports/158267, which I am looking into.