Bug 158779

Summary: [patch] net-mgmt/ourmon support apache versions > 13
Product: Ports & Packages Reporter: Olli Hauer <ohauer>
Component: Individual Port(s)Assignee: Olli Hauer <ohauer>
Status: Closed FIXED    
Severity: Affects Only Me CC: manos
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
ourmon.diff none

Description Olli Hauer freebsd_committer freebsd_triage 2011-07-10 23:30:09 UTC 
At the moment the port has USE_APACHE=13 hard coded,
but I suspect it will also run with apache > 13.

I changed the following parts for the port
 - set IS_INTERACTIVE=yes
 - use %%WWWDIR%% macro instead hard coded path
 - make sure we use the rc script from port
 - use "env" in generated crontab
 - make sure crontab entries are removed during deinstall
 - sort pkg-plist (use genplist)
 - try to uninstall clean

Additional place a "#" before the jobs in crontab
(can be changed back again if preferred)

I havn't test functionality, my main target is to preserve
the port if we deprecate apache13.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-07-10 23:30:23 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->ohauer

Submitter has GNATS access (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-07-10 23:30:28 UTC 
Maintainer of net-mgmt/ourmon,

Please note that PR ports/158779 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/158779

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2011-07-10 23:30:32 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 manos 2011-07-18 15:56:31 UTC 
Quoting Edwin Groothuis <edwin@FreeBSD.ORG>:

> Maintainer of net-mgmt/ourmon,
>
> Please note that PR ports/158779 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.

Oh, right, I'm still listed as the maintainer of ourmon.
I believe  the change to support >1.3 apache will work. The other  
changes (cleanups) make sense to me as well.

Thanks!

  -Charlie
Comment 5 dfilter service freebsd_committer freebsd_triage 2011-07-18 22:21:23 UTC 
ohauer      2011-07-18 21:21:09 UTC

  FreeBSD ports repository

  Modified files:
    net-mgmt/ourmon      Makefile pkg-plist 
  Added files:
    net-mgmt/ourmon      pkg-deinstall 
    net-mgmt/ourmon/files patch-configure.pl 
  Log:
  - set IS_INTERACTIVE=yes
  - use %%WWWDIR%% macro instead hard coded path
  - support apache versions > 13
  - make sure we use the rc script from port
  - use "env" in generated crontab
  - make sure crontab entries are removed during deinstall
  - sort pkg-plist (use genplist)
  - try to uninstall clean
  
  PR:             ports/158779
  Submitted by:   ohauer
  Approved by:    <manos _at_ cs.pdx.edu> (maintainer)
  
  Revision  Changes    Path
  1.12      +9 -3      ports/net-mgmt/ourmon/Makefile
  1.1       +88 -0     ports/net-mgmt/ourmon/files/patch-configure.pl (new)
  1.1       +11 -0     ports/net-mgmt/ourmon/pkg-deinstall (new)
  1.4       +532 -243  ports/net-mgmt/ourmon/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Olli Hauer freebsd_committer freebsd_triage 2011-07-18 22:38:47 UTC 
State Changed
From-To: feedback->closed

Committed, 

Thanks!