Summary: | [bsd.port.mk] Add a filename field to DESKTOP_ENTRIES | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Scot Hetzel <swhetze.l> | ||||||||||
Component: | Ports Framework | Assignee: | Port Management Team <portmgr> | ||||||||||
Status: | Closed Overcome By Events | ||||||||||||
Severity: | Affects Only Me | ||||||||||||
Priority: | Normal | ||||||||||||
Version: | Latest | ||||||||||||
Hardware: | Any | ||||||||||||
OS: | Any | ||||||||||||
Attachments: |
|
Description
Scot Hetzel
2011-07-15 07:20:07 UTC
Responsible Changed From-To: freebsd-bugs->portmgr portmgr territory. State Changed From-To: open->feedback In principle this looks good, but can you provide patches to a couple of ports that would convert them to the new variable? Just to see it in action.. Thank you. Just noticed that I had forgotten a '; \' after the check to make sure that the filename is defined in check-desktop-entries for DESKTOP_ENTRIESv2. The attached patch fixes this. Scot On Fri, Jul 15, 2011 at 3:16 AM, <pav@freebsd.org> wrote: > Synopsis: Mk/bsd.ports.mk: Add a filename field to DESKTOP_ENTRIES > > State-Changed-From-To: open->feedback > State-Changed-By: pav > State-Changed-When: Fri Jul 15 08:15:04 UTC 2011 > State-Changed-Why: > In principle this looks good, but can you provide patches to a couple of ports > that would convert them to the new variable? Just to see it in action.. Thank > you. > > http://www.freebsd.org/cgi/query-pr.cgi?pr=158936 > The attached patch is for the games/tome, misc/metalink-editor and www/links ports. Scot On Fri, Jul 15, 2011 at 11:41 AM, Scot Hetzel <swhetzel@gmail.com> wrote: > Just noticed that I had forgotten a '; \' after the check to make sure > that the filename is defined in check-desktop-entries for > DESKTOP_ENTRIESv2. > > The attached patch fixes this. > ignore the previous patch to fix the missing '; \', instead use this one. Scot Not sure why my replies are not showing up properly in the PR. When applying the patch use patch.txt and the last bsd.port.mk-diff2 patch. The DESKTOP_ENTRIESv2-ports-diff is a patch for the games/tome, misc/metalink-editor and www/links to show that the DESKTOP_ENTRIESv2 patch works. Scot. State Changed From-To: feedback->open Feedback received Infrastructure PR. 8 years without anyone really having a look at it :( I will close this bug for now, in the hope it is no really needed anymore. Please reopen it, if I am wrong. |