|Summary:||[bsd.port.mk] Add a filename field to DESKTOP_ENTRIES|
|Product:||Ports & Packages||Reporter:||Scot Hetzel <swhetze.l>|
|Component:||Ports Framework||Assignee:||Port Management Team <portmgr>|
|Status:||Closed Overcome By Events|
|Severity:||Affects Only Me|
Description Scot Hetzel 2011-07-15 07:20:07 UTC
Currently, DESKTOP_ENTRIES creates a filename for the .desktop file from the Exec field. The problem with this approach is that you can't specify arguments to the command, otherwise you will get strangely name .desktop files. Fix: Create a new DESKTOP_ENTRIES variable that has a field for the filename. The attached patch adds a new DESKTOP_ENTRIESv2 variable that handles this. Patch attached with submission follows: How-To-Repeat: install any one of these 3 ports that use arguments in their Exec field: www/links misc/metalink-editor games/tome
Comment 1 Sunpoet Po-Chuan Hsieh 2011-07-15 07:48:01 UTC
Responsible Changed From-To: freebsd-bugs->portmgr portmgr territory.
Comment 2 Pav Lucistnik 2011-07-15 09:15:04 UTC
State Changed From-To: open->feedback In principle this looks good, but can you provide patches to a couple of ports that would convert them to the new variable? Just to see it in action.. Thank you.
Comment 3 Scot Hetzel 2011-07-15 17:41:03 UTC
Just noticed that I had forgotten a '; \' after the check to make sure that the filename is defined in check-desktop-entries for DESKTOP_ENTRIESv2. The attached patch fixes this. Scot
Comment 4 Scot Hetzel 2011-07-15 17:44:15 UTC
On Fri, Jul 15, 2011 at 3:16 AM, <firstname.lastname@example.org> wrote: > Synopsis: Mk/bsd.ports.mk: Add a filename field to DESKTOP_ENTRIES > > State-Changed-From-To: open->feedback > State-Changed-By: pav > State-Changed-When: Fri Jul 15 08:15:04 UTC 2011 > State-Changed-Why: > In principle this looks good, but can you provide patches to a couple of ports > that would convert them to the new variable? Just to see it in action.. Thank > you. > > http://www.freebsd.org/cgi/query-pr.cgi?pr=158936 > The attached patch is for the games/tome, misc/metalink-editor and www/links ports. Scot
Comment 5 Scot Hetzel 2011-07-15 19:12:27 UTC
On Fri, Jul 15, 2011 at 11:41 AM, Scot Hetzel <email@example.com> wrote: > Just noticed that I had forgotten a '; \' after the check to make sure > that the filename is defined in check-desktop-entries for > DESKTOP_ENTRIESv2. > > The attached patch fixes this. > ignore the previous patch to fix the missing '; \', instead use this one. Scot
Comment 6 Scot Hetzel 2011-07-15 19:32:23 UTC
Not sure why my replies are not showing up properly in the PR. When applying the patch use patch.txt and the last bsd.port.mk-diff2 patch. The DESKTOP_ENTRIESv2-ports-diff is a patch for the games/tome, misc/metalink-editor and www/links to show that the DESKTOP_ENTRIESv2 patch works. Scot.
Comment 7 Pav Lucistnik 2011-07-15 20:03:46 UTC
State Changed From-To: feedback->open Feedback received
Comment 8 Mark Linimon 2014-06-02 02:55:56 UTC
Comment 9 Baptiste Daroussin 2019-09-04 13:41:49 UTC
8 years without anyone really having a look at it :( I will close this bug for now, in the hope it is no really needed anymore. Please reopen it, if I am wrong.