Bug 158959

Summary: Clarify pkg-message: ports-mgmt/tinderbox (-devel)? no trailing slashes
Product: Ports & Packages Reporter: Chris Rees <crees>
Component: Individual Port(s)Assignee: Ion-Mihai "IOnut" Tetcu <itetcu>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description Chris Rees freebsd_committer freebsd_triage 2011-07-16 01:10:10 UTC
	Tinderbox displays a helpful list of alias commands on install, but the
displayed ones force the user to specify a trailing slash when accessing the webui.

Fix: I changed the lighttpd suggestions when I installed Tinderbox a year ago, and just revisited the problem when installing it on another computer running Apache.



-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.--wPt2cJpqKVFUOvCRAUkf1nXKfqYYqcdmvezrJ0Qb7h2xD6Kf
Content-Type: text/plain; name="tinderbox-www-aliases.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="tinderbox-www-aliases.diff"

Index: tinderbox/files/pkg-message.in
===================================================================
RCS file: /home/pcvs/ports/ports-mgmt/tinderbox/files/pkg-message.in,v
retrieving revision 1.16
diff -u -r1.16 pkg-message.in
--- tinderbox/files/pkg-message.in	24 Oct 2010 17:43:28 -0000	1.16
+++ tinderbox/files/pkg-message.in	15 Jul 2011 23:55:54 -0000
@@ -10,12 +10,12 @@
 
 - In your Apache configuration add the following lines:
 
-  Alias /tb/logs/ "%%PREFIX%%/tinderbox/logs/"
-  Alias /tb/packages/ "%%PREFIX%%/tinderbox/packages/"
-  Alias /tb/errors/ "%%PREFIX%%/tinderbox/errors/"
-  Alias /tb/wrkdirs/ "%%PREFIX%%/tinderbox/wrkdirs/"
-  Alias /tb/ "%%PREFIX%%/tinderbox/scripts/webui/"
-  <Directory "%%PREFIX%%/tinderbox/">
+  Alias /tb/logs "%%PREFIX%%/tinderbox/logs/"
+  Alias /tb/packages "%%PREFIX%%/tinderbox/packages/"
+  Alias /tb/errors "%%PREFIX%%/tinderbox/errors/"
+  Alias /tb/wrkdirs "%%PREFIX%%/tinderbox/wrkdirs/"
+  Alias /tb "%%PREFIX%%/tinderbox/scripts/webui/"
+  <Directory "%%PREFIX%%/tinderbox">
       Order allow,deny
       Allow from all
   </Directory>
@@ -25,11 +25,11 @@
 
 Turn on "mod_alias" and add the following lines:
 
-alias.url = (	"/tb/logs/" => "%%PREFIX%%/tinderbox/logs/",
-		"/tb/packages/" => "%%PREFIX%%/tinderbox/packages/",
-		"/tb/errors/" => "%%PREFIX%%/tinderbox/errors/",
-		"/tb/wrkdirs/" => "%%PREFIX%%/tinderbox/wrkdirs/",
-		"/tb/" => "%%PREFIX%%/tinderbox/scripts/webui/" )
+alias.url = (	"/tb/logs" => "%%PREFIX%%/tinderbox/logs/",
+		"/tb/packages" => "%%PREFIX%%/tinderbox/packages/",
+		"/tb/errors" => "%%PREFIX%%/tinderbox/errors/",
+		"/tb/wrkdirs" => "%%PREFIX%%/tinderbox/wrkdirs/",
+		"/tb" => "%%PREFIX%%/tinderbox/scripts/webui/" )
 dir-listing.activate = "enable"
 
 
Index: tinderbox-devel/files/pkg-message.in
===================================================================
RCS file: /home/pcvs/ports/ports-mgmt/tinderbox-devel/files/pkg-message.in,v
retrieving revision 1.16
diff -u -r1.16 pkg-message.in
--- tinderbox-devel/files/pkg-message.in	24 Oct 2010 17:44:03 -0000	1.16
+++ tinderbox-devel/files/pkg-message.in	15 Jul 2011 23:55:54 -0000
@@ -28,11 +28,11 @@
 
 - In your Apache configuration add the following lines:
 
-  Alias /tb/logs/ "%%PREFIX%%/tinderbox/logs/"
-  Alias /tb/packages/ "%%PREFIX%%/tinderbox/packages/"
-  Alias /tb/errors/ "%%PREFIX%%/tinderbox/errors/"
-  Alias /tb/wrkdirs/ "%%PREFIX%%/tinderbox/wrkdirs/"
-  Alias /tb/ "%%PREFIX%%/tinderbox/scripts/webui/"
+  Alias /tb/logs "%%PREFIX%%/tinderbox/logs/"
+  Alias /tb/packages "%%PREFIX%%/tinderbox/packages/"
+  Alias /tb/errors "%%PREFIX%%/tinderbox/errors/"
+  Alias /tb/wrkdirs "%%PREFIX%%/tinderbox/wrkdirs/"
+  Alias /tb "%%PREFIX%%/tinderbox/scripts/webui/"
   <Directory "%%PREFIX%%/tinderbox/">
       Order allow,deny
       Allow from all
@@ -42,11 +42,11 @@
 
 Turn on "mod_alias" and add the following lines:
 
-alias.url = (	"/tb/logs/" => "%%PREFIX%%/tinderbox/logs/",
-		"/tb/packages/" => "%%PREFIX%%/tinderbox/packages/",
-		"/tb/errors/" => "%%PREFIX%%/tinderbox/errors/",
-		"/tb/wrkdirs/" => "%%PREFIX%%/tinderbox/wrkdirs/",
-		"/tb/" => "%%PREFIX%%/tinderbox/scripts/webui/" )
+alias.url = (	"/tb/logs" => "%%PREFIX%%/tinderbox/logs/",
+		"/tb/packages" => "%%PREFIX%%/tinderbox/packages/",
+		"/tb/errors" => "%%PREFIX%%/tinderbox/errors/",
+		"/tb/wrkdirs" => "%%PREFIX%%/tinderbox/wrkdirs/",
+		"/tb" => "%%PREFIX%%/tinderbox/scripts/webui/" )
 dir-listing.activate = "enable"
How-To-Repeat: 	Install Tinderbox, and try to access webui with http://host/tb without a trailing slash.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-07-16 01:10:21 UTC
Responsible Changed
From-To: freebsd-ports-bugs->itetcu

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2011-07-18 16:58:52 UTC
Hi,

FYI, I suggest to remove the trailing slash of both alias and directory.
On my box, it is:

    Alias /tinderbox/errors   "/usr/local/www/tinderbox/errors"
    Alias /tinderbox/logs     "/usr/local/www/tinderbox/logs"
    Alias /tinderbox/packages "/usr/local/www/tinderbox/packages"
    Alias /tinderbox/wrkdirs  "/usr/local/www/tinderbox/wrkdirs"
    Alias /tinderbox          "/usr/local/www/tinderbox/scripts/webui"

Regards,
sunpoet
Comment 3 Chris Rees freebsd_committer freebsd_triage 2011-07-18 17:21:51 UTC
On 18 Jul 2011 16:59, "Sunpoet Po-Chuan Hsieh" <sunpoet@freebsd.org> wrote:
>
> Hi,
>
> FYI, I suggest to remove the trailing slash of both alias and directory.
> On my box, it is:
>
>    Alias /tinderbox/errors   "/usr/local/www/tinderbox/errors"
>    Alias /tinderbox/logs     "/usr/local/www/tinderbox/logs"
>    Alias /tinderbox/packages "/usr/local/www/tinderbox/packages"
>    Alias /tinderbox/wrkdirs  "/usr/local/www/tinderbox/wrkdirs"
>    Alias /tinderbox          "/usr/local/www/tinderbox/scripts/webui"
>

Works for me too!

Chris
Comment 4 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2011-08-04 11:04:21 UTC
State Changed
From-To: open->closed

let's keep the aliases cannonical.