Bug 159365

Summary: [patch] mail/p5-Mail-SpamAssassin: fix WITH_AWL option, add option WITHOUT_FREEMAIL
Product: Ports & Packages Reporter: Jason Helfman <jhelfman>
Component: Individual Port(s)Assignee: Chris Rees <crees>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Jason Helfman 2011-08-01 22:20:09 UTC 
AWL is not defined by default in the rules, so sed syntax needs to change. (WITH_AWL)
Added a new option to disable a rule in v330. (WITHOUT_FREEMAIL)
Builds and patches as expected cleanly in Tinderbox, and results are clean in resulting package.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-08-01 22:20:24 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->perl

perl@ wants this port PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-08-01 22:20:27 UTC 
Maintainer of mail/p5-Mail-SpamAssassin,

Please note that PR ports/159365 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/159365

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2011-08-01 22:20:29 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Chris Rees freebsd_committer freebsd_triage 2011-08-11 18:30:51 UTC 
Responsible Changed
From-To: perl->crees

I'll take it.
Comment 5 Michael Scheidell 2011-08-15 14:46:55 UTC 
Please do not apply patch.
AWL was deprecated several versions back (the SED actually does NOTHING, 
since the plugin is not loaded anymore by default)

other patch for option for FREEMAIL: not going to be supported.

it is just an option to change a config file. it does not add 
dependencies, remove dependencies, or change compile time options.  It 
changes nothing specific for freebsd.

there are in fact, 39  *.pre options that could be changed but, again, 
since these options don't change any dependencies, or compile time 
options, all they would do would be to crowd the make config page.

grep loadplugin *.pre | wc -l
       39

some of these options do require other dependencies, and do require 
doing something other than editing a config file.



-- 
Michael Scheidell, CTO
o: 561-999-5000
d: 561-948-2259
 >*| *SECNAP Network Security Corporation

    * Best Mobile Solutions Product of 2011
    * Best Intrusion Prevention Product
    * Hot Company Finalist 2011
    * Best Email Security Product
    * Certified SNORT Integrator

______________________________________________________________________
This email has been scanned and certified safe by SpammerTrap(r). 
For Information please see http://www.secnap.com/products/spammertrap/
______________________________________________________________________
Comment 6 Chris Rees 2011-08-15 18:05:36 UTC 
Mind if I remove the AWL OPTION then if it's not there any more?

Chris

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
Comment 7 Jason 2011-08-15 18:08:11 UTC 
On Mon, Aug 15, 2011 at 09:46:55AM -0400, Michael Scheidell thus spake:
>Please do not apply patch.
>AWL was deprecated several versions back (the SED actually does NOTHING,
>since the plugin is not loaded anymore by default)
>
>other patch for option for FREEMAIL: not going to be supported.
>
>it is just an option to change a config file. it does not add
>dependencies, remove dependencies, or change compile time options.  It
>changes nothing specific for freebsd.
>
>there are in fact, 39  *.pre options that could be changed but, again,
>since these options don't change any dependencies, or compile time
>options, all they would do would be to crowd the make config page.
>
>grep loadplugin *.pre | wc -l
>       39
>
>some of these options do require other dependencies, and do require
>doing something other than editing a config file.
>
>
>
>-- 
>Michael Scheidell, CTO
>o: 561-999-5000
>d: 561-948-2259
> >*| *SECNAP Network Security Corporation
>
>    * Best Mobile Solutions Product of 2011
>    * Best Intrusion Prevention Product
>    * Hot Company Finalist 2011
>    * Best Email Security Product
>    * Certified SNORT Integrator
>

No worries. Thanks for considering it, and for the information regarding
AWL.

I was going to make a local port, and was wondering if you would object to
moving PKGNAMEPREFIX= p5- => PKGNAMEPREFIX?= p5-

If others want to submit slave ports to enable or disable options that
aren't handled in your port, it would support this effort.

Thanks so much,
Jason

-- 
Jason Helfman
System Administrator
experts-exchange.com
http://www.experts-exchange.com/M_4830110.html
E4AD 7CF1 1396 27F6 79DD  4342 5E92 AD66 8C8C FBA5
Comment 8 Michael Scheidell 2011-08-15 18:20:57 UTC 
jeff wanted to know if I could make a minor mod for him to support slave 
ports.
I will look at it. it might help the *ja port also.

give me some time to look at it.



On 8/15/11 1:05 PM, Chris Rees wrote:
> Mind if I remove the AWL OPTION then if it's not there any more?
>
> Chris
>

-- 
Michael Scheidell, CTO
o: 561-999-5000
d: 561-948-2259
 >*| *SECNAP Network Security Corporation

    * Best Mobile Solutions Product of 2011
    * Best Intrusion Prevention Product
    * Hot Company Finalist 2011
    * Best Email Security Product
    * Certified SNORT Integrator


______________________________________________________________________
This email has been scanned and certified safe by SpammerTrap(r). 
For Information please see http://www.secnap.com/products/spammertrap/
______________________________________________________________________
Comment 9 Chris Rees 2011-08-25 18:54:56 UTC 
Hi Michael,

Would you be happy with me modifying the PORTNAME etc to ?=?

It certainly wouldn't affect how the port works in any way if the port 
is used normally.

Chris

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
Comment 10 Jason 2011-08-25 20:47:23 UTC 
On Thu, Aug 25, 2011 at 06:54:56PM +0100, Chris Rees thus spake:
>Hi Michael,
>
>Would you be happy with me modifying the PORTNAME etc to ?=?
>
>It certainly wouldn't affect how the port works in any way if the port
>is used normally.
>
>Chris
>

I have made this work locally by only modifying the PKGNAMEPREFIX to read:

PKGNAMEPREFIX?=	p5-

Obviously, more can be changed.

-jgh

-- 
Jason Helfman
System Administrator
experts-exchange.com
http://www.experts-exchange.com/M_4830110.html
E4AD 7CF1 1396 27F6 79DD  4342 5E92 AD66 8C8C FBA5
Comment 11 Michael Scheidell 2011-08-29 16:22:32 UTC 
please close.

superseded by

http://www.freebsd.org/cgi/query-pr.cgi?pr=160282


-- 
Michael Scheidell, CTO
o: 561-999-5000
d: 561-948-2259
 >*| *SECNAP Network Security Corporation

    * Best Mobile Solutions Product of 2011
    * Best Intrusion Prevention Product
    * Hot Company Finalist 2011
    * Best Email Security Product
    * Certified SNORT Integrator

______________________________________________________________________
This email has been scanned and certified safe by SpammerTrap(r). 
For Information please see http://www.secnap.com/products/spammertrap/
______________________________________________________________________
Comment 12 Chris Rees freebsd_committer freebsd_triage 2011-08-29 16:44:24 UTC 
State Changed
From-To: feedback->closed

Superseded by ports/160282