Bug 159525

Comment 1 Tilman Keskinoz 2011-08-07 16:41:03 UTC

State Changed
From-To: open->feedback

The port leaves behind orig files: 

==>   Deinstalling xpi-jslib-0.1.367 
pkg_delete: unable to completely remove directory '/usr/local/lib/xpi/{DF8E5247-8E0A-4de6-B393-0735A39DFD80}' 
pkg_delete: couldn't entirely delete package (perhaps the packing list is 
incorrectly specified?) 
direk% find /usr/local/lib/xpi/{DF8E5247-8E0A-4de6-B393-0735A39DFD80} 
/usr/local/lib/xpi/{DF8E5247-8E0A-4de6-B393-0735A39DFD80} 
/usr/local/lib/xpi/{DF8E5247-8E0A-4de6-B393-0735A39DFD80}/install.rdf.orig

Comment 2 Steve Wills 2011-08-14 04:11:25 UTC

Responsible Changed
From-To: freebsd-ports-bugs->swills

I'll take it.

Comment 3 Steve Wills 2011-08-14 04:29:49 UTC

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

The attached patch should solve the leftover file issue. Do you approve?

Steve

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (FreeBSD)

iQEcBAEBAgAGBQJOR0EtAAoJEPXPYrMgexuhnWkH+QFoHLyvx0677IOyCMQLYqdZ
SZSS4kz729RAbiXqTy543EZNfYYbhnvCqFqdUhOuljYBAvtTAFzP/Ng+FIi9wUA8
xZyI6sCjMFDYRgy3A//MouPRK1bQrUUgbtNe4zbZ2dx9NDgcATXeX7sCUSwKwk/n
2CqTS+jA1Xt35UxYdmcNJGwjK5RdrN6KVwv920wuxRF4nOcd8MoxArjOOZkMlsTg
r1/IUBYyQf3OiMRXokXGTXJXDqkUl57zv0mvTpxbYDJx0spUG00q6x1E56kQsqL+
iiwvPQBrGmVaKrr+NkW069FmotFhe/CG3Bb6tmogsh1oXA5dDiEi4Dcd2Xos5rg=
=DFV1
-----END PGP SIGNATURE-----

I approve indeed, thanks for that patch.

Whoops. No, sorry, that patch doesn't work for a couple of reasons:
"patch -n" means to use a normal diff instead of a unified diff;
PATCH_ARGS can't be used since it's using ?= in base mk file, thus
losing all other options.
I attach a different complete patch (which also forces suport for
SeaMonkey 2.3), please ignore the previous ones.

Comment 6 Steve Wills 2011-09-09 02:05:00 UTC

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

On 09/08/11 04:03, Lapo Luchini wrote:
> Whoops. No, sorry, that patch doesn't work for a couple of reasons:
> "patch -n" means to use a normal diff instead of a unified diff;
> PATCH_ARGS can't be used since it's using ?= in base mk file, thus
> losing all other options.
> I attach a different complete patch (which also forces suport for
> SeaMonkey 2.3), please ignore the previous ones.
> 

This builds clean for me in tinderbox. I notice there's a newer version
out now though. Would you like to get the newer version included as well
or should I go ahead with committing this?

Thanks,
Steve
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (FreeBSD)

iQEcBAEBAgAGBQJOaWY8AAoJEPXPYrMgexuhoUUH/2JeVa5EGG/O7TfgAd6sV6pe
XeSZ2jJjEZFV3yViFPY/bx+/PyWIRVv6McmgH99FcDYSDN9j2qGvWRqsP5hjAjR4
01rhMqe4AUGvHSpXmm3/k9h1VmzEZDEPsqZVWfjBj6FhFad+jm/wqGl/mMwF3C7w
n8VptTxsK+Q7P7cX+J8XZ9AWGgBbDdYpOTLOfc+d4ctVWWN2FZj8dt5LcP+rKfqN
4uJMGJr+RvSR4c6byTp425eopqYAsgO4VgDJVF+8zehnkFY5TxN6JSGaKTwFpMDr
9AhFh5iCpmjhutWG97rliAvWlFtfmXjmKKD6GRxe1OeqXXLcJHwRRHhB/ASYGmQ=
=N4tz
-----END PGP SIGNATURE-----

While at it, I changed the file-patch to a sed-oneliner. :)

Comment 8 dfilter service 2011-09-09 23:36:28 UTC

swills      2011-09-09 22:36:14 UTC

  FreeBSD ports repository

  Modified files:
    www/xpi-jslib        Makefile distinfo 
  Log:
  - Update to 0.1.370
  
  PR:             ports/159525
  Submitted by:   Lapo Luchini <lapo@lapo.it> (maintainer)
  
  Revision  Changes    Path
  1.4       +8 -4      ports/www/xpi-jslib/Makefile
  1.3       +2 -2      ports/www/xpi-jslib/distinfo
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"

Comment 9 Steve Wills 2011-09-09 23:37:33 UTC

State Changed
From-To: feedback->closed

Committed. Thanks!