Bug 159605
| Summary: | Change port version: deskutils/x-tile A tiling application for X | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Scrootie <sawp> | ||||||||
| Component: | Individual Port(s) | Assignee: | Chris Rees <crees> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | ||||||||||
| Priority: | Normal | ||||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Scrootie
2011-08-08 16:40:09 UTC
Responsible Changed From-To: freebsd-bugs->freebsd-ports-bugs Fix category and synopsis. Hi, Pedro. Please review this patch. It fixes plist issues in your patch and some other changes added too: - make official mastersite first in the list - add license - remove PYDISTUTILS_EGGINFO. PKGNAME is sufficient. - remove stale reinplace - fix /usr/share paths in the code - respect WITHOUT_NLS (little bit hacky) - use DATADIR instead of share/x-tile Checked build and runtime is fine. tinderbuild log on 8.2: http://happy-nation.by.ru/ports/tb/8.2/x-tile-2.1.log -- Regards, Ruslan Tinderboxing kills... the drives. Responsible Changed From-To: freebsd-ports-bugs->crees I'll take it. And by the way, i just see that official distfile and distfile hosted by you are different. Here is the changes: http://happy-nation.by.ru/ports/x-tile.changes.diff.txt They only deal with path changing that i already did in the patch. The last change is to fix ctypes warning, that can be eliminated with patch like this in port's files subdirectory. -- Regards, Ruslan Tinderboxing kills... the drives. sawp@sawp.com.br wrote on 22.08.2011 23:29: > You are correct. The only differences consist of this path > problems. It would be better to download the tarball from official site > and apply your patch. But I dont know how to do it just using the ports > Makefile. I tried to put the modified files in the 'files/' directory > and rename the files to patch-modules-cons.py and patch-x-tile > (patch-x--tile too). It doesn't works. It's needed to put __patches__ into files/, not the modified files. You can place patch-x-tile into files/ on your system and check that it indeed working. So, do you approve the patch? Please keep bug-followup@FreeBSD.org in cc:. -- Regards, Ruslan Tinderboxing kills... the drives. The patch works fine here. The installation and uninstallation also are working right on my system. It's OK for me. On Tue, 23 Aug 2011 10:37:57 +0400, Ruslan Mahmatkhanov wrote: > sawp@sawp.com.br [1]wrote on 22.08.2011 23:29: > >> You are correct. The only differences consist of this path problems. It would be better to download the tarball from official site and apply your patch. But I dont know how to do it just using the ports Makefile. I tried to put the modified files in the 'files/' directory and rename the files to patch-modules-cons.py and patch-x-tile (patch-x--tile too). It doesn't works. > > It's needed to put __patches__ into files/, not the modified files. You > can place patch-x-tile into files/ on your system and check that it > indeed working. So, do you approve the patch? Please keep > bug-followup@FreeBSD.org [2] in cc:. Links: ------ [1] mailto:sawp@sawp.com.br [2] mailto:bug-followup@FreeBSD.org Hi Ruslan, Sorry I've just rediscovered this -- I didn't parse Pedro's approval properly because the message was a little munged. Your server hosting the patch I need to use appears to be down... Please would you investigate? Chris -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean. Hi Chris Chris Rees wrote on 29.08.2011 14:48: > Hi Ruslan, > > Sorry I've just rediscovered this -- I didn't parse Pedro's approval > properly because the message was a little munged. > > Your server hosting the patch I need to use appears to be down... Please > would you investigate? > > Chris Sorry, can't do anything with it - it's a free hosting :(. Anyway the patch that contains fixes and actually updates x-tile is there: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports%2F159605&getpatch=2 And patch that will fix warning, is there (it should be placed to files/ subdir): http://www.freebsd.org/cgi/query-pr.cgi?pr=ports%2F159605&getpatch=3 The diff that is on happy-nation.by.ru - it just differences between official tarball and Pedro's distributed tarball, and all the changes is in path handling (usr/share vs /usr/local/share) that i already do with reinplaces in Makefile. -- Regards, Ruslan Tinderboxing kills... the drives. State Changed From-To: open->analyzed Taken for Tinderbox run. crees 2011-08-31 11:43:08 UTC
FreeBSD ports repository
Modified files:
deskutils/x-tile Makefile distinfo pkg-plist
Added files:
deskutils/x-tile/files patch-x-tile
Log:
PR: ports/159605
Submitted by: Pedro Garcia Freitas <sawp@sawp.com.br> (maintainer), Ruslan Mahmatkhanov <cvs-src@yandex.ru>
Revision Changes Path
1.2 +19 -4 ports/deskutils/x-tile/Makefile
1.2 +2 -2 ports/deskutils/x-tile/distinfo
1.1 +15 -0 ports/deskutils/x-tile/files/patch-x-tile (new)
1.2 +43 -44 ports/deskutils/x-tile/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: analyzed->closed Committed. Thanks! |
