Bug 159727

Summary: [PATCH] audio/last.fm doesn't compile using clang
Product: Ports & Packages Reporter: Norberto Lopes <nlopes.ml>
Component: Individual Port(s)Assignee: Tilman Keskinoz <arved>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Norberto Lopes 2011-08-12 20:00:19 UTC
When trying to compile last.fm using clang it errors out.

Fix: Patch attached


Patch attached with submission follows:
How-To-Repeat: Define compiler variables in order to compile in clang:

.if !defined(CC) || ${CC} == "cc"
CC=clang
.endif
.if !defined(CXX) || ${CXX} == "c++"
CXX=clang++
.endif
.if !defined(CPP) || ${CPP} == "cpp"
CPP=clang -E
.endif
NO_WERROR=
WERROR=


cd /usr/ports/audio/last.fm && make clean && make
Comment 1 Chris Rees freebsd_committer freebsd_triage 2011-08-12 20:39:29 UTC
Responsible Changed
From-To: freebsd-ports-bugs->crees

I'll take it.
Comment 2 Chris Rees freebsd_committer freebsd_triage 2011-08-12 20:53:29 UTC
Responsible Changed
From-To: crees->arved

Oops, too keen there, this is for you!
Comment 3 Chris Rees 2011-08-12 20:55:45 UTC
Thanks for the patch, but in future please make sure you put
audio/last.fm in the synopsis so Edwin's bot can tell who the PR belongs to!

Chris

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
Comment 4 dfilter service freebsd_committer freebsd_triage 2011-08-28 16:40:48 UTC
arved       2011-08-28 15:40:37 UTC

  FreeBSD ports repository

  Added files:
    audio/last.fm/files  patch-src-libUnicorn-Settings.h 
  Log:
  Add a patch to make compile with clang get further
  
  PR:             159727
  Submitted by:   Norberto Lopes <nlopes.ml@gmail.com>
  
  Revision  Changes    Path
  1.1       +11 -0     ports/audio/last.fm/files/patch-src-libUnicorn-Settings.h (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Tilman Keskinoz freebsd_committer freebsd_triage 2011-08-28 16:40:55 UTC
State Changed
From-To: open->closed

Committed, thanks. 

But it this not compile with clang for me now, i get 

clang++ -c -include ../build/last.fm/release/last.fm -pipe -O2 -w -DNBREAKPAD -D 
QT_NO_DEBUG -DQT_SQL_LIB -DQT_XML_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LI 
B -DQT_SHARED -I/usr/local/share/qt4/mkspecs/freebsd-clang -I. -I/usr/local/incl 
ude/qt4/QtCore -I/usr/local/include/qt4/QtNetwork -I/usr/local/include/qt4/QtGui 
-I/usr/local/include/qt4/QtXml -I/usr/local/include/qt4/QtSql -I/usr/local/incl 
ude/qt4 -Ilib -IlibFingerprint/recommendation-commons -I. -I../build -IlibMoose  
-IlibUnicorn -I../res/mad -IlibFingerprint/libs/fftw -I../build/last.fm/release -I../build -I/usr/local/include -o ../build/last.fm/release/container.o container.cpp   
error: input is not a PCH file: '../build/last.fm/release/last.fm.gch'