Bug 159977

Summary: news/inn doesn't package its examples
Product: Ports & Packages Reporter: hag <hag>
Component: Individual Port(s)Assignee: Alberto Villa <avilla>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description hag 2011-08-22 00:00:23 UTC
    The inn package doesn't package most of the contents of
share/examples/inn, but attempts to use them in exec/unexec portions
of the package list, producing errors for binary package installations
on systems where there is no existing configuration in
/usr/local/news/etc.  Users looking for an example configuration
installed by the package won't find one.

    There are some indications of intent here, but I can't figure out
what it was: with the fix below, the plist line 

@unexec for f in %%ETCFILES%%; do rm -f %D/%%EXAMPLESDIR%%/${f}; done

    is presumably redundant.  However, the ETCFILES don't exist in the
package at all, so I'm a bit puzzled how this line did anything
useful previously.

Fix: Apply patch below, and rebuild package.
How-To-Repeat: 
$ pkg_add inn-2.4.6_1.tbz
===>  Checking for old database files
cp: /usr/local/share/examples/inn/actsync.cfg: No such file or directory
cp: /usr/local/share/examples/inn/actsync.ign: No such file or directory
cp: /usr/local/share/examples/inn/buffindexed.conf: No such file or directory
[ more along these lines ]
pkg_add: command 'for f in actsync.cfg actsync.ign buffindexed.conf control.ctl cycbuff.conf  distrib.pats expire.ctl incoming.conf inn.conf innfeed.conf  innreport.conf innwatch.ctl moderators motd.news news2mail.cf  newsfeeds nnrpd.track nntpsend.ctl ovdb.conf overview.fmt  passwd.nntp radius.conf readers.conf sasl.conf storage.conf  subscriptions; do [ -f /usr/local/news/etc/${f} ] || cp -fp /usr/local/share/examples/inn/${f} /usr/local/news/etc/${f}; done' failed
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-08-22 00:00:33 UTC
Responsible Changed
From-To: freebsd-ports-bugs->fluffy

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Alberto Villa freebsd_committer freebsd_triage 2012-01-24 12:01:56 UTC
Responsible Changed
From-To: fluffy->avilla

I'll take it (maintainer timeout).
Comment 3 dfilter service freebsd_committer freebsd_triage 2012-01-24 12:05:59 UTC
avilla      2012-01-24 12:05:45 UTC

  FreeBSD ports repository

  Modified files:
    news/inn             Makefile pkg-plist 
  Log:
  - Fix plist.
  - Bump PORTREVISION.
  
  The port didn't package most of the contents of share/examples/inn,
  but attempted to use them in exec/unexec portions of the package list,
  producing errors for binary package installations.
  
  PR:             159977 [1]
  PR:             155436
  Submitted by:   hag@linnaean.org [1]
  Approved by:    fluffy (maintainer timeout)
  
  Revision  Changes    Path
  1.96      +1 -1      ports/news/inn/Makefile
  1.27      +27 -1     ports/news/inn/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Alberto Villa freebsd_committer freebsd_triage 2012-01-24 12:06:28 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!