Bug 16017

Summary: BitchX IRC client upgrade to 1.0c15
Product: Ports & Packages Reporter: calle.madestrand <calle.madestrand>
Component: Individual Port(s)Assignee: freebsd-ports (Nobody) <ports>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description calle.madestrand 2000-01-09 22:00:01 UTC
Files to be added and removed:
add /usr/ports/irc/bitchx/files/bitchxrc                                      
add /usr/ports/irc/bitchx/files/bxsetup       
add /usr/ports/irc/bitchx/files/gtkbitchxrc                                    
add /usr/ports/irc/bitchx/files/gtkbxsetup
add /usr/ports/irc/bitchx/files/plist.common
add /usr/ports/irc/bitchx/files/patch-ab
remove /usr/ports/irc/bitchx/patches/patch-ad
Comment 1 Bill Fumerola 2000-01-09 22:12:55 UTC
On Sun, 9 Jan 2000 calle.madestrand@norrgarden.se wrote:

> -# Version required:	75p3
> -# Date created:		26 Jan 1998
> -# Whom:			griffin
> +# Version required:	1.0c15
> +# Date created:		9 January 2000
> +# Whom:			LoRd_CJ

Date created and Whom are for the _original_ creator of the port.

>  #
>  # $FreeBSD: ports/irc/bitchx/Makefile,v 1.7 1999/08/25 06:12:35 obrien Exp $
> -#

No.

> +.if defined(GUI)
> +		${CP} ${FILESDIR}/plist.common ${PKGDIR}/PLIST
> +		${ECHO}	bin/gtkBitchX >> ${PKGDIR}/PLIST
> +		${ECHO} bin/gtkbxsetup >> ${PKGDIR}/PLIST
> +		${ECHO} share/bx/gtkbitchxrc >> ${PKGDIR}/PLIST
> +		${ECHO} lib/bx/plugins/nicklist.so >> ${PKGDIR}/PLIST
> +.else
> +		${CP} ${FILESDIR}/plist.common ${PKGDIR}/PLIST
> +		${ECHO} bin/BitchX >> ${PKGDIR}/PLIST
> +		${ECHO} bin/scr-bx >> ${PKGDIR}/PLIST
> +		${ECHO} bin/bxsetup >> ${PKGDIR}/PLIST
> +		${ECHO} lib/bx/wserv >> ${PKGDIR}/PLIST
> +		${ECHO} share/bx/bitchxrc >> ${PKGDIR}/PLIST
> +.endif
> +		${ECHO} @dirrm share/bx/translation >> ${PKGDIR}/PLIST
> +		${ECHO}	@dirrm share/bx/script >> ${PKGDIR}/PLIST
> +		${ECHO} @dirrm share/bx >> ${PKGDIR}/PLIST
> +		${ECHO} @dirrm share/doc/BitchX >> ${PKGDIR}/PLIST
> +		${ECHO} @dirrm lib/bx/plugins >> ${PKGDIR}/PLIST
> +		${ECHO} @dirrm lib/bx >> ${PKGDIR}/PLIST

I'm reasonably sure that ${PKGDIR} has to remain read-only during
package builds. There are better ways to do this.

> +++ /usr/home/cj/ports/bitchx/files/bitchxrc	Sat Jan  8 20:52:26 2000
> @@ -0,0 +1,2 @@
> +set LOAD_PATH ~/.BitchX:~/.BitchX/plugins:.:/usr/local/lib/bx/plugins:/usr/local/lib/bx:/usr/local/share/bx/script:/usr/local/share/bx
> +set BITCHX_HELP /usr/local/share/bx/BitchX.help

This doesn't respect ${PREFIX}

> diff -ruN /usr/ports/irc/bitchx/files/bxsetup /usr/home/cj/ports/bitchx/files/bxsetup
> --- /usr/ports/irc/bitchx/files/bxsetup	Thu Jan  1 01:00:00 1970
> +++ /usr/home/cj/ports/bitchx/files/bxsetup	Sat Jan  8 21:14:06 2000
> @@ -0,0 +1,13 @@
> +#!/bin/sh
> +
> +echo "Installing for user"
> +mv ~/.bitchxrc .bitchxrc~
> +echo "Backing up existing .bitchxrc"
> +cp /usr/local/share/bx/bitchxrc ~/.bitchxrc

${PREFIX}

> +set LOAD_PATH ~/.BitchX:~/.BitchX/plugins:.:/usr/local/lib/bx/plugins:/usr/local/lib/bx:/usr/local/share/bx/script:/usr/local/share/bx
> +set BITCHX_HELP /usr/local/share/bx/BitchX.help

${PREFIX}

> +load menu.bx
> \ No newline at end of file
> diff -ruN /usr/ports/irc/bitchx/files/gtkbxsetup /usr/home/cj/ports/bitchx/files/gtkbxsetup
> --- /usr/ports/irc/bitchx/files/gtkbxsetup	Thu Jan  1 01:00:00 1970
> +++ /usr/home/cj/ports/bitchx/files/gtkbxsetup	Sun Jan  9 14:18:51 2000
> @@ -0,0 +1,13 @@
> +#!/bin/sh
> +
> +echo "Installing for user"
> +mv ~/.bitchxrc .bitchxrc~
> +echo "Backing up existing .bitchxrc"
> +cp /usr/local/share/bx/gtkbitchxrc ~/.bitchxrc

${PREFIX}


etc..
Comment 2 alex 2000-01-10 13:52:12 UTC
Thus spake calle.madestrand@norrgarden.se (calle.madestrand@norrgarden.se):

... again.

> -# Version required:	75p3
> -# Date created:		26 Jan 1998
> -# Whom:			griffin
> +# Version required:	1.0c15
> +# Date created:		9 January 2000
> +# Whom:			LoRd_CJ

Do you want to annoy me?

>  #
>  # $FreeBSD: ports/irc/bitchx/Makefile,v 1.7 1999/08/25 06:12:35 obrien Exp $
> -#

why?

> +		@${ECHO_MSG} "***********************************"
> +		@${ECHO_MSG} " To compile with GTK type make GUI"
> +		@${ECHO_MSG} "***********************************"

You mean "type make GUI=yes", don't you?

Alex

-- 
I doubt, therefore I might be.
Comment 3 Jeroen Ruigrok van der Werven freebsd_committer freebsd_triage 2000-01-10 18:56:48 UTC
State Changed
From-To: open->closed

Superceded by PR 16029.