Bug 16023

Hi,

I'd like an idle time counter in sppp, just like ppp has.  The reason
for this is that i4b incorectly counts LCP control packets (like
LCP Echo-Request, and LCP Echo-Response) incorectly as "active" packets.

This can result in an idle PPP connection (no TCP/IP packets) which
stays indefinately open.

This is, of course, and i4b problem; However, to properly impliment a
fix for this, an idletime mechanism is required in the sppp stack.  I
stole the idea from ppp, and should be completely harmless -- I tested
them on 3.3-stable with no problems.  I'd be happy if the powers that be
could commit the patches below against 4.0-current.  :)

Thanks!
-Paul

Fix: Patches (patched against 4.0-current):

******** CUT HERE ***********
void
 print_vals(const char *ifname, struct spppreq *sp)
 {
+       time_t send, recv;
+
        printf("%s:\tphase=%s\n", ifname, phase_name(sp->defs.pp_phase));
        if (sp->defs.myauth.proto) {
                printf("\tmyauthproto=%s myauthname=\"%.*s\"\n",
                       proto_name(sp->defs.myauth.proto),
@@ -200,8 +202,11 @@   
                       proto_name(sp->defs.hisauth.proto),
                       AUTHNAMELEN, sp->defs.hisauth.name,
                       authflags(sp->defs.hisauth.flags));
        }
+       send = time(NULL) - sp->defs.pp_last_sent;
+       recv = time(NULL) - sp->defs.pp_last_recv;
+       printf("\tidle_time=%ld\n", (send<recv)? send : recv);
 }

 const char *
 phase_name(enum ppp_phase phase)
How-To-Repeat: The i4b problem can be repeated by just connecting (via ISDN) to a PPP
Server which decides to send contiunous LCP Packets in the background,

...but again this is not an sppp problem, but i4b that should (will) be
fixed later with the help of this patch.