Bug 160595

Summary:

x11/xset: missing dependencies

Product:

Ports & Packages

Reporter:

Jilles Tjoelker <jilles>

Component:

Individual Port(s)

Assignee:

Eitan Adler <eadler>

Status:

Closed FIXED

Severity:

Affects Only Me

Priority:

Normal

Version:

Latest

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
xset-deps.patch	none

Description Jilles Tjoelker freebsd_committer

2011-09-09 20:30:09 UTC

x11/xset depends on various libraries without declaring that in the port
Makefile.

In particular, this may cause portmaster to attempt to compile xset
against a too old version of xproto.

The modules xxf86misc and xfontcache are used iff they happen to be
present. This means that the centrally built packages do not have them
but a version built from ports will probably have them.

Fix: Add the missing dependencies to USE_XORG=.

The below patch assumes that xxf86misc and xfontcache are desired.
Alternatively, they could be disabled via configure options.
(xorg-server-1.7.7_2,1 does not appear to support xfontcache.)

The PORTREVISION should be bumped as well.
How-To-Repeat: Inspect the port Makefile and the configure.ac file.

Comment 1 Edwin Groothuis freebsd_committer

2011-09-09 20:30:21 UTC

Responsible Changed
From-To: freebsd-ports-bugs->freebsd-x11

Over to maintainer (via the GNATS Auto Assign Tool)

Comment 2 Eitan Adler freebsd_committer

2011-09-09 20:51:27 UTC

Responsible Changed
From-To: freebsd-x11->eadler

I'll take it.

Comment 3 dfilter service freebsd_committer

2011-09-11 00:05:15 UTC

eadler      2011-09-10 23:04:57 UTC

  FreeBSD ports repository

  Modified files:
    x11/xset             Makefile 
  Log:
  - forced commit to correct log
  - add deps unconditionally
  
  PR:             ports/160595
  Submitted by:   Jilles Tjoelker <jilles@stack.nl>
  Reviewed by:    kwm, nox
  Approved by:    bapt (mentor)
  
  Revision  Changes    Path
  1.8       +0 -0      ports/x11/xset/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"

Comment 4 Eitan Adler freebsd_committer

2011-09-11 00:09:57 UTC

State Changed
From-To: open->closed

Committed, requires PORTREVISION bump because the default package 
changes.