Bug 16070

Summary: [PATCH] Correct and improve HTTP support for sysinstall.
Product: Base System Reporter: un1i <un1i>
Component: miscAssignee: jkh
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 4.0-CURRENT   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description un1i 2000-01-11 22:00:01 UTC 
Some time ago, the layout in the FTP servers changed. This has to be
fixed in http.c. Also, there were cases (proy/server combinations)
that would result in corruption of those chunks, whose extension
(.ai, .cc, ...) made them look like text files.

Fix: The patch has these changes:

dist.c:
  This should catch all cases, were the combination of proxy, server
  ans extension leads to chunks treated as text files:
  Read each chunk completely into a buffer and compare its length to its
  length as given in <distribution>.inf. If they differ, substitute all
  CRLFs with LF.
  Doing this in distExtract() is easier than in mediaGetHTTP, and it also
  might help when you install from DOS or UFS and previously fetched the
  files via a proxy.

http.c:
  Use the correct FTP path. Adjust the indentation.
 
media.c:
  Slightly reduce verbosity.

sysinstall.8:
  Add a paragraph about mediaSetHTTP.


How-To-Repeat: 
Install a distribution with at least 9 chunks (so that one has the
extension .ai) via a proxy other than a Squid.
Comment 1 Sheldon Hearn freebsd_committer freebsd_triage 2000-01-12 15:38:59 UTC 
Responsible Changed
From-To: freebsd-bugs->jkh

Over to Mr. Sysinstall.
Comment 2 jkh freebsd_committer freebsd_triage 2000-01-25 05:54:47 UTC 
State Changed
From-To: open->closed

Patch adopted, thanks.