Bug 161181

Summary: [patch] editors/emacs-devel: don't depend on pty(4), use openpty(3)
Product: Ports & Packages Reporter: Nali Toja <nalitoja>
Component: Individual Port(s)Assignee: Ashish SHUKLA <ashish>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
use_openpty.diff none

Description Nali Toja 2011-10-01 08:10:06 UTC 

Fix: copied from src/s/darwin.h
How-To-Repeat: 1. compile kernel without pty(4)
2. try to use tramp, it'd hang

And if you load pty.ko the kernel would print

  pid 1234 (emacs) is using legacy pty devices - not logging anymore
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-10-01 08:10:21 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->ashish

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Nali Toja 2011-10-01 08:37:43 UTC 
While emacs links with -lutil on FreeBSD it doesn't include
<libutil.h>. Until this issue I haven't even noticed

  $ gcc -std=gnu99 ... -Wimplicit-function-declaration ... process.c
  process.c: In function 'allocate_pty':
  process.c:564: warning: implicit declaration of function 'openpty'

--- include_libutil.h.diff begins here ---
=== modified file 'configure.in'
--- configure.in	2011-09-26 18:38:31 +0000
+++ configure.in	2011-10-01 07:29:29 +0000
@@ -1216,7 +1216,7 @@
   linux/version.h sys/systeminfo.h \
   stdio_ext.h fcntl.h coff.h pty.h sys/mman.h \
   sys/vlimit.h sys/resource.h locale.h sys/_mbstate_t.h \
-  sys/utsname.h pwd.h utmp.h dirent.h util.h)
+  sys/utsname.h pwd.h utmp.h dirent.h util.h libutil.h)
 
 AC_MSG_CHECKING(if personality LINUX32 can be set)
 AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <sys/personality.h>]], [[personality (PER_LINUX32)]])],
=== modified file 'src/process.c'
--- src/process.c	2011-09-09 01:06:52 +0000
+++ src/process.c	2011-10-01 07:27:40 +0000
@@ -83,6 +83,10 @@
 #include <util.h>
 #endif
 
+#ifdef HAVE_LIBUTIL_H
+#include <libutil.h>
+#endif
+
 #ifdef HAVE_PTY_H
 #include <pty.h>
 #endif
--- include_libutil.h.diff ends here ---
Comment 3 Ashish SHUKLA freebsd_committer freebsd_triage 2011-10-01 22:09:48 UTC 
Hi,

Thanks for the diff. Could you please submit this diff upstream, if not submit
already. I'll include it in next update.

-- 
Ashish SHUKLA      | GPG: F682 CDCC 39DC 0FEA E116  20B6 C746 CFA9 E74F A4B0
freebsd.org!ashish | http://people.freebsd.org/~ashish/

Avoid Success At All Costs !!
Comment 4 dfilter service freebsd_committer freebsd_triage 2011-10-17 05:55:40 UTC 
ashish      2011-10-17 04:55:31 UTC

  FreeBSD ports repository

  Modified files:
    editors/emacs-devel  Makefile distinfo 
    editors/emacs-devel/files patch-configure.in 
  Added files:
    editors/emacs-devel/files patch-src_process.c 
                              patch-src_s_freebsd.h 
  Log:
  - Update to bzr revision 106087
  - Fix detection of 'make' program in use in configure script[1]
  - Use openpty(3) instead of deprecated pty(4) interface[2]
  - Add patch to interrupt `debug-on-quit' during loops[3]
  - Track ncurses dependency[4]
  
  PR:             ports/160986[1], ports/161181[2], ports/161220[3], ports/161497[4]
  Submitted by:   h h <aakusta@gmail.com>[1], Nali Toja <nalitoja@gmail.com>[2][3][4]
  
  Revision  Changes    Path
  1.58      +2 -2      ports/editors/emacs-devel/Makefile
  1.31      +2 -2      ports/editors/emacs-devel/distinfo
  1.9       +20 -2     ports/editors/emacs-devel/files/patch-configure.in
  1.1       +16 -0     ports/editors/emacs-devel/files/patch-src_process.c (new)
  1.1       +25 -0     ports/editors/emacs-devel/files/patch-src_s_freebsd.h (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Ashish SHUKLA freebsd_committer freebsd_triage 2011-10-17 12:22:46 UTC 
State Changed
From-To: open->closed

Committed. Thanks!