Summary: | [libstdc++] [patch] Use FreeBSD's atomic.h if no cpu-specific code is available | ||||||
---|---|---|---|---|---|---|---|
Product: | Base System | Reporter: | Ian Lepore <freebsd> | ||||
Component: | gnu | Assignee: | freebsd-bugs (Nobody) <bugs> | ||||
Status: | Closed Overcome By Events | ||||||
Severity: | Affects Only Me | CC: | ed, ian | ||||
Priority: | Normal | ||||||
Version: | 8.2-STABLE | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Ian Lepore
2011-10-11 20:40:08 UTC
We now have a sys/stdatomic.h; I don't think we need such workarounds in libstdc++. In any case, all tier1 platforms have moved away from libstdc++ into libc++ so if there are issues they should be treated upstream. Yes. This could easily be built around C11's <stdatomic.h>, which on FreeBSD works on all supported platforms. Please don't use any of the BSD specific atomics APIs in new code. I can't believe anybody is wasting their time addressing this. Where was everybody 5 years ago when this mattered? Even by time I became a commiter myself this had already become moot and I had completely forgotten about it. Every once in a while various committers go through to try to clean up the stale PRs. (I have spent time doing that; see below.) It's just necessary work that Someone (TM) needs to do. There are various theories of how to go about this. One that I particularly *dis*like is simply to close ones that are older than N months. My feeling is that it just frustrates submitters. In addition, some of the open bugs are still valid. Of course we still need to figure out a methodology to flag PRs for applicability and non-staleness. OTOH I myself am not in a position to work on that at this time. The reason I am addressing your reply is that IMVHO it is counter-productive. I have received similar replies when I have attempted to triage old PRs in the past. It has tended to demotivate me to continue doing that, and working through PRs is frustrating enough as it is. |