Bug 161517
| Summary: | [patch] graphics/py-imaging: track lcms dep | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Nali Toja <nalitoja> | ||||
| Component: | Individual Port(s) | Assignee: | Pawel Pekala <pawel> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | ||||||
| Priority: | Normal | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Maintainer of graphics/py-imaging,
Please note that PR ports/161517 has just been submitted.
If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.
The full text of the PR can be found at:
http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/161517
--
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool) On 10/12/11 2:10 PM, Edwin Groothuis wrote: > Maintainer of graphics/py-imaging, > > Please note that PR ports/161517 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/161517 > I approve the patch. Geoff State Changed From-To: feedback->open Maintainer approved. Responsible Changed From-To: freebsd-ports-bugs->pawel I'll take it. pawel 2011-10-18 17:48:11 UTC
FreeBSD ports repository
Modified files:
graphics/py-imaging Makefile pkg-plist
Log:
Add permanent dependency on graphics/lcms to fix missing dep and plist when
said package is installed
PR: ports/161517
Submitted by: Nali Toja <nalitoja@gmail.com>
Approved by: maintainer
Revision Changes Path
1.36 +2 -0 ports/graphics/py-imaging/Makefile
1.13 +1 -0 ports/graphics/py-imaging/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks! |
LittleCMS support was added in 1.1.7. A quick diff of the build glue should have revealed it. lcms is also mentioned in CHANGES file. $ diff -uw Imaging-1.1.[67]/setup.py [...] @@ -247,6 +264,10 @@ class pil_build_ext(build_ext): if dir: add_directory(self.compiler.include_dirs, dir, 0) + if find_include_file(self, "lcms.h"): + if find_library_file(self, "lcms"): + feature.lcms = "lcms" + if _tkinter and find_include_file(self, "tk.h"): # the library names may vary somewhat (e.g. tcl84 or tcl8.4) version = TCL_VERSION[0] + TCL_VERSION[2] @@ -302,6 +323,14 @@ class pil_build_ext(build_ext): "_imagingtiff", ["_imagingtiff.c"], libraries=["tiff"] )) + if os.path.isfile("_imagingcms.c") and feature.lcms: + extra = [] + if sys.platform == "win32": + extra.extend(["user32", "gdi32"]) + exts.append(Extension( + "_imagingcms", ["_imagingcms.c"], libraries=["lcms"] + extra + )) + if sys.platform == "darwin": # locate Tcl/Tk frameworks frameworks = [] How-To-Repeat: 1. install graphics/lcms 2. install/deinstall the port $ make install deinstall ===> Deinstalling for graphics/py-imaging ===> Deinstalling py27-imaging-1.1.7 pkg_delete: unable to completely remove directory '/usr/local/lib/python2.7/site-packages/PIL' pkg_delete: couldn't entirely delete package `py27-imaging-1.1.7' $ ls /usr/local/lib/python2.7/site-packages/PIL _imagingcms.so