Bug 16155

Summary: cp -p does not preserve modification time with msdos-fs
Product: Base System Reporter: Fritz Heinrichmeyer <jfh>
Component: binAssignee: freebsd-bugs (Nobody) <bugs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 4.0-CURRENT   
Hardware: Any   
OS: Any   

Description Fritz Heinrichmeyer 2000-01-17 09:10:01 UTC
	cp -p of files does not preserve modification time with copying
	from ufs to msdosfs.
	cp -p works ok with ufs ufs copies.

Fix: 

use cpio, tar etc. to do the job.
How-To-Repeat: 	cp -p file from ufs to msdosfs filesystem.
Comment 1 Jeroen Ruigrok van der Werven freebsd_committer freebsd_triage 2000-02-01 15:48:20 UTC
Responsible Changed
From-To: gnats-admin->freebsd-bugs

Misfiled Pr. 
Comment 2 Mike Barcroft freebsd_committer freebsd_triage 2001-07-21 19:38:59 UTC
State Changed
From-To: open->feedback


Does this problem still occur in newer versions of FreeBSD, 
such as 4.3-RELEASE?
Comment 3 Mike Barcroft freebsd_committer freebsd_triage 2001-08-02 03:27:17 UTC
State Changed
From-To: feedback->open


Mail sent to originator bounces.  Leaving open for someone with an 
MS-DOS partition to test.
Comment 4 setantae 2001-08-03 17:10:14 UTC
This problem does exist, yes.

root@rhadamanth /# mount
/dev/ad0s2a on / (ufs, local)
/dev/ad0s2e on /home (ufs, local, soft-updates)
/dev/ad0s2g on /tmp (ufs, local, soft-updates)
/dev/ad0s2h on /usr (ufs, local, soft-updates)
/dev/ad0s2f on /var (ufs, local, soft-updates)
/dev/ad0s5 on /data (msdos, local)
procfs on /proc (procfs, local)
root@rhadamanth /# ls -al /COPYRIGHT 
-r--r--r--  1 root  wheel  4735 Sep 26  2000 /COPYRIGHT
root@rhadamanth /# cp -p /COPYRIGHT /data
root@rhadamanth /# ls -al /data/COPYRIGHT 
-r-xr-xr-x  1 root  wheel  4735 Aug  3 17:04 /data/COPYRIGHT
root@rhadamanth /# 

Ceri
Comment 5 setantae 2001-08-03 17:48:08 UTC
I should have added I am running a build of this morning's tree :

FreeBSD rhadamanth.hounds 4.4-PRERELEASE FreeBSD 4.4-PRERELEASE #4: Fri Aug  3 12:49:51 BST 2001     root@rhadamanth.hounds:/usr/obj/usr/src/sys/RHADAMANTH  i386

Ceri
Comment 6 Mike Barcroft freebsd_committer freebsd_triage 2001-08-05 04:56:36 UTC
Adding to Audit-Trail.

----- Forwarded message from Tony Fleisher <takhus@takhus.mind.net> -----

Delivered-To: mike@freebsd.org
X-Authentication-Warning: takhus.dyn.mind.net: fleisher owned process doing -bs
Date: Thu, 2 Aug 2001 22:56:09 -0700 (PDT)
From: Tony Fleisher <takhus@takhus.mind.net>
X-X-Sender:  <fleisher@takhus.dyn.mind.net>
To: <mike@FreeBSD.ORG>
Cc: <freebsd-bugs@FreeBSD.ORG>
Subject: Re: bin/16155: cp -p does not preserve modification time with msdos-fs
In-Reply-To: <200108020228.f722SBc17521@freefall.freebsd.org>

I am unable to reproduce this problem on a 5.0-Current (July 13) system.

takhus#	ls -l
total 76
-rwxrwxr-x  1 fleisher  fleisher  36513 Jul 13 20:16 NETLOG.TXT
takhus#	cp -p NETLOG.TXT /mnt/win98/temp/
cp: chown: /mnt/win98/temp/NETLOG.TXT: Invalid argument
takhus#	ls -l /mnt/win98/temp
total 48
-rwxrwxr-x  1 root  wheel  36513 Jul 13 20:16 NETLOG.TXT



----- End forwarded message -----
Comment 7 Mike Barcroft freebsd_committer freebsd_triage 2001-08-05 05:11:17 UTC
On Thu, Aug 02, 2001 at 10:56:09PM -0700, Tony Fleisher wrote:
> I am unable to reproduce this problem on a 5.0-Current (July 13) system.
> 
> takhus#	ls -l
> total 76
> -rwxrwxr-x  1 fleisher  fleisher  36513 Jul 13 20:16 NETLOG.TXT
> takhus#	cp -p NETLOG.TXT /mnt/win98/temp/
> cp: chown: /mnt/win98/temp/NETLOG.TXT: Invalid argument
> takhus#	ls -l /mnt/win98/temp
> total 48
> -rwxrwxr-x  1 root  wheel  36513 Jul 13 20:16 NETLOG.TXT

Interesting, the originator confirmed the bug still exists in
4.4-PRERELEASE.  I don't see any changes between -STABLE and -CURRENT
that would affect this.  So I believe it's probably a difference
between the MS-DOS filesystems you and the originator are using.

Would both of you mind supplying more details about which OS you
used to formatted your respective MS-DOS partitions?

Best regards,
Mike Barcroft
Comment 8 Mike Barcroft freebsd_committer freebsd_triage 2001-08-05 05:17:52 UTC
Oops I was mistaken, it wasn't the originator that confirmed it was
still a problem in 4.4-PRERELEASE.  I'll follow up with that user
separately, but I would still appreciate those details from you, Tony.

Best regards,
Mike Barcroft
Comment 9 Mike Barcroft freebsd_committer freebsd_triage 2001-08-05 05:25:21 UTC
Another user has confirmed the bug doesn't exist in 5.0-CURRENT.
I don't see any changes between -STABLE and -CURRENT that would
affect this.  So I believe it's probably a difference between
the MS-DOS filesystems you and the other user are using.

Would you mind supplying more details about which OS you used to
format your MS-DOS partition?

Best regards,
Mike Barcroft
Comment 10 setantae 2001-08-05 16:23:55 UTC
> Would you mind supplying more details about which OS you used to
> format your MS-DOS partition?

No problem - this is a FAT32 partition formatted under Windows2000
Professional.  If the user running CURRENT has a different setup then
let me know the details and if I have the relevant OS then I'll _try_ to
replicate that.

Ceri
Comment 11 Tony Fleisher 2001-08-05 21:03:50 UTC
I am using Win98SE FAT32 filesystem.

On Sun, 5 Aug 2001, Mike Barcroft wrote:

> On Thu, Aug 02, 2001 at 10:56:09PM -0700, Tony Fleisher wrote:
> > I am unable to reproduce this problem on a 5.0-Current (July 13) system.
> >
> > takhus#	ls -l
> > total 76
> > -rwxrwxr-x  1 fleisher  fleisher  36513 Jul 13 20:16 NETLOG.TXT
> > takhus#	cp -p NETLOG.TXT /mnt/win98/temp/
> > cp: chown: /mnt/win98/temp/NETLOG.TXT: Invalid argument
> > takhus#	ls -l /mnt/win98/temp
> > total 48
> > -rwxrwxr-x  1 root  wheel  36513 Jul 13 20:16 NETLOG.TXT
>
> Interesting, the originator confirmed the bug still exists in
> 4.4-PRERELEASE.  I don't see any changes between -STABLE and -CURRENT
> that would affect this.  So I believe it's probably a difference
> between the MS-DOS filesystems you and the originator are using.
>
> Would both of you mind supplying more details about which OS you
> used to formatted your respective MS-DOS partitions?
>
> Best regards,
> Mike Barcroft
>
Comment 12 setantae 2001-08-08 20:51:29 UTC
On Sun, 5 Aug 2001, Tony Fleisher wrote:

> I am using Win98SE FAT32 filesystem.

I'm afraid I don't have Win98SE here.
Closest I've got is Win95osr2.5 - does anyone see any value in me testing
with that ?

Ceri
Comment 13 Ryan Thompson 2002-01-12 08:03:07 UTC
I have tried to reproduce this problem with 4.4-RELEASE, with the
following filesystem types:

	Win95 FAT-16
	Win98 FAT-16
	Win98 FAT-32

Below is a transcript of one such session:

Script started on Sat Jan 12 02:03:00 2002
kat# mount_msdos /dev/ad0s1 /mnt
kat# mount
/dev/ad1s1a on / (ufs, local)
/dev/ad1s1e on /usr (ufs, local, soft-updates)
procfs on /proc (procfs, local)
/dev/ad0s1 on /mnt (msdos, local)
kat# pwd
/tmp
kat# echo foo > bar && touch -t 200001010000.00 bar
kat# cp -p bar /mnt/bar
kat# ll bar /mnt/bar
-rwxr-xr-x  1 root  wheel  4 Jan  1  2000 /mnt/bar
-rw-r--r--  1 root  wheel  4 Jan  1  2000 bar
kat# ll -c bar /mnt/bar
-rwxr-xr-x  1 root  wheel  4 Jan 12 02:03 /mnt/bar
-rw-r--r--  1 root  wheel  4 Jan 12 02:03 bar
kat# umount /mnt
kat# exit
exit

Script done on Sat Jan 12 02:04:57 2002

Unless someone can consistently reproduce this problem under a recent
FreeBSD release, AND can explain exactly which MS-DOS filesystem types
are affected, I think we can close this PR.

This problem likely no longer exists, or was not a bug in the first
place.

- Ryan

-- 
  Ryan Thompson <ryan@sasknow.com>
  Network Administrator, Accounts

  SaskNow Technologies - http://www.sasknow.com
  #106-380 3120 8th St E - Saskatoon, SK - S7H 0W2

        Tel: 306-664-3600   Fax: 306-664-1161   Saskatoon
  Toll-Free: 877-727-5669     (877-SASKNOW)     North America
Comment 14 Dag-Erling Smørgrav freebsd_committer freebsd_triage 2002-01-13 15:51:17 UTC
State Changed
From-To: open->closed

Unable to reproduce problem on 4.4-RELEASE.