Bug 161668

Summary: Critical patch for net/quagga
Product: Ports & Packages Reporter: mike
Component: Individual Port(s)Assignee: Ryan Steinmetz <zi>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
quagga.diff none

Description mike 2011-10-14 22:00:15 UTC 
There is a needed patch for quagga, specifically bgpd that prevents it from leaking memory.  On a busy router, it leaks about 1MB every 10min. Description of the problem and patch are found 
http://lists.quagga.net/pipermail/quagga-users/2011-October/012529.html

Fix: 

--- bgpd/bgp_attr.c
+++ bgpd/bgp_attr.c
@@ -675,6 +675,7 @@ bgp_attr_unintern (struct attr **attr)
     }

   bgp_attr_unintern_sub (&tmp);
+  bgp_attr_extra_free (&tmp);
 }

 void
--

The above patch can be added into the files directory of the port and I added 
PORTREVISION=   1
to the port's Makefile
How-To-Repeat: startup quagga with bgp and a full table.  Watch memory usage grow.
Comment 1 Ryan Steinmetz freebsd_committer freebsd_triage 2011-10-15 13:05:21 UTC 
Maintainer of net/quagga,

Please note that PR ports/161668 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/161668
Comment 2 Ryan Steinmetz freebsd_committer freebsd_triage 2011-10-15 13:05:46 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->zi

I'll take it.
Comment 3 Boris Kovalenko 2011-10-18 14:52:53 UTC 
Hello!

     Agreed, but full patch attached.

-- 
Regards,
Boris
Comment 4 dfilter service freebsd_committer freebsd_triage 2011-10-18 15:43:53 UTC 
zi          2011-10-18 14:43:45 UTC

  FreeBSD ports repository

  Modified files:
    net/quagga           Makefile 
  Added files:
    net/quagga/files     patch-bgpd__bgp_attr.c 
  Log:
  - Resolve memory leak in bgpd
  - Bump PORTREVISION
  
  WWW: http://lists.quagga.net/pipermail/quagga-users/2011-October/012529.html
  
  PR:             ports/161668
  Submitted by:   Mike Tancsa <mike@sentex.net>
  Approved by:    Boris Kovalenko <boris@tagnet.ru> (maintainer)
  Obtained from:  quagga-users mailing list
  
  Revision  Changes    Path
  1.114     +1 -0      ports/net/quagga/Makefile
  1.1       +10 -0     ports/net/quagga/files/patch-bgpd__bgp_attr.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Ryan Steinmetz freebsd_committer freebsd_triage 2011-10-18 15:44:03 UTC 
State Changed
From-To: open->closed

Committed. Thanks!