Bug 161857

Summary: [patch] emulators/qemu-devel: respect NOPORTDOCS, even if it's empty
Product: Ports & Packages Reporter: Nali Toja <nalitoja>
Component: Individual Port(s)Assignee: Juergen Lock <nox>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
nodocs.diff none

Description Nali Toja 2011-10-21 06:40:10 UTC
gmake has slightly different semantics for ifdef/ifndef, the variable
tested *has to* have a value to be treated as defined.

`ifdef VARIABLE-NAME'
     The `ifdef' form takes the _name_ of a variable as its argument,
     [...]
     The value of that variable has a non-empty value, the TEXT-IF-TRUE
     is effective; otherwise, the TEXT-IF-FALSE, if any, is effective.
`ifndef VARIABLE-NAME'
     If the variable VARIABLE-NAME has an empty value, the TEXT-IF-TRUE
     is effective; otherwise, the TEXT-IF-FALSE, if any, is effective.

How-To-Repeat: $ make install deinstall NOPORTDOCS= PREFIX=/foo
$ find /foo ! -type d
/foo/share/doc/qemu/qemu-doc.html
/foo/share/doc/qemu/qemu-tech.html
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-10-21 06:41:09 UTC
Responsible Changed
From-To: freebsd-ports-bugs->nox

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2011-10-22 19:56:14 UTC
nox         2011-10-22 18:56:05 UTC

  FreeBSD ports repository

  Modified files:
    emulators/qemu-devel Makefile pkg-plist 
  Log:
  - Respect CC (sgabios) [1]
  - Respect STRIP [2]
  - Respect NOPORTDOCS, even if it's empty [3]
  - Trim deps for -nographic [4]
  
  PR:             ports/161855 [1], ports/161856 [2], ports/161857 [3],
                  ports/161858 [4]
  Submitted by:   Nali Toja <nalitoja@gmail.com>
  
  Revision  Changes    Path
  1.129     +32 -8     ports/emulators/qemu-devel/Makefile
  1.32      +1 -1      ports/emulators/qemu-devel/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 dfilter service freebsd_committer freebsd_triage 2011-10-22 19:57:40 UTC
nox         2011-10-22 18:57:32 UTC

  FreeBSD ports repository

  Modified files:
    emulators/qemu       Makefile 
  Log:
  - Respect STRIP [1]
  - Respect NOPORTDOCS, even if it's empty [2]
  
  PR:             ports/161856 [1], ports/161857 [2]
  Submitted by:   Nali Toja <nalitoja@gmail.com>
  
  Revision  Changes    Path
  1.121     +5 -1      ports/emulators/qemu/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Juergen Lock freebsd_committer freebsd_triage 2011-10-22 19:59:15 UTC
State Changed
From-To: open->closed

Committed. Thanks!