Bug 162022

Comment 1 Edwin Groothuis 2011-10-26 07:20:15 UTC

Responsible Changed
From-To: freebsd-ports-bugs->ruby

ruby@ wants this port PRs (via the GNATS Auto Assign Tool)

Comment 2 Steve Wills 2011-10-27 19:15:42 UTC

Responsible Changed
From-To: ruby->swills

I'll take it.

Comment 3 Steve Wills 2011-10-27 21:02:50 UTC

Hi,

This looks like a great package, but unfortunately it fails to compile
with Ruby 1.9:


===>  Building for ruby19-bsdconv-1.1
cc -I. -I/usr/local/include/ruby-1.9//amd64-freebsd8
-I/usr/local/include/ruby-1.9//ruby/backward
-I/usr/local/include/ruby-1.9/ -I. -DHAVE_BSDCONV_H -I/usr/local/include  
 -fPIC -I/usr/local/include -O2 -pipe  -fno-strict-aliasing -fPIC
-obsdconv.o -c bsdconv.c
bsdconv.c: In function 'm_new':
bsdconv.c:46: error: 'struct RString' has no member named 'ptr'
bsdconv.c: In function 'm_insert_phase':
bsdconv.c:53: error: 'struct RString' has no member named 'ptr'
bsdconv.c: In function 'm_insert_codec':
bsdconv.c:59: error: 'struct RString' has no member named 'ptr'
bsdconv.c: In function 'm_replace_phase':
bsdconv.c:65: error: 'struct RString' has no member named 'ptr'
bsdconv.c: In function 'm_replace_codec':
bsdconv.c:71: error: 'struct RString' has no member named 'ptr'
bsdconv.c: In function 'm_conv':
bsdconv.c:80: error: 'struct RString' has no member named 'ptr'
bsdconv.c:81: error: 'struct RString' has no member named 'len'
bsdconv.c: In function 'm_conv_chunk':
bsdconv.c:102: error: 'struct RString' has no member named 'ptr'
bsdconv.c:103: error: 'struct RString' has no member named 'len'
bsdconv.c: In function 'm_conv_chunk_last':
bsdconv.c:116: error: 'struct RString' has no member named 'ptr'
bsdconv.c:117: error: 'struct RString' has no member named 'len'
bsdconv.c: In function 'm_conv_file':
bsdconv.c:128: error: 'struct RString' has no member named 'ptr'
bsdconv.c:129: error: 'struct RString' has no member named 'ptr'
*** Error code 1
1 error
===> Compilation failed unexpectedly.

I can patch it if you want, but basically you just need to change things
like this:

RSTRING(arg)->ptr

to something like this

RSTRING_PTR(arg)

and similar for len:

RSTRING(arg)->ptr

to

RSTRING_LEN(arg)

Thanks,
Steve

Thanks, here is new shar:
http://www.cnmc.tw/~buganini/ruby-bsdconv-1.2.shar.txt

--Buganini

Comment 5 dfilter service 2011-10-28 03:06:20 UTC

swills      2011-10-28 02:06:08 UTC

  FreeBSD ports repository

  Modified files:
    converters           Makefile 
  Added files:
    converters/ruby-bsdconv Makefile distinfo pkg-descr pkg-plist 
  Log:
  BSD licensed charset/encoding converter library with more function than
  libiconv. (Currently, only a few codecs are supported)
  This port is a ruby wrapper for bsdconv.
  
  WWW: https://github.com/buganini/ruby-bsdconv
  
  PR:             ports/162022
  Submitted by:   buganini@gmail.com
  
  Revision  Changes    Path
  1.196     +1 -0      ports/converters/Makefile
  1.1       +29 -0     ports/converters/ruby-bsdconv/Makefile (new)
  1.1       +2 -0      ports/converters/ruby-bsdconv/distinfo (new)
  1.1       +5 -0      ports/converters/ruby-bsdconv/pkg-descr (new)
  1.1       +1 -0      ports/converters/ruby-bsdconv/pkg-plist (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"

Comment 6 Steve Wills 2011-10-28 03:09:50 UTC

State Changed
From-To: open->closed

New port added. Thanks!