Bug 16219

Summary: [PATCH] gnome-terminal starts up in secure-keyboard mode
Product: Ports & Packages Reporter: ajk <ajk>
Component: Individual Port(s)Assignee: Ade Lovett <ade>
Status: Closed FIXED    
Severity: Affects Only Me CC: ade
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description ajk 2000-01-20 15:50:00 UTC 
When gnome-terminal starts up, it immediately grabs the keyboard
so that the user can't type into any other X application.

Fix: Initialize the variable that holds the secure keyboard status to
zero.
How-To-Repeat: 
Start up gnome-terminal and check the Settings menu.  "Secure
Keyboard" will be checked, and gnome-terminal will have exclusive
access to input from the keyboard.  In light of the cause, this
problem is probably only reproducible under certain conditions.
Comment 1 Ade Lovett freebsd_committer freebsd_triage 2000-01-20 22:47:42 UTC 
Responsible Changed
From-To: freebsd-ports->ade

My port - I'll handle it
Comment 2 ade 2000-01-20 23:03:04 UTC 
On Thu, Jan 20, 2000 at 10:40:50AM -0500, ajk@waterspout.com wrote:
> 
> When gnome-terminal starts up, it immediately grabs the keyboard
> so that the user can't type into any other X application.

I believe a more appropriate patch would be as follows:

--- gnome-terminal.c	Thu Jan 20 16:59:30 2000
+++ gnome-terminal.c.new	Thu Jan 20 17:00:49 2000
@@ -480,6 +480,7 @@
 		cfg->color_type = PALETTE_CUSTOM;
 	else
 		cfg->color_type = PALETTE_LINUX;
+	cfg->keyboard_secured = gnome_config_get_bool ("keyboard_secured=0");
 	cfg->bell      = gnome_config_get_bool ("bell_silenced=0");
 	cfg->blink     = gnome_config_get_bool ("blinking=0");
 	cfg->swap_keys = gnome_config_get_bool ("swap_del_and_backspace=0");
@@ -995,6 +996,7 @@
 	gnome_config_set_string ("scrollpos",
 				 cfg->scrollbar_position == SCROLLBAR_LEFT ? "left" :
 				 cfg->scrollbar_position == SCROLLBAR_RIGHT ? "right" : "hidden");
+	gnome_config_set_bool	("keyboard_secured", cfg->keyboard_secured);
 	gnome_config_set_bool   ("bell_silenced", cfg->bell);
 	gnome_config_set_bool   ("blinking", cfg->blink);
 	gnome_config_set_bool   ("swap_del_and_backspace", cfg->swap_keys);

Allowing for the behavior to be stored in the Terminal configuration
file, rather than simply forcibly setting it off, which may not be
what is required.

Please let me know what you think.

-aDe

-- 
Ade Lovett, Austin, TX.
Comment 3 ajk 2000-01-21 00:44:46 UTC 
> On Thu, Jan 20, 2000 at 10:40:50AM -0500, ajk@waterspout.com wrote:
> > 
> > When gnome-terminal starts up, it immediately grabs the keyboard
> > so that the user can't type into any other X application.
> 
> I believe a more appropriate patch would be as follows:
> 
> --- gnome-terminal.c	Thu Jan 20 16:59:30 2000
> +++ gnome-terminal.c.new	Thu Jan 20 17:00:49 2000
> @@ -480,6 +480,7 @@
>  		cfg->color_type = PALETTE_CUSTOM;
>  	else
>  		cfg->color_type = PALETTE_LINUX;
> +	cfg->keyboard_secured = gnome_config_get_bool ("keyboard_secured=0");
>  	cfg->bell      = gnome_config_get_bool ("bell_silenced=0");
>  	cfg->blink     = gnome_config_get_bool ("blinking=0");
>  	cfg->swap_keys = gnome_config_get_bool ("swap_del_and_backspace=0");
> @@ -995,6 +996,7 @@
>  	gnome_config_set_string ("scrollpos",
>  				 cfg->scrollbar_position == SCROLLBAR_LEFT ? "l
> eft" :
>  				 cfg->scrollbar_position == SCROLLBAR_RIGHT ? "
> right" : "hidden");
> +	gnome_config_set_bool	("keyboard_secured", cfg->keyboard_secured);
>  	gnome_config_set_bool   ("bell_silenced", cfg->bell);
>  	gnome_config_set_bool   ("blinking", cfg->blink);
>  	gnome_config_set_bool   ("swap_del_and_backspace", cfg->swap_keys);
> 
> Allowing for the behavior to be stored in the Terminal configuration
> file, rather than simply forcibly setting it off, which may not be
> what is required.

I thought about that and couldn't think why one would want it to
be configurable that way, but I suppose it is more general.
Actually, I don't know why anyone would use the feature what with
SSH and XAUTH.

ajk
Comment 4 Ade Lovett freebsd_committer freebsd_triage 2000-01-21 03:55:35 UTC 
State Changed
From-To: open->closed

Update committed (with modifications), thanks!