Bug 162204

Summary:	multimedia/libxine Makefile triggers IGNORE with CFLAGS set to -Os
Product:	Ports & Packages	Reporter:	Samuel Duclos <wiseakasha>
Component:	Individual Port(s)	Assignee:	Juergen Lock <nox>
Status:	Closed FIXED
Severity:	Affects Only Me
Priority:	Normal
Version:	Latest
Hardware:	Any
OS:	Any

Description Samuel Duclos 2011-10-31 19:10:07 UTC

/usr/ports/multimedia/libxine/Makefile: Checks for CFLAGS less than -O1 but rejects recent gcc optimization levels such as -Os, which incorrectly triggers an IGNORE prompting for at least an -O1. Please include newer gcc optimization levels in this test as current workarounds are messy to deal with.
P.S.: Makefile is 11 years old??

Fix: 

Simple boolean logic involved here... I suggest a blacklist instead of a whitelist here, which only complicates the testing here.
How-To-Repeat: Build multimedia/libxine with CFLAGS=-Os

Comment 1 Edwin Groothuis freebsd_committer

2011-10-31 19:10:17 UTC

Responsible Changed
From-To: freebsd-ports-bugs->nox

Over to maintainer (via the GNATS Auto Assign Tool)

Comment 2 dfilter service freebsd_committer

2011-10-31 20:56:08 UTC

nox         2011-10-31 20:55:56 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/libxine   Makefile 
  Log:
  Generalize optimization sanity check so that levels like -Os are
  accepted too.
  
  PR:             ports/162204
  Submitted by:   Samuel Duclos <wiseakasha@hotmail.com>
  
  Revision  Changes    Path
  1.175     +2 -1      ports/multimedia/libxine/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"

Comment 3 Juergen Lock freebsd_committer

2011-10-31 20:58:15 UTC

State Changed
From-To: open->closed

Fix committed. Thanks!