Bug 162504

Summary: Committer's guide should probably mention mentor approval for first steps
Product: Documentation Reporter: Chris Rees <utisoft>
Component: Books & ArticlesAssignee: Chris Rees <crees>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description Chris Rees 2011-11-12 17:50:08 UTC 
Unless a new mentor explicitly requests review of the very first traditional patches [1], the mentee may not realise that they require approval!

[1] http://www.freebsd.org/doc/en/articles/committers-guide/conventions.html

Fix: 

http://www.bayofrum.net/~crees/patches/committers-guide-mentor-approval.patch.txt

Rendered: http://www.bayofrum.net/~crees/patches/committers-guide-mentor-approval.html

[if you don't want the hassle of committing this, I'll take a bounce to me as approval]
Comment 1 Glen Barber freebsd_committer freebsd_triage 2011-11-12 17:57:13 UTC 
On 11/12/11 12:42 PM, Chris Rees wrote:
> Rendered: http://www.bayofrum.net/~crees/patches/committers-guide-mentor-approval.html
> 
> [if you don't want the hassle of committing this, I'll take a bounce to me as approval]
> 


Hi Chris,

Good idea explicitly mentioning this.  Please commit it.

Thanks.

-- 
Glen Barber | gjb@FreeBSD.org
FreeBSD Documentation Project
Comment 2 dfilter service freebsd_committer freebsd_triage 2011-11-12 17:57:23 UTC 
crees       2011-11-12 17:57:14 UTC

  FreeBSD doc repository (ports committer)

  Modified files:
    en_US.ISO8859-1/articles/committers-guide article.sgml 
  Log:
  Note that mentor approval is required for all patches, however trivial
  
  PR:             docs/162504
  Approved by:    gjb
  
  Revision  Changes    Path
  1.306     +5 -0      doc/en_US.ISO8859-1/articles/committers-guide/article.sgml
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Chris Rees freebsd_committer freebsd_triage 2011-11-12 17:57:28 UTC 
State Changed
From-To: open->closed

Committed.
Comment 4 Chris Rees freebsd_committer freebsd_triage 2011-11-12 17:58:05 UTC 
Responsible Changed
From-To: freebsd-doc->crees

I closed it