Bug 16275

Summary: approve send-pr(1) (attach files, use enviroment vars)
Product: Base System Reporter: Alexander Langer <alex>
Component: binAssignee: Steve Price <steve>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 4.0-CURRENT   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
send-pr.diff none

Description Alexander Langer 2000-01-21 20:10:01 UTC
This patch improves the send-pr(1) functionality.
manpages are not included yet, but if the patch is ok, I'll fix the manpage as
well.
it's really nice and should be delivered now on all releases ;-)

What does it do?

1) add an -a option, which makes it possible to attach text and binary files.
The attached files go into the Fixes section.
binary files are uuencoded, text files are included with a
--- filename begins here ---
stuff
--- filename ends here ---
as you can see below (this pr is filed using my changes)

ALSO, you can specify PR_* vars, which makes the use of send-pr(1) out
of scripts VERY nice.
e.g., I've discovered, when I update ports I ALWAYS write the same 
stuff.
I could create an alias as

alias send-ports-pr='echo -n "Please enter the synopsis: "; read syn; PR_SYNOPSIS=$syn PR_CATEGORY=ports PR_CONFIDENTAL=no PR_PRIORITY=medium PR_SEVERITY=non-critical send-pr'

which then automatically inserts the stuff into the fields...nice, isn't it?
then:
send-ports-pr -a port-diff.diff
also includes the patch for the port.

Wow, I do really like it.
I hope you will too, since it does not destroy any of the old funtionality.

How-To-Repeat: 
n/a
Comment 1 Johan Karlsson freebsd_committer freebsd_triage 2000-08-12 22:57:13 UTC
Responsible Changed
From-To: freebsd-bugs->steve

Steve is our gnats admin person and knows (maintains) send-pr.
Comment 2 alex freebsd_committer freebsd_triage 2001-07-11 19:05:36 UTC
State Changed
From-To: open->closed

The attach thing has been added recently. 
The remainding diffs can probably solved in a more elegant way, 
so I'm closing this PR now.