Bug 163193

Summary: [PATCH] Fix port x11-wm/skippy-xd for amd64 arch
Product: Ports & Packages Reporter: Vincent Hoffman-Kazlauskas <vince>
Component: Individual Port(s)Assignee: Roman Bogorodskiy <novel>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Vincent Hoffman-Kazlauskas 2011-12-12 00:40:01 UTC 
This port wasnt working for me on an amd64 system. I have not tried on i386.
A quick google around found 
http://freecode.com/projects/skippy/comments
The sed in the second comment fixed it for me.

Fix: Patch attached with submission follows:
How-To-Repeat: install and try to run skippy-xd on an amd64 system.
Comment 1 Roman Bogorodskiy freebsd_committer freebsd_triage 2011-12-13 11:31:52 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->novel

I will take it.
Comment 2 Roman Bogorodskiy freebsd_committer freebsd_triage 2011-12-13 11:56:07 UTC 
Hi,

This port builds fine both on my 8-STABLE / amd64 and 9.0-BETA3 / amd64
tinderbox:

http://www.bayofrum.net/tb/logs/9-novel/skippy-xd-0.5.0_1.log

Could you provide more details on reproducing the problem and a build
log for the failed build?

Roman Bogorodskiy
Comment 3 Vincent Hoffman-Kazlauskas 2011-12-13 14:50:27 UTC 
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 13/12/2011 11:56, Roman Bogorodskiy wrote:
> Hi,
>
> This port builds fine both on my 8-STABLE / amd64 and 9.0-BETA3 / amd64
> tinderbox:
>
> http://www.bayofrum.net/tb/logs/9-novel/skippy-xd-0.5.0_1.log
>
> Could you provide more details on reproducing the problem and a build
> log for the failed build?
>
> Roman Bogorodskiy
Hi,
    Sorry I wasn't clear enough in the bug report.
The port will build fine on my system without the changes but crashed
when I tried to use it (press the hotkey, default is f11 once its running.)

I dont have the exact error produced but it was similar enough to the
one on the web page referenced in the PR
(http://freecode.com/projects/skippy/comments 2nd comment.) that a
google search brought that up. If you need the exact error I will
rebuild without the patch.

Its entirely possible its not just a 32 vs 64 bit issue as I'm not a c
programmer but making these changes did make it work for me. I dont have
any other systems running X to test on at the moment.

Vince
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJO52YzAAoJEF4mgOY1fXowCTsP/2ZMfVFJyVJetTWJHooF1ebi
tewICelVI+UOKbSV0/0ldpY764LxL+icJE6dZaVMURHoop24tQ2J6kfwUJIo0G9f
KSjkqD5OhrxriICqgire93lJsbUAw0jQOb1NC5vJz3YdtR7JuR/06vGK9XTIPj2M
FP9n2XCuMTk0HtJfiZgklNQYjxDy9nCgc+CvCy0cVXS1zhQZHDpFtiV3VkUSAZ/1
hOYYnmwzlEBQrFR4OYHzih9E9V7zvcQbuKD9kTKjojg4MQvbaSf7+cIdow6+twHW
Z6jN6JuUQxcvcxtXd9y/n9XrYXxnWTxiqsPfMgMMojAzuuqUsMYBX/kwm5GgOpl1
A+BB171iaOvViatcpB7r5dEbFJSWflOpcbL1GOkWbXdlg+Igwxt8tOq3tsfidooZ
tHzAi+CJtncJsx9dpm+2/vPSEpy1+yFkFukUmX97bj5HD4gxY3hffi5fa58WhM9q
nzirjqAig7nT4at6OhnXYZ0TlgbAaOpZySktgY/psOAQ07YWEz8qnQ5/XS1pHWSe
OVn5YBDtQSRXd4DcFYoYe2nhKehcXE/J9VSsFTtyNClV0Ny6m6hWnsVgLcP1DmTm
+FQOj8k6U4oPEUQT9CpU6/oKOXlVXoxNEVw1GBXgOZowtGcY6ZTpP9R7/AgMv4ke
k4ES+Bg38NDdQqoiAXpE
=B5MB
-----END PGP SIGNATURE-----
Comment 4 dfilter service freebsd_committer freebsd_triage 2011-12-13 15:37:54 UTC 
novel       2011-12-13 15:37:47 UTC

  FreeBSD ports repository

  Modified files:
    x11-wm/skippy-xd     Makefile 
  Log:
  - Fix runtime crash on amd64
  - Bump PORTREVISION
  
  PR:             163193
  Submitted by:   Vincent Hoffman-Kazlauskas <vince@unsane.co.uk>
  Feature safe:   yes
  
  Revision  Changes    Path
  1.8       +11 -2     ports/x11-wm/skippy-xd/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Roman Bogorodskiy freebsd_committer freebsd_triage 2011-12-13 15:39:17 UTC 
State Changed
From-To: open->closed

Committed, thanks!
Comment 6 Roman Bogorodskiy freebsd_committer freebsd_triage 2011-12-13 15:42:55 UTC 
  Vincent Hoffman wrote:

> Hi,
>     Sorry I wasn't clear enough in the bug report.
> The port will build fine on my system without the changes but crashed
> when I tried to use it (press the hotkey, default is f11 once its running.)
> 
> I dont have the exact error produced but it was similar enough to the
> one on the web page referenced in the PR
> (http://freecode.com/projects/skippy/comments 2nd comment.) that a
> google search brought that up. If you need the exact error I will
> rebuild without the patch.
> 
> Its entirely possible its not just a 32 vs 64 bit issue as I'm not a c
> programmer but making these changes did make it work for me. I dont have
> any other systems running X to test on at the moment.


Yeah, I was able to reproduce runtime crash and your fix works for me as
well, thanks!

Roman Bogorodskiy