Bug 163548

Summary:	[UPDATE] ftp/vsftpd-ext will not compile on non i386 arch
Product:	Ports & Packages	Reporter:	Michael Scheidell <scheidell>
Component:	Individual Port(s)	Assignee:	Michael Scheidell <scheidell>
Status:	Closed FIXED
Severity:	Affects Only Me	CC:	gabor
Priority:	Normal
Version:	Latest
Hardware:	Any
OS:	Any

Description Michael Scheidell freebsd_committer

2011-12-22 23:00:22 UTC

	makefile cflags need to be environment, not hard coded.
===>  Building for vsftpd-ext-2.3.4.2
> gcc -c main.c -O2 -fno-strict-aliasing -pipe -O2 -pipe -march=prescott -fno-strict-aliasing       -O2 -Wall -W 
-Wshadow -idirafter dummyinc
> main.c:1: error: CPU you selected does not support x86-64 instruction set
> main.c:1: error: CPU you selected does not support x86-64 instruction set
> *** Error code 1
>

Fix: This patch will eliminate the change to cflags. (note:  CFLAGS in /etc/make.conf(default) are automatically applied)



______________________________________________________________________
This email has been scanned and certified safe by SpammerTrap(r). 
For Information please see http://www.spammertrap.com/
______________________________________________________________________--vxySfjv0JSmOR60Bdf549HgF0XwVQUp1gdzNWc4bDswq6kll
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

Index: files/patch-Makefile
===================================================================
RCS file: /home/pcvs/ports/ftp/vsftpd-ext/files/patch-Makefile,v
retrieving revision 1.1
diff -u -u -r1.1 patch-Makefile
--- files/patch-Makefile	21 Dec 2011 13:19:37 -0000	1.1
+++ files/patch-Makefile	22 Dec 2011 22:54:01 -0000
@@ -1,14 +1,11 @@
---- ./Makefile.orig	2011-12-13 10:14:07.000000000 +0200
-+++ ./Makefile	2011-12-13 10:15:30.000000000 +0200
-@@ -3,9 +3,9 @@
- INSTALL	=       install
- IFLAGS  = -idirafter dummyinc
+--- Makefile.orig	2011-07-03 17:03:07.000000000 -0400
++++ Makefile	2011-12-22 17:51:53.000000000 -0500
+@@ -5,7 +5,7 @@
  #CFLAGS = -g
--CFLAGS	=       -O2 -Wall -W -Wshadow #-pedantic -Werror -Wconversion
-+CFLAGS	= -O2 -pipe -march=prescott -fno-strict-aliasing       -O2 -Wall -W -Wshadow #-pedantic -Werror -Wconversion
+ CFLAGS	=       -O2 -Wall -W -Wshadow #-pedantic -Werror -Wconversion
  
 -LIBS	=       -lcap -ldl -lcrypt    -lpam    -lwrap -lnsl    -lssl -lcrypto
-+LIBS=	-lpam
++LIBS	=       -lpam
  #                                     |        |               + VSF_BUILD_SSL
  #                                     |        + VSF_BUILD_TCPWRAPPERS
  #                                     + VSF_BUILD_PAM
How-To-Repeat: 	try to compile on a non 9386 arch

Comment 1 Edwin Groothuis freebsd_committer

2011-12-22 23:00:33 UTC

Responsible Changed
From-To: freebsd-ports-bugs->scheidell

Submitter has GNATS access (via the GNATS Auto Assign Tool)

Comment 2 Edwin Groothuis freebsd_committer

2011-12-22 23:00:38 UTC

Maintainer of ftp/vsftpd-ext,

Please note that PR ports/163548 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/163548

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org

Comment 3 Edwin Groothuis freebsd_committer

2011-12-22 23:00:41 UTC

State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)

Comment 4 gelraen.ua 2011-12-23 05:46:30 UTC

Yep, it's my mistake :( Commit this, please.

Comment 5 Michael Scheidell freebsd_committer

2011-12-23 19:07:28 UTC

State Changed
From-To: feedback->closed

Patch for ports pr/163550 applied instead, via private email from maintainer

Comment 6 dfilter service freebsd_committer

2011-12-26 20:40:43 UTC

scheidell    2011-12-26 20:40:28 UTC

  FreeBSD ports repository

  Removed files:
    ftp/vsftpd-ext/files patch-Makefile 
  Log:
  - Remove ../files/patch-Makefile (again)
  
  PR:             ports/163548
  Approved by:    gabor (mentor)
  
  Revision  Changes    Path
  1.2       +0 -14     ports/ftp/vsftpd-ext/files/patch-Makefile (dead)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"