Bug 163551

Summary: www/xpi-flashblock: make it working with new firefox version
Product: Ports & Packages Reporter: Barbara <barbara.xxx1975>
Component: Individual Port(s)Assignee: Rene Ladan <rene>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Barbara 2011-12-23 01:50:09 UTC 
Make www/xpi-flashblock working with new firefox version from ports

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-12-23 01:50:18 UTC 
Class Changed
From-To: sw-bug->maintainer-update

Fix category (submitter is maintainer) (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-12-23 01:50:23 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->rene

rene@ wants his PRs (via the GNATS Auto Assign Tool)
Comment 3 Rene Ladan freebsd_committer freebsd_triage 2011-12-26 15:40:30 UTC 
Wouldn't it be easier and more fail-safe to apply the patch inline in
the Makefile? It also saves some trivial patch files.

Currently the patch fails because of DOS/UNIX line ending mismatches:
http://rene-ladan.nl:8080/tb/errors/9-FreeBSD/xpi-flashblock-1.5.15.1_2.log

And also do this for xpi-server_spy and xpi-showip?
Comment 4 Barbara 2011-12-26 16:53:08 UTC 
I wrote the patch in this way because that has been preferred in ports/162449 
(it's also true that the preferred one come from maintainer).
Then I considered that it was easier to understand the purpose of the patch 
and to apply fix for future versions.

Anyway here's a new patch inlined in Makefile
http://pastebin.com/7SEnsbEw
I've intentionally left the tag in the sed command for the reason explained 
above.
Patches for other ports are coming soon.
Comment 5 Rene Ladan freebsd_committer freebsd_triage 2011-12-26 21:09:54 UTC 
State Changed
From-To: open->closed

Committed, thanks
Comment 6 dfilter service freebsd_committer freebsd_triage 2011-12-26 21:09:54 UTC 
rene        2011-12-26 21:09:45 UTC

  FreeBSD ports repository

  Modified files:
    www/xpi-flashblock   Makefile 
  Log:
  - Enable running this plugin with current and future Firefox versions. [1]
  - Fix portlint error, PORTREVISION must be after DISTVERSION*
  
  PR:             ports/163551 [1]
  Submitted by:   maintainer
  
  Revision  Changes    Path
  1.18      +8 -1      ports/www/xpi-flashblock/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"