Bug 163623

Summary:	[kernel] sysctl net.inet.icmp.icmplim_output description is misleading
Product:	Base System	Reporter:	Eugene Grosbein <ports>
Component:	kern	Assignee:	Eitan Adler <eadler>
Status:	Closed FIXED
Severity:	Affects Only Me
Priority:	Normal
Version:	8.2-STABLE
Hardware:	Any
OS:	Any
Bug Depends on:
Bug Blocks:	150917

Description Eugene Grosbein 2011-12-26 05:40:12 UTC

	"sysctl -d net.inet.icmp.icmplim_output" says:

net.inet.icmp.icmplim_output: Enable rate limiting of ICMP responses

	In fact, this setting does not control rate limiting of ICMP responses.
	Instead, it controls whether kernel writes log messages
	about this limiting or not.

Fix: 

Change wording in src/sys/netinet/ip_icmp.c for this setting.
How-To-Repeat: 
	See above.

Comment 1 Eitan Adler freebsd_committer

2011-12-26 05:52:26 UTC

Responsible Changed
From-To: freebsd-bugs->eadler

I'll take it.

Comment 2 dfilter service freebsd_committer

2012-01-07 00:11:45 UTC

Author: eadler (ports committer)
Date: Sat Jan  7 00:11:36 2012
New Revision: 229749
URL: http://svn.freebsd.org/changeset/base/229749

Log:
  - Fix sysctl description
  
  PR:		163623
  Submitted by:	Eugene Grosbein <eugen@eg.sd.rdtc.ru>
  Approved by:	bz

Modified:
  head/sys/netinet/ip_icmp.c

Modified: head/sys/netinet/ip_icmp.c
==============================================================================
--- head/sys/netinet/ip_icmp.c	Sat Jan  7 00:07:23 2012	(r229748)
+++ head/sys/netinet/ip_icmp.c	Sat Jan  7 00:11:36 2012	(r229749)
@@ -89,7 +89,7 @@ static VNET_DEFINE(int, icmplim_output) 
 #define	V_icmplim_output		VNET(icmplim_output)
 SYSCTL_VNET_INT(_net_inet_icmp, OID_AUTO, icmplim_output, CTLFLAG_RW,
 	&VNET_NAME(icmplim_output), 0,
-	"Enable rate limiting of ICMP responses");
+	"Enable logging of ICMP response rate limiting");
 
 #ifdef INET
 VNET_DEFINE(struct icmpstat, icmpstat);
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"

Comment 3 Eitan Adler freebsd_committer

2012-01-07 03:48:19 UTC

State Changed
From-To: open->patched

committed in r229749

Comment 4 Eitan Adler freebsd_committer

2012-03-22 03:41:51 UTC

State Changed
From-To: patched->closed

Committed. Thanks!