Bug 163743

Summary: FreeBSD Port devel/py-sip OPTIONSFILE Patch
Product: Ports & Packages Reporter: A.J. Kehoe IV <vOo4vyPj>
Component: Individual Port(s)Assignee: freebsd-kde (group) <kde>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description A.J. Kehoe IV 2011-12-31 22:20:07 UTC 
Some ports management scripts override the default "OPTIONSFILE" for each port by defining it as an environment variable.  In the devel/py-sip Makefile, this is overridden, thus causing problems for some ports management scripts.

Fix: mv /usr/ports/devel/py-sip/Makefile /usr/ports/devel/py-sip/Makefile.old

sed 's/^OPTIONSFILE=/OPTIONSFILE?=/' /usr/ports/devel/py-sip/Makefile.old > /usr/ports/devel/py-sip/Makefile

Patch attached with submission follows:
How-To-Repeat: 1. Install a ports management script that overrides the default "OPTIONSFILE" for each port.

2. cd /usr/ports/devel/py-sip

3. OPTIONSFILE="/example/options" make config

4. Notice that "/example/options" was not created.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-12-31 22:20:17 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->kde

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2012-01-24 23:40:31 UTC 
avilla      2012-01-24 23:40:22 UTC

  FreeBSD ports repository

  Modified files:
    databases/py-qt4-sql Makefile 
    devel/py-qt4-assistant Makefile 
    devel/py-qt4-core    Makefile 
    devel/py-qt4-dbus    Makefile 
    devel/py-qt4-declarative Makefile 
    devel/py-qt4-designer Makefile 
    devel/py-qt4-designerplugin Makefile 
    devel/py-qt4-help    Makefile 
    devel/py-qt4-qscintilla2 Makefile 
    devel/py-qt4-script  Makefile 
    devel/py-qt4-scripttools Makefile 
    devel/py-qt4-test    Makefile 
    devel/py-sip         Makefile distinfo 
    devel/py-sip/files   bsd.pyqt.mk 
    graphics/py-qt4-svg  Makefile 
    misc/py-qt4-demo     Makefile 
    multimedia/py-qt4-multimedia Makefile 
    multimedia/py-qt4-phonon Makefile 
    net/py-qt4-network   Makefile 
    textproc/py-qt4-xml  Makefile 
    textproc/py-qt4-xmlpatterns Makefile 
    www/py-qt4-webkit    Makefile 
    x11/py-qt4-opengl    Makefile 
    x11-toolkits/py-qt4-gui Makefile 
  Log:
  - Pet Tinderbox and friends.
  
  OPTIONSFILE must be set using ?= to allow overriding.
  
  PR:             163743
  PR:             163744
  PR:             163745
  PR:             163746
  Submitted by:   A.J. Kehoe IV (Nanoman) <vOo4vyPj@nanoman.ca>
  
  Revision  Changes    Path
  1.16      +1 -1      ports/databases/py-qt4-sql/Makefile
  1.16      +1 -1      ports/devel/py-qt4-assistant/Makefile
  1.16      +1 -1      ports/devel/py-qt4-core/Makefile
  1.16      +1 -1      ports/devel/py-qt4-dbus/Makefile
  1.3       +1 -1      ports/devel/py-qt4-declarative/Makefile
  1.17      +1 -1      ports/devel/py-qt4-designer/Makefile
  1.16      +1 -1      ports/devel/py-qt4-designerplugin/Makefile
  1.8       +1 -1      ports/devel/py-qt4-help/Makefile
  1.19      +1 -1      ports/devel/py-qt4-qscintilla2/Makefile
  1.15      +1 -1      ports/devel/py-qt4-script/Makefile
  1.9       +1 -1      ports/devel/py-qt4-scripttools/Makefile
  1.16      +1 -1      ports/devel/py-qt4-test/Makefile
  1.44      +1 -1      ports/devel/py-sip/Makefile
  1.36      +2 -2      ports/devel/py-sip/distinfo
  1.15      +3 -5      ports/devel/py-sip/files/bsd.pyqt.mk
  1.16      +1 -1      ports/graphics/py-qt4-svg/Makefile
  1.18      +1 -1      ports/misc/py-qt4-demo/Makefile
  1.5       +1 -1      ports/multimedia/py-qt4-multimedia/Makefile
  1.10      +1 -1      ports/multimedia/py-qt4-phonon/Makefile
  1.18      +1 -1      ports/net/py-qt4-network/Makefile
  1.18      +1 -1      ports/textproc/py-qt4-xml/Makefile
  1.7       +1 -1      ports/textproc/py-qt4-xmlpatterns/Makefile
  1.8       +1 -1      ports/www/py-qt4-webkit/Makefile
  1.23      +1 -1      ports/x11-toolkits/py-qt4-gui/Makefile
  1.17      +1 -1      ports/x11/py-qt4-opengl/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Alberto Villa freebsd_committer freebsd_triage 2012-01-24 23:41:12 UTC 
State Changed
From-To: open->closed

Committed. Thanks!